davids5 commented on code in PR #12350: URL: https://github.com/apache/nuttx/pull/12350#discussion_r1604680979
########## arch/arm/src/stm32h7/stm32_rcc.c: ########## @@ -59,7 +59,7 @@ #elif defined(CONFIG_STM32H7_STM32H7B3XX) # include "stm32h7x3xx_rcc.c" #elif defined(CONFIG_STM32H7_STM32H7X5XX) -# include "stm32h7x3xx_rcc.c" +# include "stm32h7x5xx_rcc.c" Review Comment: @jfbblue0922 I was suggesting you do not duplicate the stm32h7x5xx_rcc but use stm32h7x3xx_rcc file with just the single `Ifdef` for the changes from 3 to 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
