jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618784990
##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
regval |= STM32_PWR_CR3_SCUEN;
putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_LDO_SUPPLY)
+ regval = getreg32(STM32_PWR_CR3);
+ regval &= ~(STM32_PWR_CR3_BYPASS | STM32_PWR_CR3_SCUEN |
+ STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
+ regval |= STM32_PWR_CR3_LDOEN;
+ putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_SMPS_LDO) || \
+ defined(CONFIG_STM32H7_PWR_EXT_SMPS_LDO) || \
+ defined(CONFIG_STM32H7_PWR_EXT_SMPS_BYPASS) || \
+ defined(CONFIG_STM32H7_PWR_BYPASS)
+ /* These 4 cases of power supply mode have no macros created.
+ * Selecting one of these modes will cause a compile error.
+ */
+ #error Macro of this power supply mode is not created yet.
Review Comment:
@davids5
Before this PR, we could only use DIRECT_SMPS_SYPPLY mode or else.
And we just want to use LDO_SUPPLY mode.
Should we remove the 4 modes that no one is currently using?
And we are trying to be careful not to break the existing board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
