Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-05 Thread via GitHub
xiaoxiang781216 merged PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-04 Thread via GitHub
Donny9 commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2772781822 @yamt hello, we already have it, you can use dd command in nsh with parameter "conv=trunc". By the way, there are two implementations of dd in the current system, one under nshlib a

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-04 Thread via GitHub
yamt commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2774082719 > @yamt hello, we already have it, you can use dd command in nsh with parameter "conv=trunc". By the way, there are two implementations of dd in the current system, one under nshlib and t

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-03 Thread via GitHub
yamt commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2777492317 > > > i'm not interested in the nshlib version of it. > > > i didn't know the nshlib version already had the functionality. thank you for pointing out. > > > implementation-wise, i p

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-03 Thread via GitHub
xiaoxiang781216 commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2775313123 let's merge this patch first, @Donny9 please migrate the new feature from nshlib and remove that implementation to avoid the code duplication. -- This is an automated message

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-02 Thread via GitHub
yamt commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2774125166 > > i'm not interested in the nshlib version of it. > > i didn't know the nshlib version already had the functionality. thank you for pointing out. > > implementation-wise, i prefer

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-02 Thread via GitHub
Donny9 commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2774111842 > i'm not interested in the nshlib version of it. > i didn't know the nshlib version already had the functionality. thank you for pointing out. > implementation-wise, i prefer this

Re: [PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-02 Thread via GitHub
nuttxpr commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2772685496 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR likely *does not* meet the NuttX require

[PR] system/dd: Implement conv=notrunc [nuttx-apps]

2025-04-02 Thread via GitHub
yamt opened a new pull request, #3048: URL: https://github.com/apache/nuttx-apps/pull/3048 ## Summary https://pubs.opengroup.org/onlinepubs/9699919799/utilities/dd.html > notrunc > Do not truncate the output file. Preserve blocks in the output > file not explicitly written