nuttxpr commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2772685496
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR likely *does not* meet the NuttX requirements based on the information provided. The provided information only mentions the `notrunc` option of the `dd` utility and a link to its documentation. This tells us *nothing* about the actual changes made in the PR, its impact, or how it was tested. All the required sections are essentially empty. To meet the requirements, the PR description needs to be substantially expanded to address *all* the points listed in the template: * **Summary:** Explain *why* this change to `dd` (presumably adding `notrunc` support) is needed in NuttX. What problem does it solve? Which part of the `dd` code was modified? Provide links to related NuttX issues. * **Impact:** Carefully consider and document the impact of this change on users, the build process, hardware, documentation, security, and compatibility. Don't just say "NO" – explain why there is no impact if that's the case. * **Testing:** Specify the build host and target environments used for testing. Provide *actual* testing logs demonstrating the behavior before and after the change. Show that the `notrunc` option works as expected. Simply saying "your testing logs here" is insufficient. Without this information, it's impossible to determine if the PR meets the NuttX requirements. A reviewer will likely reject the PR in its current state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
