yamt commented on PR #3048:
URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2774082719

   > @yamt hello, we already have it, you can use dd command in nsh with 
parameter "conv=trunc". By the way, there are two implementations of dd in the 
current system, one under nshlib and the other under system/dd. Please move the 
functionality of nshlib to system/dd? What do you think?
   
   i'm not interested in the nshlib version of it.
   i didn't know the nshlib version already had the functionality. thank you 
for pointing out.
   implementation-wise, i prefer this PR because the nshlib implementation 
looks poor. (the use of strstr instead of a proper parsing of the options.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to