Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-16 Thread via GitHub
xiaoxiang781216 merged PR #15205: URL: https://github.com/apache/nuttx/pull/15205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-15 Thread via GitHub
HongChao6 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2594439558 > Please fix the commit title: nuxxt -> nuttx done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-15 Thread via GitHub
terry0012 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1916349123 ## include/nuttx/input/touchscreen.h: ## @@ -227,8 +227,6 @@ struct touch_sample_s #define SIZEOF_TOUCH_SAMPLE_S(n) \ (sizeof(struct touch_sample_s) + ((n) - 1) *

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-15 Thread via GitHub
terry0012 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887954498 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Com

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-11 Thread via GitHub
terry0012 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585279467 @HongChao6 Let's revert the change in Kconfig. and remove #ifdef/#else around the public struct in mouse.h & touchscreen.h & keyboard.h. Thanks. -- This is an automated message

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-11 Thread via GitHub
acassis commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585246434 > remove #ifdef/#else around the public struct, macro and function from .h is also other option to solve this problem, How do you think? @acassis > > @raiden00pl @PetteriAim

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-11 Thread via GitHub
xiaoxiang781216 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585202804 > remove #ifdef/#else around the public struct, macro and function from .h is also other option to solve this problem, How do you think? @acassis let's go this direction -

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-10 Thread via GitHub
terry0012 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585125824 remove #ifdef/#else around the public struct, macro and function from .h is also other option to solve this problem, How do you think? @acassis -- This is an automated message fr

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-10 Thread via GitHub
terry0012 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585125159 > @raiden00pl @PetteriAimonen @lupyuen please take a look. > > I think since now the user will be able to see and enable the Mouse, Touchscreen and Keyboard we need to have the de

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-24 Thread via GitHub
acassis commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2561676777 @HongChao6 could you please modify to Kconfig to put all Keyboard drivers under "Enable Keyboard Support", all Mouser drivers under "Enable Mouse Support", and so on. These options need t

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-17 Thread via GitHub
acassis commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2548969363 @raiden00pl @PetteriAimonen @lupyuen please take a look. I think since now the user will be able to see and enable the Mouse, Touchscreen and Keyboard we need to have the devices or

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-17 Thread via GitHub
acassis commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1888631650 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Comme

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887830816 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Revi

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887830816 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Revi

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-16 Thread via GitHub
terry0012 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887815864 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Com

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-16 Thread via GitHub
terry0012 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887815864 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Com

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-16 Thread via GitHub
acassis commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1886919175 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Comme

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-16 Thread via GitHub
acassis commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1886917555 ## drivers/input/Kconfig: ## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Comme

Re: [PR] Support for the mouse ioctl interface [nuttx]

2024-12-15 Thread via GitHub
nuttxpr commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2544796639 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not meet the NuttX require

[PR] Support for the mouse ioctl interface [nuttx]

2024-12-15 Thread via GitHub
HongChao6 opened a new pull request, #15205: URL: https://github.com/apache/nuttx/pull/15205 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Support for the mouse ioctl interface ## Impact