acassis commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2585246434
> remove #ifdef/#else around the public struct, macro and function from .h is also other option to solve this problem, How do you think? @acassis > > @raiden00pl @PetteriAimonen @lupyuen please take a look. > > I think since now the user will be able to see and enable the Mouse, Touchscreen and Keyboard we need to have the devices organized as a new menu where the user select which Mouse, Touchscreen and/or Keyboard he/she want to use > > How about change all input drivers from 'select' to 'depends on' ? In menu code, how to handle the config DRIVERS_VIRTIO_INPUT, it depends on touch & keyboard & mouse as below: `drivers/virtio/Kconfig:51: depends on INPUT && INPUT_TOUCHSCREEN && INPUT_KEYBOARD && INPUT_MOUSE ` should we put DRIVERS_VIRTIO_INPUT in each menu (touch & keyboard & mouse) ? Yes, this modification will make more sense. A bad thing about "depends on" is because it disappears with the driver from menuconfig. When the drivers are in a fixed subcategory (like Drivers ->Sensors) it is fine, but for INPUT it will be spread around many places, so the user never will know the RPMSG has some KEYBOARD / MOUSE features unless the respective INPUT be enabled first in another place -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
