terry0012 commented on code in PR #15205:
URL: https://github.com/apache/nuttx/pull/15205#discussion_r1916349123


##########
include/nuttx/input/touchscreen.h:
##########
@@ -227,8 +227,6 @@ struct touch_sample_s
 #define SIZEOF_TOUCH_SAMPLE_S(n) \
   (sizeof(struct touch_sample_s) + ((n) - 1) * sizeof(struct touch_point_s))
 
-#ifdef CONFIG_INPUT_TOUCHSCREEN

Review Comment:
   `struct touch_lowerhalf_s` and other functions in `CONFIG_INPUT_TOUCHSCREEN` 
is used by touch lower driver, and rpmsgdev will not use it.
   I think we should keep this config here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to