terry0012 commented on code in PR #15205: URL: https://github.com/apache/nuttx/pull/15205#discussion_r1887954498
########## drivers/input/Kconfig: ########## @@ -65,7 +65,7 @@ endif # FF_AW86225 endif # INPUT_FF config INPUT_MOUSE - bool + bool "Enable mouse support" Review Comment: > or can we remove #ifdef/#else around the public struct, macro and function from .h? LGTM. For mouse.h， just need to remove option "CONFIG_INPUT_MOUSE_WHEEL" to make sure the `struct mouse_report_s` is same as the remote core. In https://github.com/apache/nuttx/pull/8174, it also use this method to fix remote rpmsg device access. ########## include/nuttx/input/touchscreen.h: ########## @@ -227,8 +227,6 @@ struct touch_sample_s #define SIZEOF_TOUCH_SAMPLE_S(n) \ (sizeof(struct touch_sample_s) + ((n) - 1) * sizeof(struct touch_point_s)) -#ifdef CONFIG_INPUT_TOUCHSCREEN Review Comment: `struct touch_lowerhalf_s` and other functions in `CONFIG_INPUT_TOUCHSCREEN` is used by touch driver, and rpmsgdev will not use it. I think we should keep this config here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
