xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082623300
##
fs/vfs/fs_symlink.c:
##
@@ -180,4 +180,30 @@ int symlink(FAR const char *path1, FAR const char *path2)
return ERROR;
}
+/
xiaoxiang781216 opened a new pull request, #8205:
URL: https://github.com/apache/nuttx/pull/8205
## Summary
- Documentation: Remove the supported function from the unsupported list
- libc/pthread: Implement pthread_rwlockattr API
- libc/pthread: Implement pthread_attr_[set|get]s
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082824622
##
arch/xtensa/src/esp32/esp32_touch.c:
##
@@ -51,7 +51,7 @@
#define TOUCH_PAD_FILTER_FACTOR_DEFAULT (4) /* IIR filter coefficient */
#define TOUCH_PAD_SHIFT_DEFAU
lucasssvaz commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082737755
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUNCT
raiden00pl opened a new pull request, #8204:
URL: https://github.com/apache/nuttx/pull/8204
## Summary
drivers/foc: support for BEMF sensing
## Impact
The next step towards BEMF sensing.
Lower-half logic is not yet implemented.
Releted issue: https://github.com/apache/nutt
raiden00pl opened a new pull request, #8203:
URL: https://github.com/apache/nuttx/pull/8203
## Summary
- drivers/foc: add ioctl interface that turn off all PWM switches
- stm32,stm32f7/foc: support for pwm_off()
## Impact
Initial changes to support BEMF sensing when motor is n
xiaoxiang781216 merged PR #1496:
URL: https://github.com/apache/nuttx-apps/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
xiaoxiang781216 commented on PR #8121:
URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1398489955
Here https://en.cppreference.com/w/c/atomic/atomic_load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on code in PR #8196:
URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082636862
##
include/time.h:
##
@@ -64,28 +64,38 @@
* forward and backward as the system time-of-day clock is changed.
*/
-#define CLOCK_REALTIME 0
+#define CLOCK
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082635223
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUN
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082635223
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUN
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082631904
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUN
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398482685
Sorry, I don't see there is anything reason to revert this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082623300
##
fs/vfs/fs_symlink.c:
##
@@ -180,4 +180,30 @@ int symlink(FAR const char *path1, FAR const char *path2)
return ERROR;
}
+/
xiaoxiang781216 merged PR #8183:
URL: https://github.com/apache/nuttx/pull/8183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 merged PR #8194:
URL: https://github.com/apache/nuttx/pull/8194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
lucasssvaz opened a new pull request, #8202:
URL: https://github.com/apache/nuttx/pull/8202
## Summary
Separate from GPIOs and add a handler for RTC interrupts.
Also replaces the RTC watchdog interrupt handler with the new one.
## Impact
None on existing features. Add
acassis commented on code in PR #8194:
URL: https://github.com/apache/nuttx/pull/8194#discussion_r1082431352
##
fs/inode/fs_files.c:
##
@@ -298,7 +301,10 @@ int files_duplist(FAR struct filelist *plist, FAR struct
filelist *clist)
#endif
filep = &plist->fl_files[i
yamt opened a new pull request, #8201:
URL: https://github.com/apache/nuttx/pull/8201
## Summary
* 32-bit time_t should be unsigned because otherwise it wraps too soon. (in
2038)
* 64-bit time_t should be unsigned because it should be consistent within
NuttX.
* While si
pkarashchenko merged PR #8195:
URL: https://github.com/apache/nuttx/pull/8195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
pkarashchenko commented on PR #8183:
URL: https://github.com/apache/nuttx/pull/8183#issuecomment-1398136709
Please rebase this PR to fix the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pkarashchenko commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398125566
Meanwhile I will try to run the test you provided on my end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
pkarashchenko commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398122888
I also can't track a path that leads to pthread exiting while holding
`group->tg_joinlock`. Is it possible to provide some backtrace information so
we can better understand the flow?
pkarashchenko commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398115501
So this PR is more like an attempt to fix some partial case while generic
case is still left broken
--
This is an automated message from the Apache Git Service.
To respond to the me
pkarashchenko commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398110929
@xiaoxiang781216 @yamt so what is the path to move forward here? I read that
this change brings regression to `yaffs2` and the natural step seems to be
reverting of a change and re-ev
pkarashchenko commented on PR #8121:
URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1398105755
@xiaoxiang781216 could you please point me to some good article describing
atomic variables and accessing it? I need to educate myself as I was not
expecting `atomic_load` to be used
pkarashchenko commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082252596
##
libs/libxx/__config_site:
##
@@ -0,0 +1,69 @@
+/
+ * libs/libxx/__config_site
+ *
+ *
pkarashchenko commented on code in PR #8196:
URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082249826
##
include/time.h:
##
@@ -64,28 +64,38 @@
* forward and backward as the system time-of-day clock is changed.
*/
-#define CLOCK_REALTIME 0
+#define CLOCK_R
pkarashchenko commented on code in PR #8198:
URL: https://github.com/apache/nuttx/pull/8198#discussion_r1082244712
##
arch/xtensa/src/esp32s2/esp32s2_efuse_table.c:
##
@@ -0,0 +1,1347 @@
+/
+ * arch/xten
pkarashchenko commented on code in PR #8194:
URL: https://github.com/apache/nuttx/pull/8194#discussion_r1082239504
##
fs/inode/fs_files.c:
##
@@ -298,7 +301,10 @@ int files_duplist(FAR struct filelist *plist, FAR struct
filelist *clist)
#endif
filep = &plist->fl_f
xiaoxiang781216 commented on PR #8194:
URL: https://github.com/apache/nuttx/pull/8194#issuecomment-1398020868
> @xiaoxiang781216 any idea why we still getting this error:
>
> ```
> make[1]: *** [uClibc++.defs:26: uClibc++] Error 6
> make[1]: Target 'context' not remade because of
xiaoxiang781216 merged PR #8198:
URL: https://github.com/apache/nuttx/pull/8198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 merged PR #8199:
URL: https://github.com/apache/nuttx/pull/8199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 merged PR #8200:
URL: https://github.com/apache/nuttx/pull/8200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 commented on code in PR #8196:
URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082182720
##
include/time.h:
##
@@ -64,28 +64,38 @@
* forward and backward as the system time-of-day clock is changed.
*/
-#define CLOCK_REALTIME 0
+#define CLOCK
xiaoxiang781216 commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1398009453
> > Could you give a list of the function not implemented by NuttX yet. I
can take time to implement them.
>
> The complete list of unimplemented functions is:
>
> ```c
g2gps commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1397810269
> Could you give a list of the function not implemented by NuttX yet. I can
take time to implement them.
The complete list of unimplemented functions is:
```c
int at_quick_exit(vo
maxikrie opened a new pull request, #8200:
URL: https://github.com/apache/nuttx/pull/8200
## Summary
This fix is required for using the oneshot driver for cpuload monitoring.
Otherwise an assertion is thrown since nxsched_oneshot_start pass NULL as arg.
## Impact
## Testing
T
acassis opened a new pull request, #8199:
URL: https://github.com/apache/nuttx/pull/8199
## Summary
Add support to efuse
## Impact
User will be able to use efuse
## Testing
esp32-s3-devkit
--
This is an automated message from the Apache Git Service.
To respond to the mes
acassis opened a new pull request, #8198:
URL: https://github.com/apache/nuttx/pull/8198
## Summary
Add support to efuse
## Impact
User will be able to use efuse
## Testing
esp32s2-saola-1
--
This is an automated message from the Apache Git Service.
To respond to the mes
acassis commented on code in PR #8196:
URL: https://github.com/apache/nuttx/pull/8196#discussion_r1081845991
##
include/time.h:
##
@@ -64,28 +64,38 @@
* forward and backward as the system time-of-day clock is changed.
*/
-#define CLOCK_REALTIME 0
+#define CLOCK_REALTIM
acassis commented on PR #8194:
URL: https://github.com/apache/nuttx/pull/8194#issuecomment-1397572188
@xiaoxiang781216 any idea why we still getting this error:
```
make[1]: *** [uClibc++.defs:26: uClibc++] Error 6
make[1]: Target 'context' not remade because of errors.
make: ***
haitomatic closed pull request #8197: Remove loopback check for CANFD driver
Txpoll
URL: https://github.com/apache/nuttx/pull/8197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
haitomatic opened a new pull request, #8197:
URL: https://github.com/apache/nuttx/pull/8197
- Loopback check is not need in txpoll since it's now handled in caller
`devif_poll`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 opened a new pull request, #8196:
URL: https://github.com/apache/nuttx/pull/8196
## Summary
see the spec here:
https://pubs.opengroup.org/onlinepubs/95399/functions/clock_getres.html
## Impact
new macro
## Testing
Pass CI
--
This is
xiaoxiang781216 opened a new pull request, #8195:
URL: https://github.com/apache/nuttx/pull/8195
## Summary
https://man7.org/linux/man-pages/man2/madvise.2.html
## Impact
New macro
## Testing
Pass CI
--
This is an automated message from the Apache Git Ser
xiaoxiang781216 merged PR #8191:
URL: https://github.com/apache/nuttx/pull/8191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
acassis opened a new pull request, #8194:
URL: https://github.com/apache/nuttx/pull/8194
## Summary
Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
## Impact
Avoid crashes
## Testing
esp32-devkit
--
This is an automated message from the Apache Git Service.
gustavonihei merged PR #8177:
URL: https://github.com/apache/nuttx/pull/8177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
gustavonihei commented on PR #8121:
URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1396982709
I honestly feel that adding this flag to this broad scope is too overkill,
even because the occurrence is not even in upstream code. And this is a kind of
warning that shouldn't be ove
jlaitine commented on PR #8191:
URL: https://github.com/apache/nuttx/pull/8191#issuecomment-1396975928
Still removed "Private Functions" and "Public Data" sections from
mpfs_entrypoints.c as they are now empty and not needed.
--
This is an automated message from the Apache Git Service.
To
davids5 commented on PR #8192:
URL: https://github.com/apache/nuttx/pull/8192#issuecomment-1396832917
@zyfeier Can you add some background here explaining why and the value of
the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dnschwa closed pull request #8185: Acknowledge interrupt before installing
callback
URL: https://github.com/apache/nuttx/pull/8185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396798001
Didn't realize this is breaking existing code. Thanks, I will look at your
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
xiaoxiang781216 merged PR #8193:
URL: https://github.com/apache/nuttx/pull/8193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396772931
Didn't realize this is breaking existing code. Thanks, I will look at your
example.
However, might `up_disable_irq(irq);` not work istead? (since it is not
affecting HW state)
--
This
PeterBee97 opened a new pull request, #8193:
URL: https://github.com/apache/nuttx/pull/8193
## Summary
Add documentation for Waveshare RP2040 LCD 1.28
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
zyfeier opened a new pull request, #8192:
URL: https://github.com/apache/nuttx/pull/8192
## Summary
Backtrace CURRENT_REGS when in interrupt context.
## Impact
NA
## Testing
BES2003
--
This is an automated message from the Apache Git Service.
To respond t
davids5 commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396733765
It is service and device dependent. The normal sequence is to enable from
NVIC outward. (Disable in the opposite direction)
1. attach
2. enable NVIC
3. enable device.
4.
jlaitine opened a new pull request, #8191:
URL: https://github.com/apache/nuttx/pull/8191
…rable
Allow bootloader to select run-time whether the payload binary is booted
with SBI or directly by jumping to entrypoint address.
- Use just one bitmask to select sbi or direct boot f
dnschwa commented on PR #8185:
URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396627509
Does it make sense for the callback to service an event that happened
*before* it the callback was installed?
This is not theoretical either, I've encountered this in a real-world case.
xiaoxiang781216 merged PR #8188:
URL: https://github.com/apache/nuttx/pull/8188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396608420
> > > Since iattr and ATTR_xxx isn't defined in nuttx.
> >
> >
> > it's something you should provide as a part of nuttx glue logic, isn't
it?
>
> Sorry, I don't think so. If N
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396600615
> > Since iattr and ATTR_xxx isn't defined in nuttx.
>
> it's something you should provide as a part of nuttx glue logic, isn't it?
>
Sorry, I don't think so. If Nut
anchao closed pull request #8189: arm/tiva: fix Kconfig warning
URL: https://github.com/apache/nuttx/pull/8189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
anchao commented on PR #8189:
URL: https://github.com/apache/nuttx/pull/8189#issuecomment-1396590286
> @anchao it's already fixed by https://github.com/apache/nuttx/pull/8178
Ok, let me close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the me
anchao commented on issue #7475:
URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1396587897
I do not have pico W on hand, just placed an order, I will fix this issue
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jlaitine closed pull request #8190: Fix ci build
URL: https://github.com/apache/nuttx/pull/8190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
jlaitine opened a new pull request, #8190:
URL: https://github.com/apache/nuttx/pull/8190
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396584516
> Since iattr and ATTR_xxx isn't defined in nuttx.
it's something you should provide as a part of nuttx glue logic, isn't it?
anyway, if yaffs2 is broken, i'd suggest to fix it ins
zyfeier commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1396582225
> But I do not see that pholder code modifies sem count value. How is this
different from the case without priority inheritance enabled? And is the same
issue exists in non-SMP case?
xiaoxiang781216 commented on PR #8189:
URL: https://github.com/apache/nuttx/pull/8189#issuecomment-1396578775
@anchao it's already fixed by https://github.com/apache/nuttx/pull/8178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
anchao opened a new pull request, #8189:
URL: https://github.com/apache/nuttx/pull/8189
## Summary
arm/tiva: fix Kconfig warning
```
boards/arm/tiva/tm4c1294-launchpad/Kconfig:90:warning: defaults for choice
values not supported
boards/arm/tiva/tm4c1294-launchpad/Kcon
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396575435
Since iattr and ATTR_xxx isn't defined in nuttx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396572081
> > what's the point of this change?
>
> There is code which redefines DT_(e.g.,
http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0dee9a0b
xiaoxiang781216 commented on PR #8121:
URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1396564883
> @xiaoxiang781216 Could you please share the motivation for disabling this
warning? In which scenario does it manifest?
@gustavonihei here is the warning generated by Candanc
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396559754
> what's the point of this change?
There is code which redefines DT_(e.g.,
http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0de
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396556478
what's the point of this change? are you going to remove DTYPE_xxx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pkarashchenko commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1396543499
But I do not see that pholder code modifies sem count value. How is this
different from the case without priority inheritance enabled?
--
This is an automated message from the Apach
jerpelea merged PR #8187:
URL: https://github.com/apache/nuttx/pull/8187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
jerpelea merged PR #8178:
URL: https://github.com/apache/nuttx/pull/8178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
xiaoxiang781216 commented on PR #8178:
URL: https://github.com/apache/nuttx/pull/8178#issuecomment-1396541453
Can anybody merge this PR? The CI still spew many useless logs now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jerpelea merged PR #1498:
URL: https://github.com/apache/nuttx-apps/pull/1498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
jerpelea merged PR #8186:
URL: https://github.com/apache/nuttx/pull/8186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
pussuw opened a new pull request, #8188:
URL: https://github.com/apache/nuttx/pull/8188
## Summary
When adding more heap memory, the total heap size was not updated. This
results in a crash in mm_mallinfo:
DEBUGASSERT((size_t)info->uordblks + info->fordblks == heap->mm_heapsize);
jlaitine commented on code in PR #8176:
URL: https://github.com/apache/nuttx/pull/8176#discussion_r1080851962
##
mm/mempool/mempool_multiple.c:
##
@@ -220,7 +220,7 @@ mempool_multiple_get_dict(FAR struct mempool_multiple_s
*mpool,
col = index - (row << mpool->dict_col_num_lo
xiaoxiang781216 commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396494107
> For 15.0.0, it seems libcxx moved to using
`__attribute__((using_if_exists))` in order to enable or disable features. See
[this commit on
LLVM](https://github.com/llvm/llvm-proje
g2gps commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080846046
##
libs/libxx/Kconfig:
##
@@ -35,10 +35,11 @@ config LIBCXXMINI
config LIBCXX
bool "LLVM libc++ C++ Standard Library"
+ depends on CXX_STANDARD="c++17" ||
g2gps commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396487086
>
For 15.0.0, it seems libcxx moved to using
`__attribute__((using_if_exists))` in order to enable or disable features. See
[this commit on
LLVM](https://github.com/llvm/llvm-project
xiaoxiang781216 commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396485568
Please reorganize the patch set and remove the intermediate change, @g2gps .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080842496
##
libs/libxx/Kconfig:
##
@@ -35,10 +35,11 @@ config LIBCXXMINI
config LIBCXX
bool "LLVM libc++ C++ Standard Library"
+ depends on CXX_STANDARD="
PeterBee97 commented on issue #7475:
URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1396484817
> @PeterBee97 Do I need to have the "Infineon 43439 firmware file" to get
the WiFi working? There is not documentation about it in the README.tx file
Sorry Alan, I only have t
xiaoxiang781216 commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396479291
BTW, @g2gps do you plan to upgrade libcxx to 15.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396470872
> Would you prefer that I squash the commits into one while applying the
amendments?
It's fine since github provide UI to compare the change between the new
patch and the old
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080830955
##
libs/libxx/0001-libcxx-enable-support-for-c++11.patch:
##
@@ -0,0 +1,49 @@
+diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp
+index 54890b2d797e..1
g2gps commented on PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396468518
Would you prefer that I squash the commits into one while applying the
amendments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
xiaoxiang781216 opened a new pull request, #8187:
URL: https://github.com/apache/nuttx/pull/8187
## Summary
since many 3rd party code use some gnu c++ extension
## Impact
C++ default compiler option
## Testing
Pass CI
--
This is an automated message from
g2gps commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080829205
##
libs/libxx/0001-libcxx-enable-support-for-c++11.patch:
##
@@ -0,0 +1,49 @@
+diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp
+index 54890b2d797e..13bc65dfb30
xiaoxiang781216 opened a new pull request, #1498:
URL: https://github.com/apache/nuttx-apps/pull/1498
## Summary
*.su is generated by gcc/clang when we pass -fstack-usage to them
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080817564
##
libs/libxx/0001-libcxx-enable-support-for-c++11.patch:
##
@@ -0,0 +1,49 @@
+diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp
+index 54890b2d797e..1
1 - 100 of 11508 matches
Mail list logo
