xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1398009453
> > Could you give a list of the function not implemented by NuttX yet. I can take time to implement them. > > The complete list of unimplemented functions is: > > ```c > int at_quick_exit(void (*func)(void)) > void quick_exit(int status); I will implement these functions in the next couple days. > int openat(int dirfd, const char *pathname, int flags); > int unlinkat(int dirfd, const char *pathname, int flags); > ``` @Donny9 will provide an implementation later. > > There is alternate implementation in libcxx for `__remove_all` which removes the need for `openat` and `unlinkat`. This is enabled with `#define REMOVE_ALL_USE_DIRECTORY_ITERATOR`, which I had previously added to `__config_site`. > > For `at_quick_exit` and `quick_exit`, there either needs to be implementations in NuttX, or they are patched out. Like so: > > ```diff > diff --git a/libcxx/include/cstdlib b/libcxx/include/cstdlib > index 457c31f625d8..40ecdfac969d 100644 > --- a/libcxx/include/cstdlib > +++ b/libcxx/include/cstdlib > @@ -132,8 +132,8 @@ using ::wctomb _LIBCPP_USING_IF_EXISTS; > using ::mbstowcs _LIBCPP_USING_IF_EXISTS; > using ::wcstombs _LIBCPP_USING_IF_EXISTS; > #if !defined(_LIBCPP_CXX03_LANG) > -using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; > -using ::quick_exit _LIBCPP_USING_IF_EXISTS; > +// using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; > +// using ::quick_exit _LIBCPP_USING_IF_EXISTS; > #endif > #if _LIBCPP_STD_VER > 14 > using ::aligned_alloc _LIBCPP_USING_IF_EXISTS; > ``` > > If the above is done, cxxlib version `15.0.7` works with c++20, with no further modification. The patch I added previously still needs to be used in order to support c++17, along with any further modification needed to support. could you remove the temporary change from PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
