yamt commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396608420
> > > Since iattr and ATTR_xxx isn't defined in nuttx. > > > > > > it's something you should provide as a part of nuttx glue logic, isn't it? > > Sorry, I don't think so. If NuttX can make the change to more compatible with 3rd party library and without any side effect like this patch. Why not do it? > > > anyway, if yaffs2 is broken, i'd suggest to fix it instead. > > But it can compile without any warning with Linux which define these macros too since the compiler allow the same macro define multiple times if the late definition is same as earlier one. for the most of macros in the file is defined as the following. i don't understand why these need to be different. ``` #ifndef XATTR_REPLACE #define XATTR_REPLACE 2 #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
