jlaitine commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2131598395
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
}
-
jlaitine commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2948240713
@xiaoxiang781216 ,
Could you elaborate a bit why can't this be integrated and further
optimizations / cleanups done on top of this? Does this patchset break
something? For me it i
xiaoxiang781216 commented on issue #16488:
URL: https://github.com/apache/nuttx/issues/16488#issuecomment-2947762653
@xuxin930 we fix this problem recently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiaoxiang781216 commented on PR #16478:
URL: https://github.com/apache/nuttx/pull/16478#issuecomment-2947754417
@jerpelea please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xiaoxiang781216 commented on code in PR #16489:
URL: https://github.com/apache/nuttx/pull/16489#discussion_r2131314375
##
arch/arm/src/stm32f0l0g0/stm32_uid.c:
##
@@ -0,0 +1,65 @@
+/
+ * arch/arm/src/stm
xiaoxiang781216 commented on code in PR #16489:
URL: https://github.com/apache/nuttx/pull/16489#discussion_r2131313080
##
arch/arm/src/stm32f0l0g0/stm32_uid.h:
##
@@ -0,0 +1,52 @@
+/
+ * arch/arm/src/stm
xiaoxiang781216 commented on PR #16483:
URL: https://github.com/apache/nuttx/pull/16483#issuecomment-2947725782
@jlaitine could you bring back your dropped patch again? it's easy to
support the recursive lock after https://github.com/apache/nuttx/pull/16486.
--
This is an automated messag
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 82e17623b1 drivers/segger: Add support for System View post-mortem mode
add 907d77a056 spinlock: add
spin_lock
xiaoxiang781216 merged PR #16486:
URL: https://github.com/apache/nuttx/pull/16486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 67c7a4018a arm64/imx9: Support & configure RGMII-ID on RTL8211F
add 1178b48047 drivers/note: Fix compilation wi
xiaoxiang781216 merged PR #16483:
URL: https://github.com/apache/nuttx/pull/16483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
13022591351 commented on issue #16159:
URL: https://github.com/apache/nuttx/issues/16159#issuecomment-2947329354
I am using the STM32H743 SDMMC1 interface and encountered the same problem
as you. I am now using CONFIG_MM_REGIONS=1 to avoid using SRAM1234. I can use
IDMA normally, but I don'
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 4e83756c0 Publishing web: be40bd5
stbenn commented on issue #16416:
URL: https://github.com/apache/nuttx/issues/16416#issuecomment-2946545060
@raiden00pl Thanks for the suggestion! I have not used any of the TZ
features, and they are all disabled but that doesn't mean they aren't causing
an issue. I briefly looked into them
kywwilson11 opened a new pull request, #16489:
URL: https://github.com/apache/nuttx/pull/16489
*Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
Added a simple driver for obtaining the unique device ID fo
TimJTi commented on issue #16484:
URL: https://github.com/apache/nuttx/issues/16484#issuecomment-2945311562
It is not broken.
1. Size will be zero by design. Maybe an enhancement could change that but
it's of little benefit
2. To run apps from a mounted BINFS:
- ELF format n
TimJTi closed issue #16484: [BUG] Is BINFS broken?
URL: https://github.com/apache/nuttx/issues/16484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: com
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2945176351
> > I am experiencing kernel crashes related to sockets,
sendmsg->psock_sendmsg .
> > This PR solves the issue; is this now good to be merged?
> > @Donny9 , @xiaoxiang781216 ?
>
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2945015695
> I am experiencing kernel crashes related to sockets,
sendmsg->psock_sendmsg .
>
> This PR solves the issue; is this now good to be merged?
>
> @Donny9 , @xiaoxiang7
lljwork2021 opened a new issue, #16488:
URL: https://github.com/apache/nuttx/issues/16488
### Description / Steps to reproduce the issue
~/nuttxspace$ git clone https://github.com/apache/nuttx.git nuttx -b
releases/12.5
~/nuttxspace$ git clone https://github.com/apache/nuttx-ap
jlaitine commented on code in PR #16483:
URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128806190
##
drivers/note/note_driver.c:
##
@@ -611,7 +611,7 @@ void sched_note_add(FAR const void *data, size_t len)
note_add(*driver, note, notelen);
}
-
jasonbu commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128795986
##
include/nuttx/spinlock.h:
##
@@ -499,6 +543,85 @@ irqstate_t spin_lock_irqsave(FAR volatile spinlock_t *lock)
# define spin_lock_irqsave(l) ((void)(l), up_irq_save
jasonbu commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128789186
##
include/nuttx/spinlock.h:
##
@@ -532,6 +570,47 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile
spinlock_t *lock)
return flags;
}
+/
xiaoxiang781216 merged PR #3068:
URL: https://github.com/apache/nuttx-apps/pull/3068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new bcd1b4694 apps/boot/nxboot: Enhancements
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new a03ed4694 ostest/wdog: Remove periodical
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 4b8b96f06 system/uORB: fix orb_subscribe_
xiaoxiang781216 merged PR #3089:
URL: https://github.com/apache/nuttx-apps/pull/3089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
xiaoxiang781216 merged PR #3088:
URL: https://github.com/apache/nuttx-apps/pull/3088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
pussuw commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128563069
##
include/nuttx/spinlock.h:
##
@@ -603,12 +603,17 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile
spinlock_t *lock)
static inline_function
irqstate_t rspin_lo
pussuw commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128565957
##
include/nuttx/spinlock.h:
##
@@ -499,6 +543,85 @@ irqstate_t spin_lock_irqsave(FAR volatile spinlock_t *lock)
# define spin_lock_irqsave(l) ((void)(l), up_irq_save(
pussuw commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128563069
##
include/nuttx/spinlock.h:
##
@@ -603,12 +603,17 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile
spinlock_t *lock)
static inline_function
irqstate_t rspin_lo
pussuw commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128561699
##
include/nuttx/spinlock.h:
##
@@ -532,6 +570,47 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile
spinlock_t *lock)
return flags;
}
+/*
anchao commented on code in PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128541076
##
include/nuttx/spinlock.h:
##
@@ -585,11 +585,11 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile
spinlock_t *lock)
* Similar feature with enter_critical_se
jlaitine commented on code in PR #16485:
URL: https://github.com/apache/nuttx/pull/16485#discussion_r2128427950
##
arch/risc-v/Kconfig:
##
@@ -214,6 +214,8 @@ config ARCH_CHIP_MPFS
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_HAVE_S_MODE
select ARCH_RV_CPUI
jasonbu commented on PR #16486:
URL: https://github.com/apache/nuttx/pull/16486#issuecomment-2943095570
labeler fail should be the network issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
JianyuWang0623 commented on PR #3089:
URL: https://github.com/apache/nuttx-apps/pull/3089#issuecomment-2943087577
@Donny9 @Otpvondoiats @chenzihan0416 Could you review this patch please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
xiaoxiang781216 commented on code in PR #16483:
URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128162918
##
drivers/note/note_driver.c:
##
@@ -611,7 +611,7 @@ void sched_note_add(FAR const void *data, size_t len)
note_add(*driver, note, notelen);
xiaoxiang781216 commented on code in PR #16483:
URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128161421
##
drivers/segger/config/SEGGER_RTT_Conf.h:
##
@@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock;
/* Lock RTT (nestable) (i.e. disable interrupts) */
-
JianyuWang0623 opened a new pull request, #3089:
URL: https://github.com/apache/nuttx-apps/pull/3089
## Summary
Fix `orb_subscribe_multi` undefined error.
```
/workspace/prebuilts/gcc/linux/arm64/bin/../lib/gcc/aarch64-none-elf/13.2.1/../../../../aarch64-none-elf/bin/ld:
apps/s
jlaitine commented on PR #16487:
URL: https://github.com/apache/nuttx/pull/16487#issuecomment-2943057764
Now, if this works I still need to squash the first and third patch;
otherwise there is a non-compiling point in the middle for many targets
preventing e.g. bisecting.
--
This is an a
xiaoxiang781216 commented on PR #16312:
URL: https://github.com/apache/nuttx/pull/16312#issuecomment-2943041915
> Re-requested review just to ask, what should be done with this PR then 😄
Should I refactor it somehow or can we merge it?
@anchao do you have more concern?
--
This is a
jlaitine commented on code in PR #16485:
URL: https://github.com/apache/nuttx/pull/16485#discussion_r2128016198
##
arch/risc-v/Kconfig:
##
@@ -214,6 +214,8 @@ config ARCH_CHIP_MPFS
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_HAVE_S_MODE
select ARCH_RV_CPUI
xiaoxiang781216 commented on code in PR #16485:
URL: https://github.com/apache/nuttx/pull/16485#discussion_r2128127913
##
arch/risc-v/Kconfig:
##
@@ -214,6 +214,8 @@ config ARCH_CHIP_MPFS
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_HAVE_S_MODE
select ARCH_
xiaoxiang781216 commented on code in PR #16485:
URL: https://github.com/apache/nuttx/pull/16485#discussion_r2128126312
##
arch/risc-v/Kconfig:
##
@@ -214,6 +214,8 @@ config ARCH_CHIP_MPFS
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_HAVE_S_MODE
select ARCH_
45 matches
Mail list logo
