jlaitine commented on code in PR #16485:
URL: https://github.com/apache/nuttx/pull/16485#discussion_r2128427950
##########
arch/risc-v/Kconfig:
##########
@@ -214,6 +214,8 @@ config ARCH_CHIP_MPFS
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_HAVE_S_MODE
select ARCH_RV_CPUID_MAP
+ select ARCH_HAVE_PERF_EVENTS
+ select ARCH_PERF_EVENTS
Review Comment:
I hear and understand you, but I don't think what you claim is *strictly*
true. Also the very first example in your link ("For example, the following
code forces CONSOLE to y whenever USB_CONSOLE is y", selects "CONSOLE") selects
a flag with a prompt string.
So it works.
I do agree that in this case there are just the following pitfalls:
- If user turns off the ARCH_PERF_EVENTS in .config, he will create a
configuration which doesn't compile.
- If user tries to define the ARCH_PERF_EVENTS to something else than "y",
it will just fail (if left undefined, it will be selected anyhow in .config, if
set to "n", there will most likely be an error).
It wouldn't get any better if I just defined it to "y" in every defconfig,
it would still be possible to user to turn in off to create a broken
configuration.
Nevertheless, I'll try to fix it in the PR above, cleaning up all the places
for the macros in question..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
