Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
lupyuen merged PR #16167: URL: https://github.com/apache/nuttx/pull/16167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] littlefs_open: sync the file only when O_TRUNC is specified [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #16171: URL: https://github.com/apache/nuttx/pull/16171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] fs/lfs: lfs_file_sync() when littlefs_open [nuttx]

2025-04-09 Thread via GitHub
liamHowatt commented on PR #2913: URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2791608100 For some reason I did not notice that it syncs for all opens, not just O_TRUNC opens. The current code comment made my eyes see a `if (oflags & LFS_O_TRUNC)`, but there isn't. -- This

Re: [PR] littlefs_open: sync the file only when O_TRUNC is specified [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16171: URL: https://github.com/apache/nuttx/pull/16171#issuecomment-2791480017 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] littlefs_open: sync the file only when O_TRUNC is specified [nuttx]

2025-04-09 Thread via GitHub
yamt commented on PR #16171: URL: https://github.com/apache/nuttx/pull/16171#issuecomment-2791482647 @xiaoxiang781216 i don't think this is related to https://github.com/apache/nuttx/issues/15840 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] examples/gps: fix a few printf formats [nuttx-apps]

2025-04-09 Thread via GitHub
yamt opened a new pull request, #3053: URL: https://github.com/apache/nuttx-apps/pull/3053 ## Summary necessary for https://github.com/apache/nuttx/pull/16022 references: https://github.com/kosma/minmea/blob/4abb6f8da5f0fd6b7a7a1064b58e50cbe912043e/minmea.h#L241C15-L241C28 htt

Re: [I] [BUG] Littlefs only syncing with `fsync`, but not `fflush` [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on issue #15840: URL: https://github.com/apache/nuttx/issues/15840#issuecomment-2791620700 from this discussion: https://stackoverflow.com/questions/2340610/difference-between-fflush-and-fsync caller need call fsync after fflush to ensure the change commit to

Re: [I] [BUG] Littlefs only syncing with `fsync`, but not `fflush` [nuttx]

2025-04-09 Thread via GitHub
liamHowatt commented on issue #15840: URL: https://github.com/apache/nuttx/issues/15840#issuecomment-2791576623 In terms of littlefs's syncing semantics, it's well defined that it atomically commits changes only on `lfs_file_close` or `lfs_file_sync`. > file updates are not actually c

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791404352 @anchao please go ahead to close vote with approving, I will merge this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] littlefs_open: sync the file only when O_TRUNC is specified [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #16171: URL: https://github.com/apache/nuttx/pull/16171#issuecomment-2791501585 > @xiaoxiang781216 i don't think this is related to #15840 My mistake, already remove the link. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] arch/risc-v: Implement up_this_task using Thread Pointer (TP) [nuttx]

2025-04-09 Thread via GitHub
no1wudi closed pull request #15563: arch/risc-v: Implement up_this_task using Thread Pointer (TP) URL: https://github.com/apache/nuttx/pull/15563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] arch/xtensa: fix definition for `_int32_t` and `_uint32_t` [nuttx]

2025-04-09 Thread via GitHub
yamt commented on PR #16022: URL: https://github.com/apache/nuttx/pull/16022#issuecomment-2791498002 > @yamt seems we have an issue on `toywasm`. Could you please take a look at the CI build log? is it still failing? -- This is an automated message from the Apache Git Service. To r

[PR] littlefs_open: sync the file only when O_TRUNC is specified [nuttx]

2025-04-09 Thread via GitHub
yamt opened a new pull request, #16171: URL: https://github.com/apache/nuttx/pull/16171 ## Summary Because sync is a rather expensive operation. While I'm here, improve the comment after the recent discussion in https://github.com/apache/nuttx/pull/2913. IMHO, we should

Re: [PR] drivers/rpmsg: correct crc16 catalogue to CRC-16/IBM [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #16166: URL: https://github.com/apache/nuttx/pull/16166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (d240577543 -> 4e1e833b05)

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d240577543 boards/xtensa/esp32s3 Add initial support to Seeed Studio XIAO ESP32S3 add 4e1e833b05 drivers/rpmsg

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791471334 > @xiaoxiang781216: Unfortunately that's what our NuttX Community has agreed on. And it's also consistent with the Apache Way. Perhaps you would like to propose a change to the Nu

(nuttx) branch master updated (b52c122f2c -> d240577543)

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b52c122f2c tools/host_info_dump.py: fix UnboundLocalError: local variable 'vendor_specific_module_path' referenced

Re: [PR] boards/xtensa/esp32s3: Add initial support for Seeed Studio XIAO ESP32S3 [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #16161: URL: https://github.com/apache/nuttx/pull/16161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791401196 > Sorry @xiaoxiang781216: We can't merge this Breaking PR because we have a Blocking Vote: > > * [[BREAKING]libc/elf: rename modlib to libelf #15765 (comment)](https://

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791355149 > Sorry @xiaoxiang781216: We can't merge this Breaking PR because we have a Blocking Vote: > > * [[BREAKING]libc/elf: rename modlib to libelf #15765 (comment)](https://github.com/ap

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791396139 Thanks @anchao! The CI Jobs are still running non-stop, I'll check for errors here: https://gist.github.com/nuttxpr -- This is an automated message from the Apache Git Service. To re

Re: [PR] boards/xtensa/esp32s3: Add initial support for Seeed Studio XIAO ESP32S3 [nuttx]

2025-04-09 Thread via GitHub
rcsim commented on PR #16161: URL: https://github.com/apache/nuttx/pull/16161#issuecomment-2791381736 Hi @acassis , I've fixed the issues. Sorry for that. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
anchao commented on code in PR #16167: URL: https://github.com/apache/nuttx/pull/16167#discussion_r2036368498 ## include/nuttx/compiler.h: ## @@ -563,6 +563,10 @@ #define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +/* Warning about usage of deprecat

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791354052 > @anchao please rebase the patch, so we can merge it after your close the vote with approving. Done -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] sim_i2c: Add setup and shutdown interface [nuttx]

2025-04-09 Thread via GitHub
Zhangshoukui commented on PR #16162: URL: https://github.com/apache/nuttx/pull/16162#issuecomment-2791338989 > please add a commit message to describe the change done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] arch/armv7-a/r: unifying boot flow [nuttx]

2025-04-09 Thread via GitHub
ldube commented on code in PR #15624: URL: https://github.com/apache/nuttx/pull/15624#discussion_r2036363628 ## arch/arm/src/armv7-a/arm.h: ## @@ -111,6 +111,22 @@ extern "C" void arm_data_initialize(void); +/*

(nuttx-website) branch asf-site updated: Publishing web: 405a7126bab3fbbeef1bb95fabd1561c86029fc1 docs: b52c122f2c33d630c799705dea9429d04092bf23

2025-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c29f2efe7 Publishing web: 405a712

Re: [PR] tools/host_info_dump.py: fix UnboundLocalError: local variable 'vendor_specific_module_path' referenced before assignment [nuttx]

2025-04-09 Thread via GitHub
lupyuen merged PR #16169: URL: https://github.com/apache/nuttx/pull/16169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (c9a150781c -> b52c122f2c)

2025-04-09 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository. lupyuen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c9a150781c arch/arm64: remove unrecognized command-line option add b52c122f2c tools/host_info_dump.py: fix Unboun

Re: [PR] arch/xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2791132615 We'll change "Draft Mode" to "Ready For Review" when this has been resolved. Thanks :-) - https://github.com/apache/nuttx/pull/16016#discussion_r2033257641 -- This is an automated me

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2791130597 Sorry @xiaoxiang781216: We can't merge this Breaking PR because we have a Blocking Vote: - https://github.com/apache/nuttx/pull/15765#issuecomment-2788825199 According to the Apa

[I] [HELP] STM32 Standardized Flash Terminology [nuttx]

2025-04-09 Thread via GitHub
stbenn opened a new issue, #16170: URL: https://github.com/apache/nuttx/issues/16170 ### Description I will limit this discussion to STM32 architecture, as I am not familiar with other architectures. I have been working on a progmem flash driver for the STM32H5, and noticed i

Re: [I] [FEATURE] Common ioctl API for Contactless (NFC&RFID) cards and readers [nuttx]

2025-04-09 Thread via GitHub
keever50 commented on issue #16036: URL: https://github.com/apache/nuttx/issues/16036#issuecomment-2790834605 I've realized that modern NFC reader ICs use firmwares with the _NFC forum NCI interface_. To get the specification for this NCI interface, you get hit by a **2000 dollar** paywall.

Re: [PR] arch/xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-04-09 Thread via GitHub
tmedicci commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2790820598 This is still on WIP status (please check https://github.com/apache/nuttx/pull/16016#discussion_r2033257641). -- This is an automated message from the Apache Git Service. To respond to

(nuttx) annotated tag nuttx-12.9.0-RC0 updated (47cdb6a283 -> a849ab26bf)

2025-04-09 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-12.9.0-RC0 in repository https://gitbox.apache.org/repos/asf/nuttx.git *** WARNING: tag nuttx-12.9.0-RC0 was modified! *** from 47cdb6a283 (commit) to a849ab26bf (tag)

Re: [PR] boards/arm: add nucleo-c092rc support [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16168: URL: https://github.com/apache/nuttx/pull/16168#issuecomment-2789738467 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not adequately meet the Nu

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2790060853 @anchao please rebase the patch, so we can merge it after your close the vote with approving. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] tools/host_sysinfo.py: fix UnboundLocalError: local variable 'vendor_specific_module_path' referenced before assignment [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16169: URL: https://github.com/apache/nuttx/pull/16169#issuecomment-2790329585 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #16154: URL: https://github.com/apache/nuttx/pull/16154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #16167: URL: https://github.com/apache/nuttx/pull/16167#discussion_r2035571724 ## include/nuttx/compiler.h: ## @@ -563,6 +563,10 @@ #define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +/* Warning about usage of

[PR] tools/host_sysinfo.py: fix UnboundLocalError: local variable 'vendor_specific_module_path' referenced before assignment [nuttx]

2025-04-09 Thread via GitHub
simbit18 opened a new pull request, #16169: URL: https://github.com/apache/nuttx/pull/16169 ## Summary fix ``` Traceback (most recent call last): File "/home/ubuntu20042/nuttxspace/nuttx/tools/host_info_dump.py", line 575, in header = generate_header(args)

Re: [PR] kernel build:avoid multiple definition ld script [nuttx-apps]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #3052: URL: https://github.com/apache/nuttx-apps/pull/3052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] boards/arm: add nucleo-c092rc support [nuttx]

2025-04-09 Thread via GitHub
acassis commented on code in PR #16168: URL: https://github.com/apache/nuttx/pull/16168#discussion_r2035491270 ## Documentation/platforms/arm/stm32c0/boards/nucleo-c092rc/index.rst: ## @@ -0,0 +1,37 @@ + +ST Nucleo C092RC + + +The Nucleo C092RC is

(nuttx) 02/04: binfmt:use crt0 inside of starthook

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 422c43949a95845712b31ea8f1260e2f964aa5cf Author: anjiahao AuthorDate: Mon Feb 10 17:53:46 2025 +0800 binfmt:use c

(nuttx) 04/04: arch/arm64: remove unrecognized command-line option

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit c9a150781c02b14f3a351daef2ae6920d8fcf897 Author: anjiahao AuthorDate: Wed Feb 12 11:58:11 2025 +0800 arch/arm64:

(nuttx) 01/04: armv7a:need initialize constructor and destructor on crt0

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 297a1cb1fed795257374d5ee7383d628a71112fc Author: anjiahao AuthorDate: Thu Feb 6 16:21:34 2025 +0800 armv7a:need i

(nuttx) 03/04: arm:elf module need long call aviod jump addr over length

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3411e5c6db95f645c88a110fe2b2e8bf4124fdc5 Author: anjiahao AuthorDate: Mon Feb 10 11:44:40 2025 +0800 arm:elf modu

(nuttx) branch master updated (ac2078a8bf -> c9a150781c)

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ac2078a8bf fs/procfs: fix potential null pointer access in procfs_opendir new 297a1cb1fe armv7a:need initializ

Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
acassis commented on code in PR #16167: URL: https://github.com/apache/nuttx/pull/16167#discussion_r2035541164 ## include/nuttx/compiler.h: ## @@ -563,6 +563,10 @@ #define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +/* Warning about usage of depreca

Re: [PR] boards/xtensa/esp32s3: Add initial support for Seeed Studio XIAO ESP32S3 [nuttx]

2025-04-09 Thread via GitHub
acassis commented on PR #16161: URL: https://github.com/apache/nuttx/pull/16161#issuecomment-2790011674 @rcsim please verify these errors: misc/assert.c: In function 'reset_board': Error: misc/assert.c:807:24: error: 'LED_PANIC' undeclared (first use in this function) 807 |

Re: [PR] fs/procfs: fix potential null pointer access in procfs_opendir [nuttx]

2025-04-09 Thread via GitHub
acassis merged PR #16164: URL: https://github.com/apache/nuttx/pull/16164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
acassis commented on code in PR #16167: URL: https://github.com/apache/nuttx/pull/16167#discussion_r2035543009 ## include/nuttx/compiler.h: ## @@ -563,6 +563,10 @@ #define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +/* Warning about usage of depreca

Re: [PR] boards/arm: add nucleo-c092rc support [nuttx]

2025-04-09 Thread via GitHub
acassis commented on code in PR #16168: URL: https://github.com/apache/nuttx/pull/16168#discussion_r2035526460 ## Documentation/platforms/arm/stm32c0/boards/nucleo-c092rc/index.rst: ## @@ -0,0 +1,37 @@ + +ST Nucleo C092RC + + +The Nucleo C092RC is

Re: [PR] boards/arm: add nucleo-c092rc support [nuttx]

2025-04-09 Thread via GitHub
acassis commented on code in PR #16168: URL: https://github.com/apache/nuttx/pull/16168#discussion_r2035491270 ## Documentation/platforms/arm/stm32c0/boards/nucleo-c092rc/index.rst: ## @@ -0,0 +1,37 @@ + +ST Nucleo C092RC + + +The Nucleo C092RC is

Re: [PR] libs/libc/crc16: Separate implementation of crc16xmodem from crc16 [nuttx]

2025-04-09 Thread via GitHub
simbit18 commented on PR #16147: URL: https://github.com/apache/nuttx/pull/16147#issuecomment-2789780561 Hi @anchao I think it is also necessary to update the Cmakefile ``` FAILED: nuttx : && /tools/ccache/bin/arm-none-eabi-g++ --specs=nosys.specs -Wl,--print-memory-usag

[PR] boards/arm: add nucleo-c092rc support [nuttx]

2025-04-09 Thread via GitHub
raiden00pl opened a new pull request, #16168: URL: https://github.com/apache/nuttx/pull/16168 ## Summary add nucleo-c092rc support ## Impact new board supported ## Testing tested with included jumbo configuration -- This is an automated message from the A

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
pussuw commented on code in PR #16165: URL: https://github.com/apache/nuttx/pull/16165#discussion_r2035125770 ## include/nuttx/spinlock_type.h: ## @@ -50,10 +50,20 @@ typedef atomic_t rwlock_t; #endif #ifndef CONFIG_SPINLOCK -# define SP_UNLOCKED 0 /* The Un-locked state *

Re: [PR] [BREAKING]libs/libc/crc16: set default crc16 catalogue from CRC-16/XMODEM to CRC-16/IBM [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #16147: URL: https://github.com/apache/nuttx/pull/16147#issuecomment-2789244371 > We'll change "Draft Mode" to "Ready For Review" after the voting ends in 72 hours. Thanks :-) @lupyuen Sorry for bother you again. I will keep the default crc16 algorithm at crc16

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2788856139 > Hi @anchao: The voting will close in 24 hours and we have (I think) [One Blocking Vote](https://lists.apache.org/thread/v7d7k1n2d1tl8n6o3pnocbz33knx3gmp). > > Perhaps you could cl

(nuttx) branch master updated: libc/semaphore: Read semaphore value by using NXSEM_COUNT macro

2025-04-09 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository. lupyuen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 84cb21791f libc/semaphore: Read semaphore value

(nuttx) branch master updated: boards/stm32f0l0g0: unify liker scripts

2025-04-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0de4bd7938 boards/stm32f0l0g0: unify liker scr

Re: [PR] boards/stm32f0l0g0: unify liker scripts [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 merged PR #16163: URL: https://github.com/apache/nuttx/pull/16163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #16167: URL: https://github.com/apache/nuttx/pull/16167#discussion_r2035223009 ## include/nuttx/compiler.h: ## @@ -563,6 +563,10 @@ #define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +/* Warning about usage of

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on PR #16165: URL: https://github.com/apache/nuttx/pull/16165#issuecomment-2789375523 > The change is not compatible with ANSI C89, support for 0-sized arrays is a GCC extension. Abandoning change. can we add an option in compiler.h to turn on this feature op

Re: [PR] drivers/rpmsg: correct crc16 catalogue to CRC-16/IBM [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16166: URL: https://github.com/apache/nuttx/pull/16166#issuecomment-2789296099 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
pussuw commented on PR #16165: URL: https://github.com/apache/nuttx/pull/16165#issuecomment-2789352934 The change is not compatible with ISO C89, support for 0-sized arrays is a GCC extension. Abandoning change. -- This is an automated message from the Apache Git Service. To respond to th

[PR] nuttx/compiler: add support of deprecated attribute [nuttx]

2025-04-09 Thread via GitHub
anchao opened a new pull request, #16167: URL: https://github.com/apache/nuttx/pull/16167 ## Summary nuttx/compiler: add support of deprecated attribute Warning about usage of deprecated features. since __deprecated__ is a compiler built-in macro, so we define the deprec

[PR] drivers/rpmsg: correct crc16 catalogue to CRC-16/IBM [nuttx]

2025-04-09 Thread via GitHub
anchao opened a new pull request, #16166: URL: https://github.com/apache/nuttx/pull/16166 ## Summary drivers/rpmsg: correct crc16 catalogue to CRC-16/IBM This is the pair implementation relative to the Linux kernel Signed-off-by: chao an ## Impact N/A

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2788877457 I don't really care whether this PR can be merged or not. It has no impact on me. It was only when a student asked me what modlib's capabilities were that I realized it needed to be rename

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #16165: URL: https://github.com/apache/nuttx/pull/16165#discussion_r2035074611 ## include/nuttx/spinlock_type.h: ## @@ -50,10 +50,20 @@ typedef atomic_t rwlock_t; #endif #ifndef CONFIG_SPINLOCK -# define SP_UNLOCKED 0 /* The Un-locke

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #16165: URL: https://github.com/apache/nuttx/pull/16165#discussion_r2035074611 ## include/nuttx/spinlock_type.h: ## @@ -50,10 +50,20 @@ typedef atomic_t rwlock_t; #endif #ifndef CONFIG_SPINLOCK -# define SP_UNLOCKED 0 /* The Un-locke

Re: [PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16165: URL: https://github.com/apache/nuttx/pull/16165#issuecomment-2789189784 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] nuttx/spinlock: Define spinlock_t as size 0 if spinlocks are not used [nuttx]

2025-04-09 Thread via GitHub
pussuw opened a new pull request, #16165: URL: https://github.com/apache/nuttx/pull/16165 ## Summary Saves 1 byte per spinlock, if spinlocks are not used. ## Impact Reduce RAM usage by 1 byte per defined spinlock, if CONFIG_SPINLOCK=n. ## Testing rv-virt:nsh

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2789019263 > @anchao Is there a tiny possibility that we misread this? Because I see that we have support for the Breaking PR: https://lists.apache.org/thread/v7d7k1n2d1tl8n6o3pnocbz33knx3gmp >

Re: [PR] boards/stm32f0l0g0: unify liker scripts [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16163: URL: https://github.com/apache/nuttx/pull/16163#issuecomment-2789005943 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR summary does not fully meet the NuttX requi

[PR] fs/procfs: fix potential null pointer access in procfs_opendir [nuttx]

2025-04-09 Thread via GitHub
bkueng opened a new pull request, #16164: URL: https://github.com/apache/nuttx/pull/16164 Some entries have the opendir function set to NULL, for example g_mount_operations. A null pointer dereference can be triggered by an opendir("/proc/fs/blocks") for example. ## Testing

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2788951337 @anchao Is there a tiny possibility that we misread this? Because I see that we have support for the Breaking PR: https://lists.apache.org/thread/v7d7k1n2d1tl8n6o3pnocbz33knx3gmp > i

Re: [PR] [BREAKING]libc/elf: rename modlib to libelf [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2788825199 Hi @anchao: The voting will close in 24 hours and we have (I think) [One Blocking Vote](https://lists.apache.org/thread/v7d7k1n2d1tl8n6o3pnocbz33knx3gmp). Perhaps you could clarify

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
pussuw commented on code in PR #16154: URL: https://github.com/apache/nuttx/pull/16154#discussion_r2034746453 ## arch/risc-v/src/Makefile: ## @@ -144,7 +144,7 @@ $(COBJS) $(UCOBJS): %$(OBJEXT): %.c $(call COMPILE, $<, $@) crt0$(OBJEXT): %$(OBJEXT): %.c - $(call

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
pussuw commented on code in PR #16154: URL: https://github.com/apache/nuttx/pull/16154#discussion_r2034651706 ## arch/arm64/src/Toolchain.defs: ## @@ -247,5 +247,11 @@ LDMODULEFLAGS = -r -T $(call CONVERT_PATH,$(TOPDIR)/libs/libc/modlib/gnu-elf.ld) CELFFLAGS = $(CFLAGS) -fvisi

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
lupyuen commented on PR #16154: URL: https://github.com/apache/nuttx/pull/16154#issuecomment-2788598946 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16154: URL: https://github.com/apache/nuttx/pull/16154#issuecomment-2788616155 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (milkv_duos:nsh) https://gitlab.co

Re: [PR] Delete the start hook implementation and use crt0 instead. The module will initialize itself in crt0. [nuttx]

2025-04-09 Thread via GitHub
nuttxpr commented on PR #16154: URL: https://github.com/apache/nuttx/pull/16154#issuecomment-2788598680 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (avaota-a1:nsh) https://gitlab.com