ldube commented on code in PR #15624:
URL: https://github.com/apache/nuttx/pull/15624#discussion_r2036363628
##########
arch/arm/src/armv7-a/arm.h:
##########
@@ -111,6 +111,22 @@ extern "C"
void arm_data_initialize(void);
+/****************************************************************************
+ * Name: arm_smp_busy_wait_fini
+ *
+ * Description:
+ * Clearing armv7a SMP busy wait flag set in arm_head.S
+ *
+ ****************************************************************************/
+
+static inline void arm_smp_busy_wait_fini(void)
+{
+#ifdef CONFIG_ARMV7A_SMP_BUSY_WAIT
+ *(uint32_t *)CONFIG_ARMV7A_SMP_BUSY_WAIT_FLAG_ADDR = 1;
+ up_flush_dcache((uintptr_t)address, (uintptr_t)address + sizeof(uint32_t));
Review Comment:
Please use the DSB barrier just like the original assembly code.
UP_DSB();
The flag should be in coherent memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
