Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1944256977
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xtensa/sr
XuNeo commented on PR #15743:
URL: https://github.com/apache/nuttx/pull/15743#issuecomment-2638916043
Hi @jerpelea ,
Please help to review the PR again. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cuiziweizw opened a new pull request, #15774:
URL: https://github.com/apache/nuttx/pull/15774
## Summary
1. fix https://github.com/apache/nuttx/issues/14774.
Change the defconfig of libcxxtest and select libcxxabi by default.
2. fix https://github.com/apache/nuttx/issues/15491.
wangzhi-art commented on code in PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#discussion_r1944039255
##
arch/x86_64/src/intel64/intel64_oneshot.c:
##
@@ -29,6 +29,7 @@
#include
#include
#include
+#include
Review Comment:
This was modified in PR #15665, w
wangzhi-art commented on code in PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#discussion_r1944039255
##
arch/x86_64/src/intel64/intel64_oneshot.c:
##
@@ -29,6 +29,7 @@
#include
#include
#include
+#include
Review Comment:
This was modified in PR#15665, wh
wangzhi-art commented on code in PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#discussion_r1944039411
##
arch/sim/src/sim/sim_usbdev.c:
##
@@ -39,7 +39,6 @@
#include
#include
-#include
Review Comment:
Done.
##
arch/arm/src/armv6-m/arm_ramvec_at
wangzhi-art commented on code in PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#discussion_r1944039255
##
arch/x86_64/src/intel64/intel64_oneshot.c:
##
@@ -29,6 +29,7 @@
#include
#include
#include
+#include
Review Comment:
Done.
##
arch/tricore/
yamt commented on issue #15755:
URL: https://github.com/apache/nuttx/issues/15755#issuecomment-2638736164
> So, I think we should change it on NuttX and provide a compiler's version
check.
yes, it makes sense.
--
This is an automated message from the Apache Git Service.
To respond
cederom opened a new issue, #15773:
URL: https://github.com/apache/nuttx/issues/15773
### Description
* In order to provide generic approach and universal architecture we need to
define a standard set of test cases.
* There are two main categories of tests: Build and Runtime.
*
cederom commented on PR #15748:
URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2638682027
Thank you @zouboan and @anchao !! After long discussions on the mailing
lists the conclusion is to take time and extra caution with critical kernel /
architecture changes, as they impact
xiaoxiang781216 commented on code in PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#discussion_r1943962377
##
arch/arm/src/armv6-m/arm_ramvec_attach.c:
##
@@ -31,18 +31,11 @@
#include
#include
-#include
#include "ram_vectors.h"
#ifdef CONFIG_ARCH_RAMVECT
xiaoxiang781216 commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2638553547
> I will test it on our internal CI. Please do not merge it yet.
>
> (considering the discussion on the developer's mailing list, that is the
approach I support: reverting i
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 0ae633cc08 clock/clock_adjtime.c: fix compile
xiaoxiang781216 merged PR #15768:
URL: https://github.com/apache/nuttx/pull/15768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
yf13 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1943856795
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7-r/arm_powe
tmedicci commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2637822478
I will test it on our internal CI. Please do not merge it yet.
(considering the discussion on the developer's mailing list, that is the
approach I support: reverting it and then co
nuttxpr commented on PR #15771:
URL: https://github.com/apache/nuttx/pull/15771#issuecomment-2637693206
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the basic NuttX requiremen
nuttxpr commented on PR #15772:
URL: https://github.com/apache/nuttx/pull/15772#issuecomment-2637690519
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR appears to mostly meet the NuttX requirements,
tmedicci opened a new pull request, #15772:
URL: https://github.com/apache/nuttx/pull/15772
## Summary
* libc/wcsrtombs: Fix the wcsrtombs() according to the POSIX standard
According to https://pubs.opengroup.org/onlinepubs/9799919799/, the expected
behavior for the `wcstombs()
kywwilson11 opened a new pull request, #15771:
URL: https://github.com/apache/nuttx/pull/15771
## Summary
Added documentation for STM32H5 Architecture and Nucleo-H563ZI board.
There is support for a handful of peripherals right now. Adding
documentation will hopefully encourag
tmedicci opened a new pull request, #2986:
URL: https://github.com/apache/nuttx-apps/pull/2986
## Summary
* testing/libc/wcstombs: Add testing application for wcstombs
This application tests the libc's `wcstombs` function for different len
sizes (bigger than the converted strin
fdcavalcanti commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1942969310
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xte
tmedicci commented on issue #15755:
URL: https://github.com/apache/nuttx/issues/15755#issuecomment-2637412461
> > [@yamt](https://github.com/yamt) , do you recall how did you test the
compiler's definition (as stated by
[c18f074](https://github.com/apache/nuttx/commit/c18f0748303a236cc2b559
digiexchris opened a new issue, #15770:
URL: https://github.com/apache/nuttx/issues/15770
### Is your feature request related to a problem? Please describe.
I have a cmake project that is using nuttx as a library (make export). It
would be more convenient for me if I could do out of t
linguini1 commented on issue #15760:
URL: https://github.com/apache/nuttx/issues/15760#issuecomment-2637382773
Latest master branch resolves this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
linguini1 closed issue #15760: [BUG] RP2040 SMP configurations broken
URL: https://github.com/apache/nuttx/issues/15760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
jlaitine commented on PR #15753:
URL: https://github.com/apache/nuttx/pull/15753#issuecomment-2637347248
> please move documentation to a separate PR
Hm? This PR was previously rejected because documentation of the "hwtest"
defconfig (which I didn't even author originally) was missing
zouboan opened a new pull request, #15769:
URL: https://github.com/apache/nuttx/pull/15769
## Summary
This PR improve the ethernet drivers to makes the net of zynq-mpsoc fully
operational and enhances the convenience of using ZCU111, The main changes are
as follows:
1. Changes the
michallenc opened a new pull request, #15768:
URL: https://github.com/apache/nuttx/pull/15768
## Summary
The missing `` header caused following compile errors:
```
CC: clock/clock_adjtime.c clock/clock_adjtime.c: In function
'adjtime_wdog_callback': clock/clock_adjtime.c:67:11:
anchao commented on PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636886928
> > > > Most of the commits are valuable. I just have some suggestions
regarding the naming of the APIs.
> > >
> > >
> > > single core doesn't have any benefit to use spinlock. i
fdcavalcanti commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1942969310
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xte
xiaoxiang781216 commented on PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636712967
> > > Most of the commits are valuable. I just have some suggestions
regarding the naming of the APIs.
> >
> >
> > single core doesn't have any benefit to use spinlock.
xiaoxiang781216 commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636649454
> > > > > How about use separate config to keep both? I know recent events
but this is not reason we should stop developing optimization / new features.
> > > > > One suggestion
anchao commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636607592
> > > > How about use separate config to keep both? I know recent events but
this is not reason we should stop developing optimization / new features.
> > > > One suggestion is we can ke
xiaoxiang781216 commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636579527
> > > How about use separate config to keep both? I know recent events but
this is not reason we should stop developing optimization / new features.
> > > One suggestion is we c
jerpelea commented on PR #15753:
URL: https://github.com/apache/nuttx/pull/15753#issuecomment-2636571790
please move documentation to a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
anchao commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636569233
> > How about use separate config to keep both? I know recent events but
this is not reason we should stop developing optimization / new features.
> > One suggestion is we can keep both
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from ca92c208c1 arch/arm64: generate error if context size is not aligned
to 16bytes
add b90638493a pynuttx: fix meml
acassis merged PR #15745:
URL: https://github.com/apache/nuttx/pull/15745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
acassis commented on issue #11390:
URL: https://github.com/apache/nuttx/issues/11390#issuecomment-2636565436
I think it should be nice to have support to original "minnsh" where almost
everything were disabled, even signals, VFS, etc
--
This is an automated message from the Apache Git Ser
xiaoxiang781216 commented on PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636509745
> Most of the commits are valuable. I just have some suggestions regarding
the naming of the APIs.
single core doesn't have any benefit to use spinlock.
--
This is an aut
hujun260 commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636531527
> How about use separate config to keep both? I know recent events but this
is not reason we should stop developing optimization / new features.
>
> One suggestion is we can keep b
anchao commented on PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636516859
> > Most of the commits are valuable. I just have some suggestions regarding
the naming of the APIs.
>
> single core doesn't have any benefit to use spinlock. it's also dangerous
to
TaiJuWu commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636514781
How about use separate config to keep both?
I know recent events but this is not reason we should stop developing
optimization / new features.
One suggestion is we can keep both
xiaoxiang781216 commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636521603
> How about use separate config to keep both? I know recent events but this
is not reason we should stop developing optimization / new features.
>
> One suggestion is we can
fdcavalcanti commented on PR #15749:
URL: https://github.com/apache/nuttx/pull/15749#issuecomment-2636493962
@acassis Do you have something else to suggest changes? If not please remove
the change request from the PR 😃
--
This is an automated message from the Apache Git Service.
To respo
yf13 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942619233
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7-r/arm_powe
anchao merged PR #15758:
URL: https://github.com/apache/nuttx/pull/15758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2636477188
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ca92c208c1 arch/arm64: generate error if context
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636459231
> > Cool lemme know when we're ready to retest, I'll run my script again.
Thanks :-)
>
> It seems that qemu 8.2.2 cannot execute rv-virt/knsh64 not caused by my
PR. If your test env
anchao commented on PR #15766:
URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636434572
Most of the commits are valuable. I just have some suggestions regarding the
naming of the APIs.
--
This is an automated message from the Apache Git Service.
To respond to the messag
anchao commented on PR #15767:
URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636431979
Why do you want to revert? Most of the commits are valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
anchao commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942667921
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,61 @@
+/***
+ * arch/arm/src/armv7-r/arm_po
anchao commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942662048
##
libs/libc/libelf/libelf.h:
##
@@ -1,5 +1,5 @@
/
- * libs/libc/modlib/modlib.h
+ * libs/li
anchao commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942661759
##
Documentation/applications/examples/module/index.rst:
##
@@ -55,8 +55,8 @@ configuration options:
6. Linker scripts. You might also want to use a linker scripts to
xiaoxiang781216 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942643207
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7
Jasinsky commented on PR #15761:
URL: https://github.com/apache/nuttx/pull/15761#issuecomment-2636215021
Minor -
Remove:
Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).
from PR description
--
This is an automated mes
hujun260 closed pull request #15695: replace spin_lock_irqrestore with
raw_spin_lock_irqrestore
URL: https://github.com/apache/nuttx/pull/15695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
yf13 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942619233
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7-r/arm_powe
hujun260 opened a new pull request, #15767:
URL: https://github.com/apache/nuttx/pull/15767
## Summary
Revert some changes to restore the original semantics of spin_lock_irqsave.
## Impact
spinlock
## Testing
ci
--
This is an automated message from th
yf13 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942619233
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7-r/arm_powe
wangzhi-art opened a new pull request, #15766:
URL: https://github.com/apache/nuttx/pull/15766
*Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
Revert patch related to "enter_critical_section -> spin_loc
xiaoxiang781216 commented on code in PR #15757:
URL: https://github.com/apache/nuttx/pull/15757#discussion_r1942589834
##
include/nuttx/net/mii.h:
##
@@ -396,6 +396,13 @@
#define DP83840_PHYADDR_DUPLEX (1 << 7)
#define DP83840_PHYADDR_SPEED(1 << 6)
+/* Davicom
xiaoxiang781216 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942585329
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,71 @@
+/***
+ * arch/arm/src/armv7
lupyuen commented on issue #14774:
URL: https://github.com/apache/nuttx/issues/14774#issuecomment-2636225688
@xiaoxiang781216 MSVC is already in, see below. Sorry we can't enable macOS,
it will exceed our budget. Remember that 1 macOS Runner = 10 times the cost of
a Linux Runner.
htt
xiaoxiang781216 commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942578268
##
libs/libc/libelf/libelf.h:
##
@@ -1,5 +1,5 @@
/
- * libs/libc/modlib/modlib.h
+
xiaoxiang781216 commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942576398
##
Documentation/platforms/arm/samv7/boards/samv71-xult/README.txt:
##
@@ -1819,10 +1819,10 @@ Configuration sub-directories
CONFIG_FS_ROMFS=y
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636251257
> Cool lemme know when we're ready to retest, I'll run my script again.
Thanks :-)
It seems that qemu 8.2.2 cannot execute rv-virt/knsh64 not caused by my PR.
If your test environme
xiaoxiang781216 commented on issue #14774:
URL: https://github.com/apache/nuttx/issues/14774#issuecomment-2636242119
so, we don't have any ci on macOS now:(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
lupyuen commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636242496
Cool lemme know when we're ready to retest, I'll run my script again. Thanks
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636236723
> @lupyuen Thank you, I updated my modification and changed elf to libelf,
so that rv-virt:knsh64 can be compiled successfully, but I found a new issue,
rv-virt:knsh64 cannot be starte
xiaoxiang781216 commented on issue #14774:
URL: https://github.com/apache/nuttx/issues/14774#issuecomment-2636210985
@lupyuen do we have enough budget to bring back msvc and all macOS to ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
raiden00pl commented on PR #15753:
URL: https://github.com/apache/nuttx/pull/15753#issuecomment-2636219589
> OT: Although LTS is a good idea in general, I don't understand where the
resources for maintaining and testing those will come in this project - it will
be huge work. But I keep my f
Jasinsky commented on PR #15759:
URL: https://github.com/apache/nuttx/pull/15759#issuecomment-2636210282
Minor - remove
```
Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).
```
in PR description
--
This is an autom
xiaoxiang781216 commented on issue #14774:
URL: https://github.com/apache/nuttx/issues/14774#issuecomment-2636203703
>
https://github.com/apache/nuttx/blob/3e3701b2721c216cea47b72835a13966da52b555/libs/libxx/libcxxabi/Make.defs
libcxxabi/Make.defs has already add include search path at line
yf13 commented on PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#issuecomment-2636126815
@anchao the first two points have been updated as per your notes. I am
unsure if you really want the 3rd one.
--
This is an automated message from the Apache Git Service.
To respond to the
nuttxpr commented on PR #88:
URL: https://github.com/apache/nuttx/pull/88#issuecomment-2636105579
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
TODO: response_text
--
This is an automated message from the Apach
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636121996
> Sorry @anchao I tested the new branch `anchao:25020501` for NuttX and
Apps, it fails to build for rv-virt:knsh64. Did I miss something? Thanks :-)
https://gist.github.com/lupyuen/58c3b95
wangzhi-art closed pull request #15764: Use small lock to protect resources
related to tickless.
URL: https://github.com/apache/nuttx/pull/15764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
xiaoxiang781216 commented on issue #11390:
URL: https://github.com/apache/nuttx/issues/11390#issuecomment-2636094858
But I think it's different thing, the user could unselect DISABLE_SIGNALS to
keep the compliant at any time.
We even have option to disable
timer/pthread/mqueu(https://git
raiden00pl commented on issue #11390:
URL: https://github.com/apache/nuttx/issues/11390#issuecomment-2636044972
it's useful to disable signals, but it's against POSIX, event PSE51 requires
signals. Maybe if we could help the compiler optimize unused signal logic, but
I don't know if that's
xiaoxiang781216 commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636025659
> Sorry @anchao I tested the new branch `anchao:25020501` for NuttX and
Apps, it fails to build for rv-virt:knsh64. Did I miss something? Thanks :-)
https://gist.github.com/lupyue
yf13 commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942422686
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,61 @@
+/***
+ * arch/arm/src/armv7-r/arm_powe
lupyuen commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636029832
@xiaoxiang781216 There's no Build Bot yet. It's a Manual Bot :-) Lemme know
when the PR is ready, perhaps we should set the PR to Draft Mode?
--
This is an automated message from the Ap
anchao commented on code in PR #15762:
URL: https://github.com/apache/nuttx/pull/15762#discussion_r1942413975
##
arch/arm/src/armv7-r/arm_poweroff.c:
##
@@ -0,0 +1,61 @@
+/***
+ * arch/arm/src/armv7-r/arm_po
86 matches
Mail list logo
