anchao commented on PR #15767: URL: https://github.com/apache/nuttx/pull/15767#issuecomment-2636607592
> > > > How about use separate config to keep both? I know recent events but this is not reason we should stop developing optimization / new features. > > > > One suggestion is we can keep both by config and mark new feature as experiment until it fully test and remove old config until next major release like other projects. > > > > > > > > > Under the original semantics, new interfaces will continue to be added, and optimizations will continue. > > > > > > So, no need to revert, right? could we close this PR? > > No, the patch restore to the point which keep spinlock_irqsave as before, but the optimization still keep, so it's required. But this should not be reverted, but further optimized, My previous PR has been doing something similar. The revert submission is just to expose the changes to sched_lock so that it can be accurately replaced with the new API. If you think my changes are not good, I can close them and you guys submit them. https://github.com/apache/nuttx/pull/15705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
