anchao commented on PR #15766: URL: https://github.com/apache/nuttx/pull/15766#issuecomment-2636516859
> > Most of the commits are valuable. I just have some suggestions regarding the naming of the APIs. > > single core doesn't have any benefit to use spinlock. it's also dangerous to replace enter_critical_section with spin_lock_irqsave. In AMP mode it depends on whether CONFIG_SPINLOCK is enabled. In the previous code implementation, only interrupts are disabled. 1. spin_lock() not enabled if CONFIG_SPINLOCK is disabled. 2. spin_lock_irqsave() equal irq_save() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
