Re: [I] [BUG] `CONFIG_DEBUG_UORB` should enable `CONFIG_LIBC_FLOATINGPOINT` [nuttx]

2025-01-21 Thread via GitHub
raiden00pl commented on issue #15599: URL: https://github.com/apache/nuttx/issues/15599#issuecomment-2606530713 @xiaoxiang781216 why we should use `select` here and in other places it's not recommended? Either we are good with `select` (which I think is a bad solution) and use it in other p

[I] [FEATURE] GPS example autoselect MINMEA and configurable serial port [nuttx-apps]

2025-01-21 Thread via GitHub
linguini1 opened a new issue, #2966: URL: https://github.com/apache/nuttx-apps/issues/2966 ### Is your feature request related to a problem? Please describe. Only /dev/ttyS1 works with the GPS example, and it doesn't auto-select its dependencies. ### Describe the solution you'd

(nuttx) branch master updated (9db4d327fa1 -> f695fc6884a)

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9db4d327fa1 sim/virtio: fix typo sim_rpmsg_vritio.c -> sim_rpmsg_virtio.c add f695fc6884a arch/risc-v/src/mpfs

Re: [PR] arch/risc-v/src/mpfs: Disable external interrupts on all SMP harts [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15642: URL: https://github.com/apache/nuttx/pull/15642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sim/virtio: fix typo sim_rpmsg_vritio.c -> sim_rpmsg_virtio.c [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15639: URL: https://github.com/apache/nuttx/pull/15639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (72d793b26e5 -> bed3bd08521)

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 72d793b26e5 Documentation: Add usage of Wireshark for USB monitor add bed3bd08521 Use small lock to protect res

(nuttx) branch master updated (bed3bd08521 -> 9db4d327fa1)

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from bed3bd08521 Use small lock to protect resources related to irq in arch avr, hc, mips and or1k. add 9db4d327fa1

Re: [PR] Use small lock to protect resources related to irq in arch avr, hc, m… [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15635: URL: https://github.com/apache/nuttx/pull/15635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15636: URL: https://github.com/apache/nuttx/pull/15636#discussion_r1924809988 ## arch/xtensa/include/esp32/irq.h: ## @@ -495,6 +495,23 @@ static inline_function int esp32_irq_gpio(int cpu) #endif #endif +#ifdef CONFIG_ARCH_HAVE_MULTIC

(nuttx) branch master updated: Documentation: Add usage of Wireshark for USB monitor

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 72d793b26e5 Documentation: Add usage of Wiresh

Re: [PR] Documentation: Add usage of Wireshark for USB monitor [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15630: URL: https://github.com/apache/nuttx/pull/15630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sim/rpmsg_uart: add sim rpmsg uart support [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15645: URL: https://github.com/apache/nuttx/pull/15645#issuecomment-2606465377 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] sim/rpmsg_uart: add sim rpmsg uart support [nuttx]

2025-01-21 Thread via GitHub
anchao opened a new pull request, #15645: URL: https://github.com/apache/nuttx/pull/15645 ## Summary sim/rpmsg_uart: add sim rpmsg uart support add sim_rpmsg_port_uart.c to verify the rpmsg port uart wrapper layer, The physical transport layer could be: 1. SIM_RAM_UART

Re: [PR] Use small lock to protect resources related to lpi2c. [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15643: URL: https://github.com/apache/nuttx/pull/15643#issuecomment-2606445420 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not adequately meet the Nu

Re: [PR] Mpfs ddr training fixes [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15644: URL: https://github.com/apache/nuttx/pull/15644#issuecomment-2606427671 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX r

[PR] Mpfs ddr training fixes [nuttx]

2025-01-21 Thread via GitHub
jlaitine opened a new pull request, #15644: URL: https://github.com/apache/nuttx/pull/15644 ## Summary These are collection of MPFS patches from TII repositories for DDR training procedure. Specifically, DDR training sometimes passed with incomplete / bad training result,

[PR] Use small lock to protect resources related to lpi2c. [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art opened a new pull request, #15643: URL: https://github.com/apache/nuttx/pull/15643 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Use small lock to protect resources related to lpi2c.

[PR] modlib/meminfo: trivial revision on logging/dump [nuttx]

2025-01-21 Thread via GitHub
yf13 opened a new pull request, #15640: URL: https://github.com/apache/nuttx/pull/15640 ## Summary Cosmetic revisions on modlib logging and meminfo dump format. ## Impacts None ## Testing - local check with qemu-armv7a:knsh - CI checks -- This is a

Re: [PR] arch/risc-v/src/mpfs: Disable external interrupts on all SMP harts [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15642: URL: https://github.com/apache/nuttx/pull/15642#issuecomment-2606408243 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] modlib/meminfo: trivial revision on logging/dump [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15640: URL: https://github.com/apache/nuttx/pull/15640#issuecomment-2606409758 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] arch/risc-v/src/mpfs: Disable external interrupts on all SMP harts [nuttx]

2025-01-21 Thread via GitHub
jlaitine opened a new pull request, #15642: URL: https://github.com/apache/nuttx/pull/15642 Interrupts on MPFS platform are currently served on the hart, on which the up_enable_irq was called. Call to up_disable_irq may execute on different hart than on which the up_enable_irq was ex

[PR] drivers/rpmsg: fix compiler warning [nuttx]

2025-01-21 Thread via GitHub
anchao opened a new pull request, #15641: URL: https://github.com/apache/nuttx/pull/15641 ## Summary drivers/rpmsg: fix compiler warning ``` In file included from nuttx/drivers/rpmsg/rpmsg_port_uart.c:27: nuttx/drivers/rpmsg/rpmsg_port_uart.c: In function ‘rpmsg_port_

(nuttx) branch master updated (0ffb0b716ea -> ab9522fd23e)

2025-01-21 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0ffb0b716ea drivers/iovec: revert vector io implement from loop/null/zero driver add ab9522fd23e file_readv_compa

Re: [PR] file_readv_compat: add a comment to explain limitations [nuttx]

2025-01-21 Thread via GitHub
anchao merged PR #15637: URL: https://github.com/apache/nuttx/pull/15637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[PR] sim/virtio: fix typo sim_rpmsg_vritio.c -> sim_rpmsg_virtio.c [nuttx]

2025-01-21 Thread via GitHub
anchao opened a new pull request, #15639: URL: https://github.com/apache/nuttx/pull/15639 ## Summary sim/virtio: fix typo sim_rpmsg_vritio.c -> sim_rpmsg_virtio.c Build Error: ``` CMake Error at arch/sim/src/sim/CMakeLists.txt:278 (target_sources): Cannot find source

Re: [PR] x86-64 coredump support [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15638: URL: https://github.com/apache/nuttx/pull/15638#issuecomment-2606343973 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] x86-64 coredump support [nuttx]

2025-01-21 Thread via GitHub
XuNeo opened a new pull request, #15638: URL: https://github.com/apache/nuttx/pull/15638 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Add coredump support for x86-64. ## Impact coredump

Re: [PR] Use small lock to protect resources related to irq in arch risc-V and… [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art commented on code in PR #15634: URL: https://github.com/apache/nuttx/pull/15634#discussion_r1924709342 ## arch/xtensa/src/esp32s2/esp32s2_irq.c: ## @@ -495,7 +496,8 @@ int esp32s2_setup_irq(int periphid, int priority, int type) int irq; int cpuint; - irqstat

Re: [PR] Use small lock to protect resources related to irq in arch avr, hc, m… [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art commented on code in PR #15635: URL: https://github.com/apache/nuttx/pull/15635#discussion_r1924708812 ## arch/or1k/src/mor1kx/or1k_irq.c: ## @@ -136,9 +146,9 @@ void or1k_dump_pic(const char *msg, int irq) { irqstate_t flags; - flags = enter_critical_section(

Re: [PR] Use small lock to protect resources related to irq in arch ARM. [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art commented on code in PR #15625: URL: https://github.com/apache/nuttx/pull/15625#discussion_r1924702666 ## arch/arm/src/a1x/a1x_irq.c: ## @@ -362,7 +376,8 @@ void up_enable_irq(int irq) putreg32(regval, regaddr); a1x_dumpintc("enable", irq); - lea

Re: [PR] Use small lock to protect resources related to irq in arch ARM. [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #15625: URL: https://github.com/apache/nuttx/pull/15625#discussion_r1924676033 ## arch/arm/src/a1x/a1x_irq.c: ## @@ -362,7 +376,8 @@ void up_enable_irq(int irq) putreg32(regval, regaddr); a1x_dumpintc("enable", irq); - leave_

Re: [PR] Use small lock to protect resources related to irq in arch risc-V and… [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #15634: URL: https://github.com/apache/nuttx/pull/15634#discussion_r1924674192 ## arch/xtensa/src/esp32s2/esp32s2_irq.c: ## @@ -495,7 +496,8 @@ int esp32s2_setup_irq(int periphid, int priority, int type) int irq; int cpuint; - irqstate =

Re: [PR] Use small lock to protect resources related to irq in arch avr, hc, m… [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #15635: URL: https://github.com/apache/nuttx/pull/15635#discussion_r1924670118 ## arch/or1k/src/mor1kx/or1k_irq.c: ## @@ -136,9 +146,9 @@ void or1k_dump_pic(const char *msg, int irq) { irqstate_t flags; - flags = enter_critical_section();

Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15636: URL: https://github.com/apache/nuttx/pull/15636#issuecomment-2606232851 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] file_readv_compat: add a comment to explain limitations [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15637: URL: https://github.com/apache/nuttx/pull/15637#issuecomment-2606231741 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1924656594 ## include/nuttx/spinlock.h: ## @@ -1003,7 +1048,15 @@ void read_unlock_irqrestore(FAR rwlock_t *lock, irqstate_t flags); #ifdef CONFIG_SPINLOCK irqstate_t write_lo

[PR] file_readv_compat: add a comment to explain limitations [nuttx]

2025-01-21 Thread via GitHub
yamt opened a new pull request, #15637: URL: https://github.com/apache/nuttx/pull/15637 ## Summary file_readv_compat: add a comment to explain limitations ## Impact no functional changes are intended. ## Testing -- This is an automated message from the Apach

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1924656070 ## include/nuttx/irq.h: ## @@ -75,16 +75,6 @@ #endif /* __ASSEMBLY__ */ -#ifdef CONFIG_SMP -# define cpu_irqlock_clear() \ Review Comment: done ##

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1924655917 ## include/nuttx/irq.h: ## @@ -80,7 +80,7 @@ do \ { \ g_cpu_irqset = 0; \ Review Comment: We need g_cpu_irqlock not just to protect g_cpu_irqset, bu

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2025-01-21 Thread via GitHub
hujun260 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1924654927 ## include/nuttx/spinlock.h: ## @@ -233,6 +233,8 @@ static inline_function void raw_spin_lock(FAR volatile spinlock_t *lock) #ifdef CONFIG_SPINLOCK static inline_fu

[PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
chirping78 opened a new pull request, #15636: URL: https://github.com/apache/nuttx/pull/15636 ## Summary Currently `up_cpu_index` of xtensa arch is a non-inline function, which means it will be called by `callX` instruction, and it will cause stack push/pop operations. And fro

(nuttx) branch master updated (5918335b7fa -> 0ffb0b716ea)

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5918335b7fa armv8m: Default open hardware stack check add 0ffb0b716ea drivers/iovec: revert vector io implement

Re: [PR] drivers/iovec: revert vector io implement from loop/null/zero driver [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15629: URL: https://github.com/apache/nuttx/pull/15629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #2965: URL: https://github.com/apache/nuttx-apps/pull/2965#discussion_r1924594436 ## testing/mm/open_memstream/Make.defs: ## @@ -1,5 +1,5 @@ -# apps/testing/open

Re: [PR] Use small lock to protect resources related to irq in arch avr, hc, m… [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15635: URL: https://github.com/apache/nuttx/pull/15635#issuecomment-2606207720 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
cederom commented on code in PR #2965: URL: https://github.com/apache/nuttx-apps/pull/2965#discussion_r1924639044 ## testing/mm/resmonitor/Make.defs: ## @@ -1,5 +1,5 @@ -# apps/testing/resmonitor/Make.

[PR] Use small lock to protect resources related to irq in arch avr, hc, m… [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art opened a new pull request, #15635: URL: https://github.com/apache/nuttx/pull/15635 …ips and or1k. *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Use small lock to protect resources r

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on PR #15603: URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2606195953 > @yamt thank you. kudo for you to deal with a stubborn person like me patiently. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on PR #15603: URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2606190664 @yamt thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] arm: Support hardware debugging of ARM architecture [nuttx]

2025-01-21 Thread via GitHub
W-M-R commented on code in PR #15616: URL: https://github.com/apache/nuttx/pull/15616#discussion_r1924632306 ## arch/arm/src/armv7-a/arm_dbgmonitor.c: ## @@ -0,0 +1,767 @@ +/ + * arch/arm/src/armv7-a/arm

Re: [PR] arm: Support hardware debugging of ARM architecture [nuttx]

2025-01-21 Thread via GitHub
W-M-R commented on code in PR #15616: URL: https://github.com/apache/nuttx/pull/15616#discussion_r1924632306 ## arch/arm/src/armv7-a/arm_dbgmonitor.c: ## @@ -0,0 +1,767 @@ +/ + * arch/arm/src/armv7-a/arm

Re: [PR] Documentation: Add usage of Wireshark for USB monitor [nuttx]

2025-01-21 Thread via GitHub
JianyuWang0623 commented on PR #15630: URL: https://github.com/apache/nuttx/pull/15630#issuecomment-2606188519 > @JianyuWang0623 please include an image from Wireshark showing it displaying the USB communication over the endpoints @acassis Done, and the example capture file added. -

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924629788 ## fs/vfs/fs_uio.c: ## @@ -82,8 +82,8 @@ ssize_t uio_calc_resid(FAR const struct uio *uio) void uio_advance(FAR struct uio *uio, size_t sz) { FAR const struct iovec

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924628918 ## fs/vfs/fs_uio.c: ## @@ -82,8 +82,8 @@ ssize_t uio_calc_resid(FAR const struct uio *uio) void uio_advance(FAR struct uio *uio, size_t sz) { FAR const struct iovec *

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924626091 ## fs/vfs/fs_uio.c: ## @@ -82,8 +82,8 @@ ssize_t uio_calc_resid(FAR const struct uio *uio) void uio_advance(FAR struct uio *uio, size_t sz) { FAR const struct iovec

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924624287 ## fs/vfs/fs_read.c: ## @@ -50,19 +50,14 @@ * / -static ssize_t file_readv_compat(FAR str

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924621279 ## fs/vfs/fs_uio.c: ## @@ -82,8 +82,8 @@ ssize_t uio_calc_resid(FAR const struct uio *uio) void uio_advance(FAR struct uio *uio, size_t sz) { FAR const struct iovec *

Re: [PR] Use small lock to protect resources related to irq in arch risc-V and… [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15634: URL: https://github.com/apache/nuttx/pull/15634#issuecomment-2606165013 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
txy-21 commented on code in PR #2965: URL: https://github.com/apache/nuttx-apps/pull/2965#discussion_r1924619224 ## testing/mm/mmtool/Kconfig: ## @@ -32,3 +32,4 @@ config TESTING_MM_POWEROFF depends on BOARDCTL_POWEROFF endif + Review Comment: ok -- This is an

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924617052 ## fs/vfs/fs_read.c: ## @@ -50,19 +50,14 @@ * / -static ssize_t file_readv_compat(FAR s

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924613830 ## fs/vfs/fs_read.c: ## @@ -74,36 +69,36 @@ static ssize_t file_readv_compat(FAR struct file *filep, FAR struct uio *uio) continue; } - buffe

[PR] Use small lock to protect resources related to irq in arch risc-V and… [nuttx]

2025-01-21 Thread via GitHub
wangzhi-art opened a new pull request, #15634: URL: https://github.com/apache/nuttx/pull/15634 … xtensa. *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Use small lock to protect resources related to

[PR] sim/nsh: enable debug assertion by default [nuttx]

2025-01-21 Thread via GitHub
anchao opened a new pull request, #15633: URL: https://github.com/apache/nuttx/pull/15633 ## Summary sim/nsh: enable debug assertion by default In order to more easily catch the assertion issue in advance Signed-off-by: chao an ## Impact N/A ## T

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924600320 ## fs/vfs/fs_read.c: ## @@ -74,36 +69,36 @@ static ssize_t file_readv_compat(FAR struct file *filep, FAR struct uio *uio) continue; } - buffer

Re: [PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #2965: URL: https://github.com/apache/nuttx-apps/pull/2965#discussion_r1924594436 ## testing/mm/open_memstream/Make.defs: ## @@ -1,5 +1,5 @@ -# apps/testing/open

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924599451 ## fs/vfs/fs_uio.c: ## @@ -131,7 +131,7 @@ int uio_init(FAR struct uio *uio, FAR const struct iovec *iov, int iovcnt) resid = uio_calc_resid(uio); if (resid < 0)

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924594260 ## fs/vfs/fs_read.c: ## @@ -74,36 +69,36 @@ static ssize_t file_readv_compat(FAR struct file *filep, FAR struct uio *uio) continue; } - buffe

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924592962 ## fs/vfs/fs_read.c: ## @@ -361,5 +352,6 @@ ssize_t read(int fd, FAR void *buf, size_t nbytes) iov.iov_base = buf; iov.iov_len = nbytes; + Review Comment: do

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924592896 ## fs/vfs/fs_uio.c: ## @@ -131,7 +131,7 @@ int uio_init(FAR struct uio *uio, FAR const struct iovec *iov, int iovcnt) resid = uio_calc_resid(uio); if (resid < 0)

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924592489 ## fs/vfs/fs_uio.c: ## @@ -82,8 +82,8 @@ ssize_t uio_calc_resid(FAR const struct uio *uio) void uio_advance(FAR struct uio *uio, size_t sz) { FAR const struct iovec

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924584562 ## fs/vfs/fs_uio.c: ## @@ -131,7 +131,7 @@ int uio_init(FAR struct uio *uio, FAR const struct iovec *iov, int iovcnt) resid = uio_calc_resid(uio); if (resid < 0)

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924580628 ## fs/vfs/fs_read.c: ## @@ -50,19 +50,14 @@ * / -static ssize_t file_readv_compat(FAR str

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on PR #15603: URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2606106302 > > > > i guess the main disagreement between us is on how large the overhead is. anchao seems to think it important. i feel it's negligible. none of us provided any numbers. maybe i can do

Re: [PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #2965: URL: https://github.com/apache/nuttx-apps/pull/2965#issuecomment-2606104440 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the Nutt

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
yamt commented on code in PR #15603: URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924580628 ## fs/vfs/fs_read.c: ## @@ -50,19 +50,14 @@ * / -static ssize_t file_readv_compat(FAR str

Re: [PR] arm: Support hardware debugging of ARM architecture [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15616: URL: https://github.com/apache/nuttx/pull/15616#discussion_r1924578564 ## arch/arm/src/armv7-a/arm_dbgmonitor.c: ## @@ -0,0 +1,767 @@ +/ + * arch/arm/src/a

Re: [PR] arm: Support hardware debugging of ARM architecture [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15616: URL: https://github.com/apache/nuttx/pull/15616#discussion_r1924577026 ## arch/arm/src/armv7-a/arm_dbgmonitor.c: ## @@ -0,0 +1,767 @@ +/ + * arch/arm/src/a

[PR] apps/testing:merge case folder to the new mm folder [nuttx-apps]

2025-01-21 Thread via GitHub
txy-21 opened a new pull request, #2965: URL: https://github.com/apache/nuttx-apps/pull/2965 ## Summary This is one step that merge test case as discussed in https://github.com/apache/nuttx-apps/pull/2931. Create mm folder and move folders to the new mm folder. ## Impact

Re: [PR] apps/testing:move arch_libc, fmemopen, scanftest folders to the new libc folder [nuttx-apps]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #2964: URL: https://github.com/apache/nuttx-apps/pull/2964#issuecomment-2606090355 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX require

[PR] apps/testing:move arch_libc, fmemopen, scanftest folders to the new libc folder [nuttx-apps]

2025-01-21 Thread via GitHub
txy-21 opened a new pull request, #2964: URL: https://github.com/apache/nuttx-apps/pull/2964 ## Summary This is one step that merge test case as discussed in https://github.com/apache/nuttx-apps/pull/2931. Create libc folder and move arch_libc, fmemopen, scanftest folders to the n

(nuttx-website) branch asf-site updated: Publishing web: c9485a98e52c59e17f5874dcfcda910d849854c2 docs: 5918335b7faeb6fbcd2d91f621944f02e025b838

2025-01-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 50e3d62e86 Publishing web: c9485a

[I] [HELP] NuttX Make issues inside of Docker container [nuttx]

2025-01-21 Thread via GitHub
stbenn opened a new issue, #15632: URL: https://github.com/apache/nuttx/issues/15632 ### Description I am creating a process to have easily reproducible development environments for my various NuttX projects. The solution I have come up with uses a very simple Docker container to man

Re: [PR] spin_lock_irqsave+sched_lock [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1924172641 ## include/nuttx/spinlock.h: ## @@ -499,6 +499,50 @@ irqstate_t spin_lock_irqsave(FAR volatile spinlock_t *lock) # define spin_lock_irqsave(l) ((void)(l), up_

(nuttx-apps) branch master updated: apps/testing:move epoll, fatutf8 ... folders to the new fs folder

2025-01-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8141e35f9 apps/testing:move epoll, fatutf

Re: [PR] apps/testing:move epoll, fatutf8 ... folders to the new fs folder [nuttx-apps]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #2963: URL: https://github.com/apache/nuttx-apps/pull/2963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [I] [HELP] Using espnow on NuttX for espressif devices [nuttx]

2025-01-21 Thread via GitHub
tmedicci commented on issue #15347: URL: https://github.com/apache/nuttx/issues/15347#issuecomment-2605230343 > [@tmedicci](https://github.com/tmedicci) I have been doing some further work and I can send some packets to the network. I'm using the broadcast address 0xff, 0xff, ... and `esp_n

Re: [I] [HELP] Using espnow on NuttX for espressif devices [nuttx]

2025-01-21 Thread via GitHub
Laczen commented on issue #15347: URL: https://github.com/apache/nuttx/issues/15347#issuecomment-2605142580 @tmedicci I have been doing some further work and I can send some packets to the network. I'm using the broadcast address 0xff, 0xff, ... and `esp_now_send()` returns 0. However as th

Re: [I] [DOCUMENTATION] Open hardware stack check [nuttx]

2025-01-21 Thread via GitHub
acassis commented on issue #15631: URL: https://github.com/apache/nuttx/issues/15631#issuecomment-2604971798 @W-M-R please close this Issue after submitting the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] [DOCUMENTATION] Open hardware stack check [nuttx]

2025-01-21 Thread via GitHub
acassis opened a new issue, #15631: URL: https://github.com/apache/nuttx/issues/15631 ### Is your feature request related to a problem? Please describe. Documentation about new features introduced to NuttX: https://github.com/apache/nuttx/pull/15628 ### Describe the solution yo

(nuttx) branch master updated: armv8m: Default open hardware stack check

2025-01-21 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5918335b7fa armv8m: Default open hardware stack

Re: [PR] armv8m: Default open hardware stack check [nuttx]

2025-01-21 Thread via GitHub
acassis merged PR #15628: URL: https://github.com/apache/nuttx/pull/15628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] armv8m: Default open hardware stack check [nuttx]

2025-01-21 Thread via GitHub
W-M-R commented on PR #15628: URL: https://github.com/apache/nuttx/pull/15628#issuecomment-2604951069 > @W-M-R please include Documentation/ about how to use this feature Ok,I will provide instructions on how to use multiple tools on future patches -- This is an automated message fr

Re: [PR] Documentation: Add usage of Wireshark for USB monitor [nuttx]

2025-01-21 Thread via GitHub
acassis commented on PR #15630: URL: https://github.com/apache/nuttx/pull/15630#issuecomment-2604914526 @JianyuWang0623 please include an image from Wireshark showing it displaying the USB communication over the endpoints -- This is an automated message from the Apache Git Service. To res

Re: [PR] Documentation: Add usage of Wireshark for USB monitor [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15630: URL: https://github.com/apache/nuttx/pull/15630#issuecomment-2604699565 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR is missing critical information required by

[PR] Documentation: Add usage of Wireshark for USB monitor [nuttx]

2025-01-21 Thread via GitHub
JianyuWang0623 opened a new pull request, #15630: URL: https://github.com/apache/nuttx/pull/15630 ## Summary Add usage of Wireshark for USB monitor. ![image](https://github.com/user-attachments/assets/89872d8d-9280-47b4-8901-7aeeae10d5a9) ## Impact Documentation ## Tes

Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

2025-01-21 Thread via GitHub
anchao commented on PR #15603: URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2604645799 @yamt please review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] drivers/iovec: revert vector io implement from loop/null/zero driver [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15629: URL: https://github.com/apache/nuttx/pull/15629#issuecomment-2604610208 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements.

Re: [PR] boards/qemu-armv7a: revises knsh config [nuttx]

2025-01-21 Thread via GitHub
anchao merged PR #15626: URL: https://github.com/apache/nuttx/pull/15626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) branch master updated (dc3ab55e6de -> 1828d09b2a5)

2025-01-21 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from dc3ab55e6de libc/gdbstub: avoid RLE decoding special characters add 1828d09b2a5 boards/qemu-armv7a: revises kernel

Re: [PR] boards/qemu-armv7a: revises knsh config [nuttx]

2025-01-21 Thread via GitHub
anchao commented on PR #15626: URL: https://github.com/apache/nuttx/pull/15626#issuecomment-2604484319 @yf13 You could add partner email to your personal github account -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

  1   2   >