nuttxpr commented on PR #15640: URL: https://github.com/apache/nuttx/pull/15640#issuecomment-2606409758
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although minimally. While technically compliant, it would benefit from more detail, especially given the vagueness of "cosmetic revisions." Specifically: * **Summary:** While it states *what* changed, it doesn't explain *why*. Even for cosmetic changes, a brief rationale (e.g., "improved readability," "consistent formatting with other modules") is helpful. It should also specify *which* modules in `modlib` were affected. * **Impacts:** Stating "None" is acceptable if truly no impact, but this needs careful consideration. Did the log output change in any way that could affect scripts parsing those logs? Even minor formatting changes *could* have unintended consequences. * **Testing:** "local check" is insufficient. Provide the *actual* commands used (e.g., `make distclean && configure sim:qemu-armv7a:knsh && make && make run`), and ideally, snippets of the before/after log output demonstrating the cosmetic improvements. CI passing is good, but doesn't replace showcasing the specific changes this PR introduces. In short, while technically meeting the letter of the requirements, the PR would be stronger with more specific information to demonstrate due diligence and facilitate review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
