yamt commented on code in PR #15603:
URL: https://github.com/apache/nuttx/pull/15603#discussion_r1924580628
##########
fs/vfs/fs_read.c:
##########
@@ -50,19 +50,14 @@
*
****************************************************************************/
-static ssize_t file_readv_compat(FAR struct file *filep, FAR struct uio *uio)
+static ssize_t file_readv_compat(FAR struct file *filep,
+ FAR const struct iovec *iov, int iovcnt)
{
- FAR const struct iovec *iov = uio->uio_iov;
- int iovcnt = uio->uio_iovcnt;
FAR struct inode *inode = filep->f_inode;
ssize_t ntotal;
ssize_t nread;
- size_t remaining;
- FAR uint8_t *buffer;
int i;
- DEBUGASSERT(inode->u.i_ops->read != NULL);
Review Comment:
yes, this assertion is to ensure the condition.
and "the assertion is currently always true" is not a good reason to remove
an assertion, IMO.
it's just how all assertions should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
