xiaoxiang781216 commented on code in PR #15636:
URL: https://github.com/apache/nuttx/pull/15636#discussion_r1924809988


##########
arch/xtensa/include/esp32/irq.h:
##########
@@ -495,6 +495,23 @@ static inline_function int esp32_irq_gpio(int cpu)
 #endif
 #endif
 
+#ifdef CONFIG_ARCH_HAVE_MULTICPU

Review Comment:
   the implementation is same, why not merge the implementation into 
arch/xtensa/include/irq.h
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to