(nuttx) branch master updated (007a3fffac -> 500b55c330)

2025-01-14 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 007a3fffac Use small lock to protect usbdev and endpoint in AVR. add 500b55c330 Documentation: update uorb and s

Re: [PR] Documentation: update uorb and sensor driver doc [nuttx]

2025-01-14 Thread via GitHub
raiden00pl merged PR #15557: URL: https://github.com/apache/nuttx/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1916088448 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -792,9 +802,9 @@ static int sim_ep_cancel(struct usbdev_ep_s *ep, struct usbdev_req_s *req) usbtrace(TRACE_EPCANCEL, U

Re: [PR] Use small lock to protect usbdev and endpoint in arch ARM. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art closed pull request #15506: Use small lock to protect usbdev and endpoint in arch ARM. URL: https://github.com/apache/nuttx/pull/15506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use small lock to protect usbdev and endpoint in arch ARM. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15506: URL: https://github.com/apache/nuttx/pull/15506#discussion_r1916071845 ## arch/arm/src/lpc214x/lpc214x_usbdev.c: ## @@ -1124,6 +1139,19 @@ static int lpc214x_wrrequest(struct lpc214x_ep_s *privep) return OK; } +static int lpc214x

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #2947: URL: https://github.com/apache/nuttx-apps/pull/2947#issuecomment-2591804366 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not adequately meet the

Re: [PR] The placement of cases under testing is a bit messy, and cases of the same type need to be merged [nuttx-apps]

2025-01-14 Thread via GitHub
txy-21 commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2591803408 > I don't think that `apps/testing` is a good place to keep any tests logic. This directory was created for `unity` framework which is intended to use by user code to implement user app

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1916038583 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -1008,9 +1018,9 @@ static int sim_usbdev_pullup(struct usbdev_s *dev, bool enable) usbtrace(TRACE_DEVPULLUP, (uint

Re: [PR] Add GD55 QSPI NOR Flash support [nuttx]

2025-01-14 Thread via GitHub
Donny9 commented on code in PR #15523: URL: https://github.com/apache/nuttx/pull/15523#discussion_r1916029117 ## drivers/mtd/gd55.c: ## @@ -0,0 +1,2082 @@ +/ + * drivers/mtd/gd55.c + * + * Licensed to th

[PR] Driver test issue fix [nuttx-apps]

2025-01-14 Thread via GitHub
Zhangshoukui opened a new pull request, #2947: URL: https://github.com/apache/nuttx-apps/pull/2947 ## Summary Driver test issue fix ## Impact Driver test issue ## Testing local test -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #2946: URL: https://github.com/apache/nuttx-apps/pull/2946#issuecomment-2591785220 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the Nutt

[PR] arm/qemu: select NEON at processor level [nuttx]

2025-01-14 Thread via GitHub
yf13 opened a new pull request, #15558: URL: https://github.com/apache/nuttx/pull/15558 ## Summary This revises QEMU_ARM chip family config by moving choice of NEON down to processor level because processors like Cortex-R5 doesn't have it. ## Impacts QEMU emulated ARM pr

Re: [PR] boards/xtensa: disable DEV_CONSOLE on usbnsh defconfig [nuttx]

2025-01-14 Thread via GitHub
Donny9 commented on PR #15524: URL: https://github.com/apache/nuttx/pull/15524#issuecomment-2591781722 > I would like to bring up two to things to our attention. > > * I checked other `usbnsh` from other vendors and they take this into consideration (`DEV_CONSOLE` is disabled) > *

[PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-14 Thread via GitHub
Zhangshoukui opened a new pull request, #2946: URL: https://github.com/apache/nuttx-apps/pull/2946 ## Summary Use lib_get_tempbuffer Saving stack ## Impact Saves the consumption of stack space ## Testing ./tools/configure.sh -l sim:nsh make -j5 -- This is an automated

Re: [PR] Documentation: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` [nuttx]

2025-01-14 Thread via GitHub
JianyuWang0623 closed pull request #15554: Documentation: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` URL: https://github.com/apache/nuttx/pull/15554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Documentation: update uorb and sensor driver doc [nuttx]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #15557: URL: https://github.com/apache/nuttx/pull/15557#issuecomment-2591775093 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR does not fully meet the NuttX requirements.

Re: [PR] gitignore: add Emacs auto-save files [nuttx]

2025-01-14 Thread via GitHub
JianyuWang0623 commented on PR #1: URL: https://github.com/apache/nuttx/pull/1#issuecomment-2591774119 Link - https://github.com/apache/nuttx-apps/pull/2943 - https://github.com/apache/nuttx/pull/9387 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] drivers/sensors: Wrote a driver for the MCP9600 thermocouple amplifier. [nuttx]

2025-01-14 Thread via GitHub
Donny9 commented on PR #15525: URL: https://github.com/apache/nuttx/pull/15525#issuecomment-2591772912 @ > > @linguini1 that's the biggest problem with this new framework - there is absolutely no documentation :( and I know that without proper documentation, it's inappropriate to ask

[PR] Documentation: update uorb and sensor driver doc [nuttx]

2025-01-14 Thread via GitHub
Donny9 opened a new pull request, #15557: URL: https://github.com/apache/nuttx/pull/15557 ## Summary Documentation: update uorb and sensor driver doc, include uorb usage and sensor driver introduce. ## Impact N/A ## Testing make html -- T

[PR] Arm64 fix kmm map [nuttx]

2025-01-14 Thread via GitHub
jlaitine opened a new pull request, #15556: URL: https://github.com/apache/nuttx/pull/15556 ## Summary This PR fixes making page mappings into kernel: 1. In mm/kmap/kmm_map.c, a wrong pointer is given to gran_free when a mapping is released, corrupting memory 2. In arm64

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1916009658 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -347,9 +350,9 @@ static void sim_reqcomplete(struct sim_ep_s *privep, int16_t result) /* Remove the completed request

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591754930 > > > > > > > why not? they are kernel characteristics as far as i know. > > > > > > > > > > > > > > > > > > Let me clarify further, should be"define", not "use" > > > > > > >

Re: [PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
crafcat7 commented on PR #15553: URL: https://github.com/apache/nuttx/pull/15553#issuecomment-2591754744 > i don't understand why #13722 replaced kmm_mallinfo_task with fs_heap_mallinfo_task. The purpose of the previous change in https://github.com/apache/nuttx/pull/13722 is to isola

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1916007014 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## @@ -21,14 +21,14 @@ CONFIG_BOARD_LOOPSPERMSEC=5500 CONFIG_EXPERIMENTAL=y CONFIG_FS_LITTLEFS=y CONFI

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591751077 > > > > > > why not? they are kernel characteristics as far as i know. > > > > > > > > > > > > > > > Let me clarify further, should be"define", not "use" > > > > > > and also not

Re: [PR] arch/nrf53: add QSPI support [nuttx]

2025-01-14 Thread via GitHub
raiden00pl commented on code in PR #9387: URL: https://github.com/apache/nuttx/pull/9387#discussion_r1916004253 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## Review Comment: this is emacs auto-save temporary file. Should not be added. Fixed here https:

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1916003591 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ -

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
crafcat7 commented on code in PR #15552: URL: https://github.com/apache/nuttx/pull/15552#discussion_r1916001367 ## arch/sim/src/sim/posix/sim_hostfs.c: ## @@ -233,7 +246,7 @@ nuttx_ssize_t host_read(int fd, void *buf, nuttx_size_t count) ret = -errno; } - return

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1916000701 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## @@ -21,14 +21,14 @@ CONFIG_BOARD_LOOPSPERMSEC=5500 CONFIG_EXPERIMENTAL=y CONFIG_FS_LITTLEFS=y CONFIG_

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915997621 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ -

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591740097 > > > > > why not? they are kernel characteristics as far as i know. > > > > > > > > > > > > Let me clarify further, should be"define", not "use" > > > > > and also not suitabl

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915997621 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ -

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591736154 > > > > why not? they are kernel characteristics as far as i know. > > > > > > > > > Let me clarify further, should be"define", not "use" > > > > and also not suitable for **defi

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591733382 > > > why not? they are kernel characteristics as far as i know. > > > > > > Let me clarify further, should be"define", not "use" > > > and also not suitable for **define** in

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591731876 > > why not? they are kernel characteristics as far as i know. > > Let me clarify further, should be"define", not "use" > > > and also not suitable for **define** in the sched di

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915991650 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## @@ -21,14 +21,14 @@ CONFIG_BOARD_LOOPSPERMSEC=5500 CONFIG_EXPERIMENTAL=y CONFIG_FS_LITTLEFS=y CONFI

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915991447 ## libs/libc/unistd/Kconfig: ## @@ -117,3 +117,25 @@ config OPEN_MAX ---help--- The maximum number of files that a process can have open

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591726170 > why not? they are kernel characteristics as far as i know. Let me clarify further, should be"define", not "use" > and also not suitable for **define** in the sched directory.

Re: [PR] Use small lock to protect usbdev and endpoint in mips. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15548: URL: https://github.com/apache/nuttx/pull/15548#discussion_r1915990854 ## arch/mips/src/pic32mx/pic32mx_usbdev.c: ## @@ -4383,7 +4401,8 @@ void mips_usbuninitialize(void) struct pic32mx_usbdev_s *priv = &g_usbdev; irqstate_t flag

Re: [PR] Documentation: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` [nuttx]

2025-01-14 Thread via GitHub
anchao commented on PR #15554: URL: https://github.com/apache/nuttx/pull/15554#issuecomment-2591727455 already update on PR https://github.com/apache/nuttx/pull/15551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915990409 ## libs/libc/unistd/Kconfig: ## @@ -111,7 +111,7 @@ config LIBC_HOSTNAME ---help--- A unique name to identify device on the network -config LIB

Re: [PR] arch/nrf53: add QSPI support [nuttx]

2025-01-14 Thread via GitHub
JianyuWang0623 commented on code in PR #9387: URL: https://github.com/apache/nuttx/pull/9387#discussion_r1915889205 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## Review Comment: Could you explain what is the file “#defconfig#” used for? `CONFIG_NSH_L

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591689564 > and also not suitable for use in the sched directory. why not? they are kernel characteristics as far as i know. -- This is an automated message from the Apache Git Service

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
yamt commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915962190 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## @@ -21,14 +21,14 @@ CONFIG_BOARD_LOOPSPERMSEC=5500 CONFIG_EXPERIMENTAL=y CONFIG_FS_LITTLEFS=y CONFIG_

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
yamt commented on code in PR #15552: URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915951045 ## arch/sim/src/sim/posix/sim_hostfs.c: ## @@ -233,7 +246,7 @@ nuttx_ssize_t host_read(int fd, void *buf, nuttx_size_t count) ret = -errno; } - return ret;

Re: [PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15553: URL: https://github.com/apache/nuttx/pull/15553#issuecomment-2591648873 > which is used in fs/fs_procfsproc.c -> proc_heap do you mean fs/fs_procfsproc.c is currently broken and this PR fixes it? -- This is an automated message from the Apache Git Servic

Re: [PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15553: URL: https://github.com/apache/nuttx/pull/15553#issuecomment-2591656364 i don't understand why https://github.com/apache/nuttx/pull/13722 replaced kmm_mallinfo_task with fs_heap_mallinfo_task. to me, it seems like a mistake with a bulk kmm -> fs_heap change.

Re: [PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
crafcat7 commented on PR #15553: URL: https://github.com/apache/nuttx/pull/15553#issuecomment-2591653940 > > which is used in fs/fs_procfsproc.c -> proc_heap > > do you mean fs/fs_procfsproc.c is currently broken and this PR fixes it? Yes, I fixed the problem. When we enable

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
crafcat7 commented on code in PR #15552: URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915930496 ## arch/sim/src/sim/posix/sim_hostfs.c: ## @@ -279,7 +292,7 @@ int host_ioctl(int fd, int request, unsigned long arg) { /* Just call the ioctl routine */ - retu

Re: [PR] Reimplement readv to deal with short reads [nuttx]

2025-01-14 Thread via GitHub
yamt closed pull request #12674: Reimplement readv to deal with short reads URL: https://github.com/apache/nuttx/pull/12674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Reimplement readv to deal with short reads [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #12674: URL: https://github.com/apache/nuttx/pull/12674#issuecomment-2591614117 i'm closing this as https://github.com/apache/nuttx/pull/14898, which fixes the issue for the specific driver i care right now, was merged. -- This is an automated message from the Apa

Re: [PR] Use small lock to protect usbdev and endpoint in mips. [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15548: URL: https://github.com/apache/nuttx/pull/15548#discussion_r1915916408 ## arch/mips/src/pic32mx/pic32mx_usbdev.c: ## @@ -4383,7 +4401,8 @@ void mips_usbuninitialize(void) struct pic32mx_usbdev_s *priv = &g_usbdev; irqstate_t flags;

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15552: URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2591607069 * i suspect the "generic" error number used for the case where conversion is not available might need to be per-operation. * what's your plan for other backends? (eg. arch/xtensa/src/com

[PR] Documentation: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` [nuttx]

2025-01-14 Thread via GitHub
JianyuWang0623 opened a new pull request, #15554: URL: https://github.com/apache/nuttx/pull/15554 ## Summary Documentation: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` https://github.com/apache/nuttx/pull/15541 https://github.com/apache/nuttx-apps/pull/2943 ## Impact

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2591591828 > @yamt the conversion of errno will provide in a new pr soon, so let's merge this patch first. sorry, i'm against it. your reasoning sounds like "merge changes which might break ot

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-14 Thread via GitHub
yamt commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2591587419 > > my suggestion > > introduce a hostfs backend api like: > > ``` > > int host_convert_errno_to_nuttx(int host_error, int default_error) > > ``` > > > > > > > >

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915900668 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ -

Re: [PR] Use small lock to protect usbdev and endpoint in mips. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15548: URL: https://github.com/apache/nuttx/pull/15548#discussion_r1915900767 ## arch/mips/src/pic32mx/pic32mx_usbdev.c: ## @@ -4383,7 +4401,8 @@ void mips_usbuninitialize(void) struct pic32mx_usbdev_s *priv = &g_usbdev; irqstate_t flag

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1915900866 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -347,9 +350,9 @@ static void sim_reqcomplete(struct sim_ep_s *privep, int16_t result) /* Remove the completed request

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1915900866 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -347,9 +350,9 @@ static void sim_reqcomplete(struct sim_ep_s *privep, int16_t result) /* Remove the completed request

Re: [PR] Use small lock to protect usbdev and endpoint in mips. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15548: URL: https://github.com/apache/nuttx/pull/15548#discussion_r1915900767 ## arch/mips/src/pic32mx/pic32mx_usbdev.c: ## @@ -4383,7 +4401,8 @@ void mips_usbuninitialize(void) struct pic32mx_usbdev_s *priv = &g_usbdev; irqstate_t flag

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915900668 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ -

Re: [PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #15553: URL: https://github.com/apache/nuttx/pull/15553#issuecomment-2591571693 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915893061 ## libs/libc/unistd/Kconfig: ## @@ -117,3 +117,25 @@ config OPEN_MAX ---help--- The maximum number of files that a process can have open

[PR] fs_heap:add fs_heap_mallinfo_task [nuttx]

2025-01-14 Thread via GitHub
crafcat7 opened a new pull request, #15553: URL: https://github.com/apache/nuttx/pull/15553 ## Summary Added fs_heap_mallinfo_task implementation, which is used in fs/fs_procfsproc.c -> `proc_heap` ## Impact **Is a new feature added?:** NO **Impact on build:** NO *

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #15552: URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915891764 ## arch/sim/src/sim/posix/sim_hostfs.c: ## @@ -299,7 +312,7 @@ void host_sync(int fd) int host_dup(int fd) { - return dup(fd); + return host_errno_convert

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on PR #15552: URL: https://github.com/apache/nuttx/pull/15552#issuecomment-259127 @yamt could you review the change match your expect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] arch/nrf53: add QSPI support [nuttx]

2025-01-14 Thread via GitHub
JianyuWang0623 commented on code in PR #9387: URL: https://github.com/apache/nuttx/pull/9387#discussion_r1915889205 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## Review Comment: Could you explain what is the file “#defconfig#” used for? `CONFIG_NSH_L

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #15552: URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2591545709 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] apps/nshlib: Remove the deprecated config `NSH_LINELEN` [nuttx-apps]

2025-01-14 Thread via GitHub
JianyuWang0623 opened a new pull request, #2945: URL: https://github.com/apache/nuttx-apps/pull/2945 ## Summary apps/nshlib: Remove the deprecated config `NSH_LINELEN`. See https://github.com/apache/nuttx/pull/15541 and https://github.com/apache/nuttx-apps/pull/2943 please. ## I

[PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-14 Thread via GitHub
crafcat7 opened a new pull request, #15552: URL: https://github.com/apache/nuttx/pull/15552 ## Summary This PR comes from the discussion of https://github.com/apache/nuttx/pull/15535#event-15924592365. A common conversion interface `host_errno_convert` is provided in `arch/sim/pos

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915873851 ## libs/libc/unistd/Kconfig: ## @@ -117,3 +117,25 @@ config OPEN_MAX ---help--- The maximum number of files that a process can have open

Re: [PR] Use small lock to protect usbdev and endpoint in arch ARM. [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15506: URL: https://github.com/apache/nuttx/pull/15506#discussion_r1915870152 ## arch/arm/src/lpc214x/lpc214x_usbdev.c: ## @@ -1124,6 +1139,19 @@ static int lpc214x_wrrequest(struct lpc214x_ep_s *privep) return OK; } +static int lpc214x_wr

Re: [PR] Use small lock to protect usbdev and endpoint in sim. [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15545: URL: https://github.com/apache/nuttx/pull/15545#discussion_r1915867584 ## arch/sim/src/sim/sim_usbdev.c: ## @@ -347,9 +350,9 @@ static void sim_reqcomplete(struct sim_ep_s *privep, int16_t result) /* Remove the completed request at

Re: [PR] Use small lock to protect usbdev and endpoint in renesas. [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915864077 ## arch/renesas/src/rx65n/rx65n_usbdev.c: ## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ - fla

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1915861196 ## libs/libc/unistd/Kconfig: ## @@ -111,7 +111,7 @@ config LIBC_HOSTNAME ---help--- A unique name to identify device on the network -c

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15550: URL: https://github.com/apache/nuttx/pull/15550#discussion_r1915861119 ## arch/arm/src/armv7-r/arm_syscall.c: ## @@ -258,6 +258,7 @@ uint32_t *arm_syscall(uint32_t *regs) rtcb->flags &= ~TCB_FLAG_SYSCALL;

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15550: URL: https://github.com/apache/nuttx/pull/15550#discussion_r1915861010 ## arch/arm/src/armv7-a/arm_syscall.c: ## @@ -261,6 +261,7 @@ uint32_t *arm_syscall(uint32_t *regs) rtcb->flags &= ~TCB_FLAG_SYSCALL;

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
nuttxpr commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2591490809 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to mostly meet the requirements, but is

[PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-14 Thread via GitHub
anchao opened a new pull request, #15551: URL: https://github.com/apache/nuttx/pull/15551 ## Summary 1. libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd These options are unistd-specific and should not be filesystem dependent, and also not suitable for use in

(nuttx) branch master updated (b629daf61c -> 007a3fffac)

2025-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b629daf61c tools/refresh.sh: Add log for progress add 007a3fffac Use small lock to protect usbdev and endpoint

Re: [PR] Use small lock to protect usbdev and endpoint in AVR. [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #15547: URL: https://github.com/apache/nuttx/pull/15547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #15550: URL: https://github.com/apache/nuttx/pull/15550#discussion_r1915845692 ## arch/arm/src/armv7-r/arm_syscall.c: ## @@ -258,6 +258,7 @@ uint32_t *arm_syscall(uint32_t *regs) rtcb->flags &= ~TCB_FLAG_SYSCALL;

Re: [PR] Use small lock to protect usbdev and endpoint in mips. [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #15548: URL: https://github.com/apache/nuttx/pull/15548#discussion_r1915836655 ## arch/mips/src/pic32mx/pic32mx_usbdev.c: ## @@ -4383,7 +4401,8 @@ void mips_usbuninitialize(void) struct pic32mx_usbdev_s *priv = &g_usbdev; irqstate_t flags;

Re: [PR] risc-v: Accelerate schedule by percpu [nuttx]

2025-01-14 Thread via GitHub
no1wudi closed pull request #15081: risc-v: Accelerate schedule by percpu URL: https://github.com/apache/nuttx/pull/15081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] risc-v: Accelerate schedule by percpu [nuttx]

2025-01-14 Thread via GitHub
no1wudi commented on PR #15081: URL: https://github.com/apache/nuttx/pull/15081#issuecomment-2591433584 Use tp register should be better, let's track it by a new PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-14 Thread via GitHub
hujun260 opened a new pull request, #15550: URL: https://github.com/apache/nuttx/pull/15550 ## Summary armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 reason: In kernel mode, sighand_test() may failed. because nxsig_unmask_pendingsignal may change

Re: [PR] wqueue remove enter_critical_section [nuttx]

2025-01-14 Thread via GitHub
hujun260 commented on code in PR #14623: URL: https://github.com/apache/nuttx/pull/14623#discussion_r1915811893 ## sched/wqueue/kwork_notifier.c: ## @@ -160,23 +162,34 @@ static void work_notifier_worker(FAR void *arg) (FAR struct work_notifier_entry_s *)arg; irqstate_t

(nuttx-website) branch asf-site updated: Publishing web: c9485a98e52c59e17f5874dcfcda910d849854c2 docs: b629daf61c8a3f0391d75197a07a0c983a19cef2

2025-01-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e17430a4b Publishing web: c9485a9

(nuttx) branch master updated: tools/refresh.sh: Add log for progress

2025-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b629daf61c tools/refresh.sh: Add log for progr

Re: [PR] tools/refresh.sh: Add log for progress [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #15542: URL: https://github.com/apache/nuttx/pull/15542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx-apps) branch master updated: examples/rust: Rename hello_rust to rust/baremetal

2025-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 14fa7d272 examples/rust: Rename hello_rus

Re: [PR] examples/rust: Rename hello_rust to rust/baremetal [nuttx-apps]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #2944: URL: https://github.com/apache/nuttx-apps/pull/2944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Fix memory map for EMAC, ICACHE, and DCACHE. [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #15544: URL: https://github.com/apache/nuttx/pull/15544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] boards: Refresh configurations with refresh.sh [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #15539: URL: https://github.com/apache/nuttx/pull/15539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (f3b31ef1df -> aa24051628)

2025-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f3b31ef1df boards: Replace CONFIG_NSH_LINELEN with CONFIG_LINE_MAX add aa24051628 boards: Refresh configuration

(nuttx) branch master updated (d014867766 -> 9701b0f660)

2025-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d014867766 tools/refresh.sh: Should continue to refresh other configs when matching debug configs add 9701b0f6

Re: [PR] boards: Replace `CONFIG_NSH_LINELEN` with `CONFIG_LINE_MAX` [nuttx]

2025-01-14 Thread via GitHub
xiaoxiang781216 merged PR #15541: URL: https://github.com/apache/nuttx/pull/15541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Add GD55 QSPI NOR Flash support [nuttx]

2025-01-14 Thread via GitHub
TimJTi commented on code in PR #15523: URL: https://github.com/apache/nuttx/pull/15523#discussion_r1915120555 ## drivers/mtd/gd55.c: ## @@ -0,0 +1,2065 @@ +/ + * drivers/mtd/gd55.c + * + * Licensed to th

Re: [PR] Add GD55 QSPI NOR Flash support [nuttx]

2025-01-14 Thread via GitHub
TimJTi commented on code in PR #15523: URL: https://github.com/apache/nuttx/pull/15523#discussion_r1915107452 ## drivers/mtd/gd55.c: ## @@ -0,0 +1,2065 @@ +/ + * drivers/mtd/gd55.c + * + * Licensed to th

  1   2   3   >