xiaoxiang781216 commented on code in PR #15550:
URL: https://github.com/apache/nuttx/pull/15550#discussion_r1915845692
##########
arch/arm/src/armv7-r/arm_syscall.c:
##########
@@ -258,6 +258,7 @@ uint32_t *arm_syscall(uint32_t *regs)
rtcb->flags &= ~TCB_FLAG_SYSCALL;
nxsig_unmask_pendingsignal();
+ regs = tcb->xcp.regs;
Review Comment:
```suggestion
regs = tcb->xcp.regs;
```
##########
arch/arm/src/armv7-a/arm_syscall.c:
##########
@@ -261,6 +261,7 @@ uint32_t *arm_syscall(uint32_t *regs)
rtcb->flags &= ~TCB_FLAG_SYSCALL;
nxsig_unmask_pendingsignal();
+ regs = tcb->xcp.regs;
Review Comment:
why nxsig_unmask_pendingsignal change xcp.regs? the change of xcp.regs
should only happen in the irq entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
