xiaoxiang781216 commented on code in PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915891764
##########
arch/sim/src/sim/posix/sim_hostfs.c:
##########
@@ -299,7 +312,7 @@ void host_sync(int fd)
int host_dup(int fd)
{
- return dup(fd);
+ return host_errno_convert(dup(fd));
Review Comment:
ditto
##########
arch/sim/src/sim/posix/sim_hostfs.c:
##########
@@ -279,7 +292,7 @@ int host_ioctl(int fd, int request, unsigned long arg)
{
/* Just call the ioctl routine */
- return ioctl(fd, request, arg);
Review Comment:
need check the return value and get errno in failure case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
