Re: [PR] apps/testing: Add a cmocka framework for network testing [nuttx-apps]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #2935: URL: https://github.com/apache/nuttx-apps/pull/2935#issuecomment-2579370830 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR summary does not adequately meet the Nut

Re: [PR] drivers/serial/serial.c: adapt to the iovec-based api [nuttx]

2025-01-08 Thread via GitHub
yamt commented on PR #14898: URL: https://github.com/apache/nuttx/pull/14898#issuecomment-2579367743 rv-virt/citest64 failure looks like a stack overflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

(nuttx) branch master updated: Documentation: Add Rust integration guide for NuttX

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a8ba833cde Documentation: Add Rust integration

Re: [PR] Documentation: Add Rust integration guide for NuttX [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15476: URL: https://github.com/apache/nuttx/pull/15476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] apps/testing: Add a cmocka framework for network testing [nuttx-apps]

2025-01-08 Thread via GitHub
zs39 opened a new pull request, #2935: URL: https://github.com/apache/nuttx-apps/pull/2935 ## Summary Provides a network automated testing framework, including the main directory structure and Makefile, CMakeLists, Kconfig and other files such as tcp. ## Impact N/A ## Tes

[PR] cmake[enhance]:builtin register support NONE srcs target [nuttx-apps]

2025-01-08 Thread via GitHub
xuxin930 opened a new pull request, #2934: URL: https://github.com/apache/nuttx-apps/pull/2934 ## Summary Support `add_application` to register without compiling, used in scenarios where redefining the main symbol is not required ## Impact enhancement ## Testing

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579342644 @lupyuen Rust build with cmake need this PR: https://github.com/apache/nuttx-apps/pull/2478, but it has beed reverted: https://github.com/apache/nuttx-apps/pull/2480 Let's wait

Re: [PR] use small lock to protect g_ram_vectors [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15429: URL: https://github.com/apache/nuttx/pull/15429#discussion_r1908282087 ## arch/arm/src/armv8-m/arm_ramvec_attach.c: ## @@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector) * common exception handler. */

Re: [PR] use small lock to protect register about l2cc in arch "arm" [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15430: URL: https://github.com/apache/nuttx/pull/15430#discussion_r1908277187 ## arch/arm/src/armv7-a/arm_l2cc_pl310.c: ## @@ -229,6 +230,8 @@ * Private Functions ***

Re: [PR] use small lock to protect register about l2cc in arch "arm" [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15430: URL: https://github.com/apache/nuttx/pull/15430#discussion_r1908276947 ## arch/arm/src/armv7-r/arm_l2cc_pl310.c: ## @@ -491,15 +494,28 @@ void l2cc_disable(void) /* Flush all ways using the Clean Invalidate Way Register (CIWR). */

Re: [PR] use small lock to protect register about l2cc in arch "arm" [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15430: URL: https://github.com/apache/nuttx/pull/15430#discussion_r1908276162 ## arch/arm/src/armv7-r/arm_l2cc_pl310.c: ## @@ -491,15 +494,28 @@ void l2cc_disable(void) /* Flush all ways using the Clean Invalidate Way Register (CIWR). */

Re: [PR] use small lock in following files [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art closed pull request #15426: use small lock in following files URL: https://github.com/apache/nuttx/pull/15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] use small lock to protect g_ram_vectors [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15429: URL: https://github.com/apache/nuttx/pull/15429#discussion_r1908226239 ## arch/arm/src/armv6-m/arm_ramvec_attach.c: ## @@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector) * common exception handler. */

Re: [PR] use small lock to protect g_ram_vectors [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15429: URL: https://github.com/apache/nuttx/pull/15429#discussion_r1908225459 ## arch/arm/src/armv8-m/arm_ramvec_attach.c: ## @@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector) * common exception handler. */

Re: [PR] use small lock to protect g_ram_vectors [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15429: URL: https://github.com/apache/nuttx/pull/15429#discussion_r1908225669 ## arch/arm/src/armv7-m/arm_ramvec_attach.c: ## @@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector) * common exception handler. */

Re: [PR] mm: make the alignment length in mm consistent with Kasan [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 commented on code in PR #15397: URL: https://github.com/apache/nuttx/pull/15397#discussion_r1908202218 ## mm/mm_heap/mm.h: ## @@ -173,7 +173,12 @@ typedef size_t mmsize_t; struct mm_allocnode_s { - mmsize_t preceding; /* Physical preced

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579167561 > Sorry @no1wudi why is `hello_rust_cargo` missing from the NuttX Image? https://gist.github.com/lupyuen/b81596576e393be0abac2b7687740052#file-gistfile1-txt-L870 > > ``` > $ c

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579146693 @lupyuen Please try build with make for now, I'll look into the issue with cmake first. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] mte/kasan: Implementing KASAN memory protection for ARM64 hardware MTE [nuttx]

2025-01-08 Thread via GitHub
W-M-R commented on code in PR #15461: URL: https://github.com/apache/nuttx/pull/15461#discussion_r1908139678 ## mm/mm_heap/mm_initialize.c: ## @@ -209,6 +211,7 @@ void mm_addregion(FAR struct mm_heap_s *heap, FAR void *heapstart, sched_note_heap(NOTE_HEAP_ADD, heap, heapstar

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
lupyuen commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579136744 https://gist.github.com/lupyuen/b81596576e393be0abac2b7687740052#file-gistfile1-txt-L870 Sorry @no1wudi why is `hello_rust_cargo` missing from the NuttX Image? ```text $ cmake

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579119138 @lupyuen I had submitted a fix for this issue: https://github.com/rust-lang/libc/pull/4222 For now, please modify the file, add a force cast locally /home/luppy/.rustup/toolchai

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
lupyuen commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579108920 @no1wudi Sorry did I miss something? This is for Ubuntu 24.04.1 LTS x86_64: https://gist.github.com/lupyuen/b81596576e393be0abac2b7687740052 ```bash $ rustup toolchain install n

Re: [PR] net/tcp_timer: remove tcp_callback(TIMEOUT) when accept conn timeout [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15477: URL: https://github.com/apache/nuttx/pull/15477#issuecomment-2579093272 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description **does not fully meet the NuttX req

[PR] net/tcp_timer: remove tcp_callback(TIMEOUT) when accept conn timeout [nuttx]

2025-01-08 Thread via GitHub
zhhyu7 opened a new pull request, #15477: URL: https://github.com/apache/nuttx/pull/15477 ## Summary when accept conn timeout, only accept conn itself should handle the event (send TCP_RESET), and there is no need to notify the listening conn. otherwise, the server's poll will return wit

Re: [PR] Documentation: Add Rust integration guide for NuttX [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15476: URL: https://github.com/apache/nuttx/pull/15476#issuecomment-2579079495 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR, as described, lacks several key pieces of i

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579071008 @lvanasse @lupyuen Please refer to this document to test it: https://github.com/apache/nuttx/pull/15476 😄 -- This is an automated message from the Apache Git Service. To respond to

[PR] Documentation: Add Rust integration guide for NuttX [nuttx]

2025-01-08 Thread via GitHub
no1wudi opened a new pull request, #15476: URL: https://github.com/apache/nuttx/pull/15476 ## Summary Add a new guide documenting how to integrate Rust with NuttX, including: - Prerequisites and supported platforms - Setup instructions for Rust toolchain - Required NuttX c

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15475: URL: https://github.com/apache/nuttx/pull/15475#issuecomment-2579052435 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] add the stm32g4 series spi [nuttx]

2025-01-08 Thread via GitHub
JerrySlhao commented on code in PR #15459: URL: https://github.com/apache/nuttx/pull/15459#discussion_r1908076946 ## arch/arm/src/stm32/stm32_spi.c: ## @@ -1512,7 +1517,7 @@ static void spi_setbits(struct spi_dev_s *dev, int nbits) if (nbits != priv->nbits) { -#if defi

Re: [PR] use small lock in following files [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15426: URL: https://github.com/apache/nuttx/pull/15426#discussion_r1908076575 ## arch/arm/src/am335x/am335x_serial.c: ## @@ -76,13 +77,14 @@ struct up_dev_s { - uint32_t uartbase; /* Base address of UART registers */ - uint32_t baud;

Re: [PR] use small lock in following files [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15426: URL: https://github.com/apache/nuttx/pull/15426#discussion_r1908076456 ## arch/arm/src/am335x/am335x_serial.c: ## @@ -1204,7 +1216,7 @@ static void up_txint(struct uart_dev_s *dev, bool enable) struct up_dev_s *priv = (struct up_dev

[PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-08 Thread via GitHub
no1wudi opened a new pull request, #15475: URL: https://github.com/apache/nuttx/pull/15475 ## Summary - Replace direct string comparisons with regex pattern matching for ARCHCPUEXTFLAGS - Change from using LLVM_CPUFLAGS list to setting LLVM_CPUTYPE directly - Simplify CPU ty

Re: [PR] Remove duplicate includes across multiple files [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15474: URL: https://github.com/apache/nuttx/pull/15474#issuecomment-2579039233 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] use small lock in following files [nuttx]

2025-01-08 Thread via GitHub
wangzhi-art commented on code in PR #15426: URL: https://github.com/apache/nuttx/pull/15426#discussion_r1908072236 ## arch/arm/src/am335x/am335x_serial.c: ## @@ -76,13 +77,14 @@ struct up_dev_s { - uint32_t uartbase; /* Base address of UART registers */ - uint32_t baud;

[PR] Remove duplicate includes across multiple files [nuttx]

2025-01-08 Thread via GitHub
no1wudi opened a new pull request, #15474: URL: https://github.com/apache/nuttx/pull/15474 ## Summary This commit cleans up redundant header file includes throughout the codebase. The changes include: - Removing duplicate #include directives that were present in the sa

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2579022602 @lvanasse Thank you for offering your help. Regarding your questions, here's the current situation: > Do we use a specific crate to interact with NuttX? For instance, how should

(nuttx-website) branch asf-site updated: Publishing web: c9485a98e52c59e17f5874dcfcda910d849854c2 docs: cb980cc9776f865b88268936a3a1d1fc525eddac

2025-01-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a4d100103 Publishing web: c9485a9

Re: [PR] mte/kasan: Implementing KASAN memory protection for ARM64 hardware MTE [nuttx]

2025-01-08 Thread via GitHub
anchao commented on code in PR #15461: URL: https://github.com/apache/nuttx/pull/15461#discussion_r1907990997 ## mm/kasan/mte_tags.c: ## @@ -0,0 +1,95 @@ +/ + * mm/kasan/mte_tags.c + * + * Licensed to th

(nuttx) branch master updated: arch/arm/stm32{|f0l0g0|f7|h5|h7}/i2c: raise compilation error when configuration is invalid

2025-01-08 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b3120e535b arch/arm/stm32{|f0l0g0|f7|h5|h7}/i2c:

(nuttx) branch master updated: arch/esp32s3_partition: Read data from SPI Flash at designated address (with decryption)

2025-01-08 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new cb980cc977 arch/esp32s3_partition: Read data from

Re: [PR] arch/esp32s3_partition: Read data from SPI Flash with decryption [nuttx]

2025-01-08 Thread via GitHub
anchao merged PR #15470: URL: https://github.com/apache/nuttx/pull/15470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] arch/arm/stm32/i2c: raise compilation error when configuration is invalid [nuttx]

2025-01-08 Thread via GitHub
anchao merged PR #15473: URL: https://github.com/apache/nuttx/pull/15473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] examples: add blecent and bleprph similar to mynewt-nimble apps [nuttx-apps]

2025-01-08 Thread via GitHub
maxikrie commented on code in PR #2807: URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1907876555 ## examples/nimble_blecent/Kconfig: ## @@ -0,0 +1,30 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in th

Re: [PR] arch/arm/stm32/i2c: raise compilation error when configuration is invalid [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15473: URL: https://github.com/apache/nuttx/pull/15473#issuecomment-2578105837 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requiremen

[PR] arch/arm/stm32: raise compilation error when configuration is invalid [nuttx]

2025-01-08 Thread via GitHub
raiden00pl opened a new pull request, #15473: URL: https://github.com/apache/nuttx/pull/15473 ## Summary Raise compilation error when I2C configuration is invalid. It's better to catch invalid clock configuration during compilation instead of producing binary that doesn't work as exp

Re: [PR] Reimplement readv to deal with short reads [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 commented on PR #12674: URL: https://github.com/apache/nuttx/pull/12674#issuecomment-2578043905 should we close this pr without merging? @yamt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Revert "mm_heap: double malloced memory default alignment (4 -> 8, 8 -> 16)" [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15462: URL: https://github.com/apache/nuttx/pull/15462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (00794b92c4 -> 11d54b34a7)

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 00794b92c4 arch/risc-v: Improve LLVM CPU type detection with findstring add 11d54b34a7 Revert "mm_heap: double

(nuttx) branch master updated (ae9815a888 -> 00794b92c4)

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ae9815a888 riscv_cpustart.c: Change CPU start related traces to sinfo add 00794b92c4 arch/risc-v: Improve LLVM

Re: [PR] arch/risc-v: Improve LLVM CPU type detection with findstring [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15469: URL: https://github.com/apache/nuttx/pull/15469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (c0eaf12661 -> ae9815a888)

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c0eaf12661 esp32s3_wifi_adapter.c: Fix a deadlock add ae9815a888 riscv_cpustart.c: Change CPU start related tra

Re: [PR] riscv_cpustart.c: Change CPU start related traces to sinfo [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15467: URL: https://github.com/apache/nuttx/pull/15467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (8282ed9ab0 -> c0eaf12661)

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 8282ed9ab0 drivers/sensors/gnss: Macro `UINT8_MAX` for maximum value of `uint8_t crefs` add c0eaf12661 esp32s3

Re: [I] [BUG] esp32s3 wifi deadlock [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 closed issue #15314: [BUG] esp32s3 wifi deadlock URL: https://github.com/apache/nuttx/issues/15314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] [BUG] esp32s3 wifi deadlock [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 closed issue #15314: [BUG] esp32s3 wifi deadlock URL: https://github.com/apache/nuttx/issues/15314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15445: URL: https://github.com/apache/nuttx/pull/15445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] The placement of cases under testing is a bit messy, and cases of the same type need to be merged [nuttx-apps]

2025-01-08 Thread via GitHub
raiden00pl commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2578026481 this page in the doc should be updated according to this PR https://nuttx.apache.org/docs/latest/applications/testing/index.html -- This is an automated message from the Apache Gi

Re: [PR] Initial STM32H5 Timers Commit [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15472: URL: https://github.com/apache/nuttx/pull/15472#issuecomment-2578009951 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR mostly meets the NuttX requirements, but c

[PR] Initial STM32H5 Timers Commit [nuttx]

2025-01-08 Thread via GitHub
kywwilson11 opened a new pull request, #15472: URL: https://github.com/apache/nuttx/pull/15472 ## Summary Initial STM32H5 timers driver. This driver used the STM32H7 as a reference as the timers are very similar. stm32h5xx_rcc.c was modified to remove enabling of timers. This functio

Re: [PR] The placement of cases under testing is a bit messy, and cases of the same type need to be merged [nuttx-apps]

2025-01-08 Thread via GitHub
GUIDINGLI commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2577992183 > Thank you @txy-21 good idea, it should keep things clean, on the other hand folks may search for existing tests in subdirectories :-P PR needs a rebase. Then we can see the CI buil

Re: [PR] Remove duplicate code [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15471: URL: https://github.com/apache/nuttx/pull/15471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] drivers/sensors/gnss: Macro `UINT8_MAX` for maximum value of `uint8_t crefs` [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15468: URL: https://github.com/apache/nuttx/pull/15468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (428c2bfb91 -> 8282ed9ab0)

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 428c2bfb91 Remove duplicate code add 8282ed9ab0 drivers/sensors/gnss: Macro `UINT8_MAX` for maximum value of `

(nuttx) branch master updated: Remove duplicate code

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 428c2bfb91 Remove duplicate code 428c2bfb91 is

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
lvanasse commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2577743328 Hi @no1wudi, I'm really looking forward to this PR—great job! I’d be happy to help if you need an extra hand, especially with documentation. I do have a few questions, an

Re: [PR] add the stm32g4 series spi [nuttx]

2025-01-08 Thread via GitHub
raiden00pl commented on code in PR #15459: URL: https://github.com/apache/nuttx/pull/15459#discussion_r1907169727 ## arch/arm/src/stm32/stm32_spi.c: ## @@ -1512,7 +1517,7 @@ static void spi_setbits(struct spi_dev_s *dev, int nbits) if (nbits != priv->nbits) { -#if defi

(nuttx) branch master updated: sim:citest: Bump the nsh line length

2025-01-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0b960de1e0 sim:citest: Bump the nsh line lengt

Re: [PR] sim:citest: Bump the nsh line length [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15463: URL: https://github.com/apache/nuttx/pull/15463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [I] [BUG] ESP32C6 DEV Kit M/C Gpio issue [nuttx]

2025-01-08 Thread via GitHub
FelipeMdeO commented on issue #15456: URL: https://github.com/apache/nuttx/issues/15456#issuecomment-2577561271 Hello @eren-terzioglu, The issue happen in gpio 4 too. ![image](https://github.com/user-attachments/assets/4cc7cd5a-bc0d-406f-b846-828c08d54972) -- This is an aut

[PR] Remove duplicate code [nuttx]

2025-01-08 Thread via GitHub
hujun260 opened a new pull request, #15471: URL: https://github.com/apache/nuttx/pull/15471 ## Summary Remove duplicate code ## Impact none ## Testing ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(nuttx) branch master updated: arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP

2025-01-08 Thread pussuw
This is an automated email from the ASF dual-hosted git repository. pussuw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 40bd8f9ad4 arch/risc-v: Make CPU index handling b

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw merged PR #15396: URL: https://github.com/apache/nuttx/pull/15396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] arch/esp32s3_partition: Read data from SPI Flash with decryption [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15470: URL: https://github.com/apache/nuttx/pull/15470#issuecomment-2577464980 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to mostly meet the NuttX requirements,

Re: [PR] use small lock to protect register about l2cc in arch "arm" [nuttx]

2025-01-08 Thread via GitHub
hujun260 commented on code in PR #15430: URL: https://github.com/apache/nuttx/pull/15430#discussion_r1907041631 ## arch/arm/src/armv7-r/arm_l2cc_pl310.c: ## @@ -491,15 +494,28 @@ void l2cc_disable(void) /* Flush all ways using the Clean Invalidate Way Register (CIWR). */

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
yamt commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2577445871 > Yes, every test runs with debug assertion enabled. ok. thank you. i now dropped the assertion patch from this PR. -- This is an automated message from the Apache Git Service. To

[PR] arch/esp32s3_partition: Read data from SPI Flash with decryption [nuttx]

2025-01-08 Thread via GitHub
nuttxs opened a new pull request, #15470: URL: https://github.com/apache/nuttx/pull/15470 ## Summary arch/esp32s3_partition: Read data from SPI Flash at designated address (with decryption) ## Impact esp32s3 add read partition interface with decryption ## Testing nsh> tc_

Re: [PR] arch/risc-v: Improve LLVM CPU type detection with findstring [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15469: URL: https://github.com/apache/nuttx/pull/15469#issuecomment-2577438310 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] arch/risc-v: Improve LLVM CPU type detection with findstring [nuttx]

2025-01-08 Thread via GitHub
no1wudi opened a new pull request, #15469: URL: https://github.com/apache/nuttx/pull/15469 ## Summary Use findstring instead of direct equality checks for LLVM_CPUTYPE conditions to better handle ARCHCPUEXTFLAGS that may contain additional ISA extensions. This makes the CPU type

Re: [I] [FEATURE] Python on NuttX: known issues, "TO-DO" list, and general enhancements [nuttx-apps]

2025-01-08 Thread via GitHub
tmedicci commented on issue #2884: URL: https://github.com/apache/nuttx-apps/issues/2884#issuecomment-2577420747 Hi, I prepared an article with the technical details of the implementation in my blog. You can check it at: https://tmedicci.github.io/articles/2025/01/08/python_on_nuttx.h

Re: [PR] arch/esp32s3_wdt: ESP32-S3 WDT1 clock init [nuttx]

2025-01-08 Thread via GitHub
eren-terzioglu commented on PR #15434: URL: https://github.com/apache/nuttx/pull/15434#issuecomment-2577360923 > > Could you give some information about your tests to reproduce the issue? We can test it for other chips to have better support about WDTs. > > Hi @eren-terzioglu We inter

[PR] drivers/sensors/gnss: Macro `UINT8_MAX` for maximum value of `uint8_t crefs` [nuttx]

2025-01-08 Thread via GitHub
JianyuWang0623 opened a new pull request, #15468: URL: https://github.com/apache/nuttx/pull/15468 ## Summary drivers/sensors/gnss: Macro `UINT8_MAX` for maximum value of `uint8_t crefs` libs/libc/gnssutils/minmea/minmea.h:17:#include ## Impact drivers/sensors/gnss ## T

Re: [PR] xtensa/esp32s3: Add USB OTG device driver [nuttx]

2025-01-08 Thread via GitHub
fdcavalcanti commented on PR #9525: URL: https://github.com/apache/nuttx/pull/9525#issuecomment-2577352118 Ah I see. I was running the `usbnsh` instead of the `usb_device` defconfig that you used. I misread the defconfig of this PR. Sorry about that, but thanks for testing anyway! -

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
fdcavalcanti commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2577332380 Yes, every test runs with debug assertion enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] riscv_cpustart.c: Change CPU start related traces to sinfo [nuttx]

2025-01-08 Thread via GitHub
pussuw opened a new pull request, #15467: URL: https://github.com/apache/nuttx/pull/15467 ## Summary Do the trace like all other platforms do. Motivation is to remove useless traces from boot process, unless the user explicitly asks for such (schedule related) traces. ## Impac

Re: [I] Simplify PWM driver: remove CONFIG_PWM_MULTICHAN [nuttx]

2025-01-08 Thread via GitHub
michallenc commented on issue #15436: URL: https://github.com/apache/nuttx/issues/15436#issuecomment-2577299327 Hi all, just please note that this might be a breaking API change, since it is safe to assume applications are using `CONFIG_PWM_MULTICHAN` to determine how to access `pwm_info_s`

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2577287954 > I guess in flat mode you could read hartid from CSR mhartid even if CONFIG_RISCV_PERCPU_SCRATCH is enabled.. Sure, let's add more detail for riscv_mhartid -- This is an

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw commented on code in PR #15396: URL: https://github.com/apache/nuttx/pull/15396#discussion_r1906933501 ## arch/risc-v/Kconfig: ## @@ -461,19 +461,51 @@ config ARCH_RV_MMIO_BITS default 32 if ARCH_RV32 default 64 if ARCH_RV64 +config ARCH_RV_CPUID_MAP +

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2577275914 > BTW, the naming of the function riscv_mhartid is highly misleading. Literally, it appears to be a simple wrapper for CSR_MHARTID, but in reality, under CONFIG_RISCV_PERCPU_SCRATCH, it re

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2577267870 @lupyuen I'll perpare a doc for it soon 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2577260867 The naming of the function riscv_mhartid is highly misleading. Literally, it appears to be a simple wrapper for CSR_MHARTID, but in reality, under CONFIG_RISCV_PERCPU_SCRATCH, it reads th

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw commented on code in PR #15396: URL: https://github.com/apache/nuttx/pull/15396#discussion_r1906913753 ## arch/risc-v/Kconfig: ## @@ -461,19 +461,51 @@ config ARCH_RV_MMIO_BITS default 32 if ARCH_RV32 default 64 if ARCH_RV64 +config ARCH_RV_CPUID_MAP +

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
lupyuen commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2577242902 @no1wudi Thanks for the great job! What command shall I run to build this for QEMU RISC-V 64-bit? Might be good to include some minimal docs for this release thanks :-) -- This is a

Re: [I] [BUG] at32f437-mini/systemview: builds fail with error: implicit declaration of function 'SEGGER_RTT_LOCK' [nuttx]

2025-01-08 Thread via GitHub
lupyuen commented on issue #15451: URL: https://github.com/apache/nuttx/issues/15451#issuecomment-2577224919 > I think that we should switch the CI to manual for the release branch and do a full build on all targets manually Sorry @jerpelea by "building manually", do you mean running

Re: [PR] drivers/serial/serial.c: adapt to the iovec-based api [nuttx]

2025-01-08 Thread via GitHub
yamt commented on PR #14898: URL: https://github.com/apache/nuttx/pull/14898#issuecomment-2577192158 > a reminder to myself: i have to look at the ci failure. it was because of a wrong assertion. i removed the assertion. -- This is an automated message from the Apache Git Service. T

Re: [I] [BUG] at32f437-mini/systemview: builds fail with error: implicit declaration of function 'SEGGER_RTT_LOCK' [nuttx]

2025-01-08 Thread via GitHub
jerpelea commented on issue #15451: URL: https://github.com/apache/nuttx/issues/15451#issuecomment-2577155718 @Lup I think that we should switch the CI to manual for the release branch and do a full build on all targets manually Bets regards Alin _

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on code in PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#discussion_r1906711613 ## examples/hello_rust_cargo/CMakeLists.txt: ## @@ -0,0 +1,63 @@ +# ## +# apps/examples/

Re: [PR] examples: New app to build Rust with Cargo [nuttx-apps]

2025-01-08 Thread via GitHub
no1wudi commented on code in PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#discussion_r1906714934 ## examples/hello_rust_cargo/Makefile: ## @@ -0,0 +1,32 @@ + +# apps/examples/hello_rust/

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2577037867 > @pussuw could you give the concrete return value from up_cpud_index and up_this_cpu on your platform? I need the conversion functions as well, because in mpfs_start we need to do

Re: [I] Simplify PWM driver: remove CONFIG_PWM_MULTICHAN [nuttx]

2025-01-08 Thread via GitHub
raiden00pl commented on issue #15436: URL: https://github.com/apache/nuttx/issues/15436#issuecomment-2577053009 @acassis multichan PWM was added lng time ago in e8c2466c1cecf22035976a2dd577dfc67f9ea373. I have no idea why it was done this way, but I think it can be done better by avo

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_CPUID_MAP [nuttx]

2025-01-08 Thread via GitHub
pussuw commented on code in PR #15396: URL: https://github.com/apache/nuttx/pull/15396#discussion_r1906699633 ## arch/risc-v/src/common/riscv_internal.h: ## @@ -356,40 +356,24 @@ void riscv_cpu_boot(int cpu); int riscv_smp_call_handler(int irq, void *c, void *arg); #endif +#

  1   2   >