wangzhi-art commented on code in PR #15429:
URL: https://github.com/apache/nuttx/pull/15429#discussion_r1908226239
##########
arch/arm/src/armv6-m/arm_ramvec_attach.c:
##########
@@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
* common exception handler.
*/
- flags = enter_critical_section();
+ flags = spin_lock_irqsave(&g_ramvec_lock);
Review Comment:
> move to line 88
We need to disable interrupts before calling up_disable_irq(), so also need
to put it before the up_disable_irq() function.
##########
arch/arm/src/armv8-m/arm_ramvec_attach.c:
##########
@@ -68,7 +68,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
* common exception handler.
*/
- flags = enter_critical_section();
+ flags = spin_lock_irqsave(&g_ramvec_lock);
Review Comment:
> move to line 88
We need to disable interrupts before calling up_disable_irq(), so also need
to put it before the up_disable_irq() function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
