[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #2786: arch/risc-v/src/rv32im/riscv_syscall.S have bogus nops

2022-11-16 Thread GitBox
xiaoxiang781216 closed issue #2786: arch/risc-v/src/rv32im/riscv_syscall.S have bogus nops URL: https://github.com/apache/incubator-nuttx/issues/2786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2786: arch/risc-v/src/rv32im/riscv_syscall.S have bogus nops

2022-11-16 Thread GitBox
xiaoxiang781216 commented on issue #2786: URL: https://github.com/apache/incubator-nuttx/issues/2786#issuecomment-1318145234 Fixed by the recent risc-v refinement. Let's close it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #3216: CI: functional tests using sim

2022-11-16 Thread GitBox
xiaoxiang781216 closed issue #3216: CI: functional tests using sim URL: https://github.com/apache/incubator-nuttx/issues/3216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #3216: CI: functional tests using sim

2022-11-16 Thread GitBox
xiaoxiang781216 commented on issue #3216: URL: https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-1318141978 The basic test is added by https://github.com/apache/incubator-nuttx/pull/7109. Let's close this issue. -- This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

2022-11-16 Thread GitBox
xiaoxiang781216 commented on PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#issuecomment-1318109996 @masayuki2009 @pkarashchenko this patchset try to extract the common operation from arch to sched which: 1. Avoid the same logic duplicate in each arch 2. Improve

[incubator-nuttx-apps] branch master updated (7b22525f0 -> 0357cb99b)

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 7b22525f0 boot/mcuboot: Bump up version to 36bac4f6a54a3b76266444d8c6c177b8b0483a05 new 31e7c5e

[incubator-nuttx-apps] 02/02: interpreters/wamr: New option to support spec test

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 0357cb99b2fd1a056e40630782dbd273d3ac3036 Author: Huang Qi AuthorDate: Wed Nov 16 16:02:26 2022 +0800

[incubator-nuttx-apps] 01/02: interpreters/wamr: New option to support ref types

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 31e7c5ec6028e37c29b10273ffa26d26ef9e09dc Author: Huang Qi AuthorDate: Wed Nov 16 15:56:20 2022 +0800

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1421: interpreters/wamr: New option to support ref types

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #1421: URL: https://github.com/apache/incubator-nuttx-apps/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7609: driver/mtd: add support for mx25l16 serial flash

2022-11-16 Thread GitBox
pkarashchenko merged PR #7609: URL: https://github.com/apache/incubator-nuttx/pull/7609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated: driver/mtd: add support for mx25l16 serial flash

2022-11-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5a367ad59d driver/mtd: add suppo

[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7610: arch: rename arch special function name

2022-11-16 Thread GitBox
zyfeier opened a new pull request, #7610: URL: https://github.com/apache/incubator-nuttx/pull/7610 ## Summary Rename arch special function name to arch_x.c ## Impact NA ## Testing sim:nsh -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx] Fanhang32 opened a new pull request, #7609: driver/mtd: add support for mx25l16 serial flash

2022-11-16 Thread GitBox
Fanhang32 opened a new pull request, #7609: URL: https://github.com/apache/incubator-nuttx/pull/7609 ## Summary add support for mx25l16 serial flash ## Impact None ## Testing local test pass ``` [01/01/70 00:00:00.12] mx25l_readid: manufacturer: c2 memory: 20

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] 02/04: riscv/addrenv: Make private function get_pgtable into a public one

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 85470adcc3283113ca35e922631e474f5ce3cda7 Author: Ville Juven AuthorDate: Wed Nov 16 14:32:07 2022 +0200

[incubator-nuttx] 03/04: riscv/mmu: Implement mmu_ln_clear

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5c29042ab4b673319f7bc717be2dd55e68f88b57 Author: Ville Juven AuthorDate: Wed Nov 16 14:34:43 2022 +0200

[incubator-nuttx] 04/04: riscv/addrenv: Implement up_shmat/shmdt for RISC-V

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 596ce5e7b122cafeedbc990646667a4f62d78364 Author: Ville Juven AuthorDate: Wed Nov 16 14:38:53 2022 +0200

[incubator-nuttx] 01/04: mm/shm: Fix several build errors with shm due to missing headers

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 192a639f8f6785b66d80aeea90e5950e5a5b263c Author: Ville Juven AuthorDate: Wed Nov 16 14:30:18 2022 +0200

[incubator-nuttx] branch master updated (e047ca6011 -> 596ce5e7b1)

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from e047ca6011 Fix arch/arm/src/samv7/sam_pwm.c:489:1: error: Missing blank line after comment new 192a6

[incubator-nuttx-website] branch asf-site updated: Publishing web: 24c81cd558a7579a161cc49875837b86fad73b4d docs: e047ca60113def7fe4c0925279c724df9861d527

2022-11-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e1f2e849 Publishing web

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
pkarashchenko commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024604426 ## arch/arm/src/sama5/Kconfig: ## @@ -3712,6 +3722,17 @@ config SAMA5_ADC_TIOA_BOTH endchoice # ADTRG edge endif # SAMA5_ADC_TIOATRIG + +if SAMA5_ADC_

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

2022-11-16 Thread GitBox
pkarashchenko commented on PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#issuecomment-1317797613 ``` Configuration/Tool: ea3131/pgnsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
TimJTi commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024470944 ## arch/arm/src/sama5/Kconfig: ## @@ -3615,6 +3615,16 @@ config SAMA5_ADC_SWTRIG ---help--- A-to-D Conversion is initiated only by softwa

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
TimJTi commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024439051 ## arch/arm/src/sama5/Kconfig: ## @@ -3615,6 +3615,16 @@ config SAMA5_ADC_SWTRIG ---help--- A-to-D Conversion is initiated only by softwa

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024433327 ## arch/arm/src/sama5/Kconfig: ## @@ -3615,6 +3615,16 @@ config SAMA5_ADC_SWTRIG ---help--- A-to-D Conversion is initiated only

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7584: boards/cxd56xx/spresense: add fs automount driver for SD Card

2022-11-16 Thread GitBox
pkarashchenko commented on PR #7584: URL: https://github.com/apache/incubator-nuttx/pull/7584#issuecomment-1317507335 @SPRESENSE have you had a chance to try this changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
pussuw commented on code in PR #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024356378 ## mm/shm/shm_initialize.c: ## @@ -25,6 +25,7 @@ #include #include +#include Review Comment: This: https://github.com/apache/incubator-nuttx/blob/

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
TimJTi commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024315117 ## arch/arm/src/sama5/Kconfig: ## @@ -3615,6 +3615,16 @@ config SAMA5_ADC_SWTRIG ---help--- A-to-D Conversion is initiated only by softwa

[incubator-nuttx] branch master updated (7bf1aed08b -> e047ca6011)

2022-11-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 7bf1aed08b lpc31xx/ea3131/pgnsh: enable DEFAULT_SMALL to reducing the code size add e047ca6011 Fix arc

[GitHub] [incubator-nuttx] acassis merged pull request #7608: Fix arch/arm/src/samv7/sam_pwm.c:489:1: error: Missing blank line after comment

2022-11-16 Thread GitBox
acassis merged PR #7608: URL: https://github.com/apache/incubator-nuttx/pull/7608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024307976 ## arch/arm/src/sama5/sam_tsd.c: ## @@ -1655,7 +1735,11 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor) /* Initialize the touchscreen dev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024228939 ## arch/arm/src/sama5/sam_adc.c: ## @@ -497,20 +498,11 @@ static const struct adc_ops_s g_adcops = /* ADC internal state */ -static struct sam_adc_

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
TimJTi commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024261889 ## arch/arm/src/sama5/sam_tsd.c: ## @@ -1655,7 +1735,11 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor) /* Initialize the touchscreen device drive

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7599: nuttx/sched: remove nxsched_remove_blocked from up_unblock_task

2022-11-16 Thread GitBox
pkarashchenko commented on PR #7599: URL: https://github.com/apache/incubator-nuttx/pull/7599#issuecomment-1317336984 I need some more time to review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1419: apps: getpid should return process id not thread id

2022-11-16 Thread GitBox
pkarashchenko commented on code in PR #1419: URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#discussion_r1024258423 ## graphics/pdcurs34/nuttx/pdcthread.c: ## @@ -118,7 +118,7 @@ static FAR struct pdc_context_s *PDC_ctx_new(void) /* Get our PID */ Review Com

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024227768 ## arch/arm/src/sama5/sam_tsd.c: ## @@ -1655,7 +1735,11 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor) /* Initialize the touchscreen dev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024226745 ## arch/arm/src/sama5/sam_tsd.h: ## @@ -36,10 +36,15 @@ /* Configuration / -#ifdef CONF

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
hartmannathan commented on code in PR #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024226515 ## mm/shm/shm_initialize.c: ## @@ -25,6 +25,7 @@ #include #include +#include Review Comment: Interestingly I was getting an error for `minfo()`

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024224700 ## arch/arm/src/sama5/hardware/sam_adc.h: ## @@ -501,6 +523,12 @@ #define ADC_ACR_PENDETSENS_MASK(3 << ADC_ACR_PENDETSENS_SHIFT) # define ADC_ACR

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024224412 ## arch/arm/src/sama5/hardware/sam_adc.h: ## @@ -501,6 +523,12 @@ #define ADC_ACR_PENDETSENS_MASK(3 << ADC_ACR_PENDETSENS_SHIFT) # define ADC_ACR

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024223773 ## arch/arm/src/sama5/hardware/sam_adc.h: ## @@ -484,7 +501,12 @@ /* Channel Data Register */ #define ADC_CDR_DATA_SHIFT (0) /* Bits 0

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024223459 ## arch/arm/src/sama5/hardware/sam_adc.h: ## @@ -355,7 +368,11 @@ #define ADC_INT_NOPEN (1 << 30) /* Bit 30: No Pen Contact Interrupt */

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024223175 ## arch/arm/src/sama5/hardware/sam_adc.h: ## @@ -355,7 +368,11 @@ #define ADC_INT_NOPEN (1 << 30) /* Bit 30: No Pen Contact Interrupt */

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#issuecomment-1317281179 @TimJTi please squash your patch into one: ``` git rebase --interactive HEAD~3 change the last two pick to squash git push -f origin ``` -- This is an auto

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
xiaoxiang781216 commented on PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#issuecomment-1317278924 > first check fails with: > > [check: arch/arm/src/samv7/sam_pwm.c#L489] Missing blank line after comment > > Not even edited that file, and can't see anything

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7608: Fix arch/arm/src/samv7/sam_pwm.c:489:1: error: Missing blank line after comment

2022-11-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #7608: URL: https://github.com/apache/incubator-nuttx/pull/7608 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
pussuw commented on code in PR #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024198370 ## mm/shm/shm_initialize.c: ## @@ -25,6 +25,7 @@ #include #include +#include Review Comment: You get a link time error due to missing symbol for each

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7597: sched/task/task_getpid: getpid should return process id not thread id

2022-11-16 Thread GitBox
pkarashchenko commented on code in PR #7597: URL: https://github.com/apache/incubator-nuttx/pull/7597#discussion_r1024173978 ## drivers/syslog/vsyslog.c: ## @@ -157,7 +157,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #if defined(CONFIG_SYSLOG_PR

[incubator-nuttx] branch master updated: lpc31xx/ea3131/pgnsh: enable DEFAULT_SMALL to reducing the code size

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7bf1aed08b lpc31xx/ea3131/pgnsh: ena

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7604: lpc31xx/ea3131/pgnsh: enable DEFAULT_SMALL to reducing the code size

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #7604: URL: https://github.com/apache/incubator-nuttx/pull/7604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: mpfs_head.S: Mark .start section attributes explicitly

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 093760b48c mpfs_head.S: Mark .start

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7606: mpfs_head.S: Mark .start section attributes explicitly

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #7606: URL: https://github.com/apache/incubator-nuttx/pull/7606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] zouboan commented on a diff in pull request #1407: Fix various error in Windows native build

2022-11-16 Thread GitBox
zouboan commented on code in PR #1407: URL: https://github.com/apache/incubator-nuttx-apps/pull/1407#discussion_r1024159910 ## Directory.mk: ## @@ -22,11 +22,15 @@ include $(APPDIR)/Make.defs # Sub-directories that have been built or configured. -SUBDIRS := $(dir $(w

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
hartmannathan commented on code in PR #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024094235 ## mm/shm/shmat.c: ## @@ -26,6 +26,7 @@ #include #include +#include Review Comment: Ditto ## mm/shm/shm_initialize.c: ## @@

[GitHub] [incubator-nuttx-apps] hartmannathan commented on a diff in pull request #1407: Fix various error in Windows native build

2022-11-16 Thread GitBox
hartmannathan commented on code in PR #1407: URL: https://github.com/apache/incubator-nuttx-apps/pull/1407#discussion_r1024062479 ## Directory.mk: ## @@ -22,11 +22,15 @@ include $(APPDIR)/Make.defs # Sub-directories that have been built or configured. -SUBDIRS := $(d

[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1419: apps: getpid should return process id not thread id

2022-11-16 Thread GitBox
hartmannathan commented on PR #1419: URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#issuecomment-1317091900 Should we do something about the mixed case identifiers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx] TimJTi commented on pull request #7595: SAMA5Dx ADC and TSD fixes

2022-11-16 Thread GitBox
TimJTi commented on PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#issuecomment-1317072707 first check fails with: [check: arch/arm/src/samv7/sam_pwm.c#L489] Missing blank line after comment Not even edited that file, and can't see anything wrong with it a

[GitHub] [incubator-nuttx] pussuw opened a new pull request, #7607: mm/shm: Implement shmem drivers for risc-v target

2022-11-16 Thread GitBox
pussuw opened a new pull request, #7607: URL: https://github.com/apache/incubator-nuttx/pull/7607 ## Summary Implements up_shmat and up_shmdt for risc-v target ## Impact None, if CONFIG_MM_SHM is not enabled ## Testing icicle:knsh (example config file update will follow later)

[GitHub] [incubator-nuttx] pussuw opened a new pull request, #7606: mpfs_head.S: Mark .start section attributes explicitly

2022-11-16 Thread GitBox
pussuw opened a new pull request, #7606: URL: https://github.com/apache/incubator-nuttx/pull/7606 a = allocated, x = executable. Otherwise the input section type will become empty, which means output section will be empty as well. ## Summary Fixes issue when linking out-of-tree pro

[GitHub] [incubator-nuttx] robertalexa2000 commented on pull request #7466: drivers/sensors: add LTR308 ambient light sensor

2022-11-16 Thread GitBox
robertalexa2000 commented on PR #7466: URL: https://github.com/apache/incubator-nuttx/pull/7466#issuecomment-1316960398 > @robertalexa2000 Please follow the driver model in driver/sensors/sensor.c, you can write driver by refer to ’drivers/sensors/wtgahrs2.c‘. it will register character nod

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7605: sched/mqueue: make mqueue and mqueue sysv can disable separately

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #7605: URL: https://github.com/apache/incubator-nuttx/pull/7605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: sched/mqueue: make mqueue and mqueue sysv can disable separately

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new f27065cb9e sched/mqueue: make mqueue

[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7605: sched/mqueue: make mqueue and mqueue sysv can disable separately

2022-11-16 Thread GitBox
zyfeier opened a new pull request, #7605: URL: https://github.com/apache/incubator-nuttx/pull/7605 ## Summary Modify mqueue macro, to make sure mqueue and sysv can disable separately. ## Impact NA ## Testing sim:ostest -- This is an automated message

[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7604: lpc31xx/ea3131/pgnsh: enable DEFAULT_SMALL to reducing the code size

2022-11-16 Thread GitBox
zyfeier opened a new pull request, #7604: URL: https://github.com/apache/incubator-nuttx/pull/7604 ## Summary Enable DEFAULT_SMALL to reducing the code size ## Impact NA ## Testing ea3131/pgnsh -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx-apps] zouboan commented on a diff in pull request #1407: Fix various error in Windows native build

2022-11-16 Thread GitBox
zouboan commented on code in PR #1407: URL: https://github.com/apache/incubator-nuttx-apps/pull/1407#discussion_r1023740880 ## Makefile: ## @@ -21,6 +21,16 @@ export APPDIR = $(CURDIR) include $(APPDIR)/Make.defs +# The GNU make CURDIR will always be a POSIX-like path with

[incubator-nuttx] branch master updated: rpmsgdev: support blocked read/write operation

2022-11-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 162870b750 rpmsgdev: support blocked

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7603: rpmsgdev: support blocked read/write operation

2022-11-16 Thread GitBox
xiaoxiang781216 merged PR #7603: URL: https://github.com/apache/incubator-nuttx/pull/7603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] no1wudi commented on a diff in pull request #1421: interpreters/wamr: New option to support ref types

2022-11-16 Thread GitBox
no1wudi commented on code in PR #1421: URL: https://github.com/apache/incubator-nuttx-apps/pull/1421#discussion_r1023649761 ## interpreters/wamr/Kconfig: ## @@ -92,6 +92,14 @@ config INTERPRETERS_WAMR_MINILOADER ---help--- Mini-loader don't check the integrity o

[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1421: interpreters/wamr: New option to support ref types

2022-11-16 Thread GitBox
yamt commented on code in PR #1421: URL: https://github.com/apache/incubator-nuttx-apps/pull/1421#discussion_r1023645559 ## interpreters/wamr/Kconfig: ## @@ -92,6 +92,14 @@ config INTERPRETERS_WAMR_MINILOADER ---help--- Mini-loader don't check the integrity of w