xiaoxiang781216 commented on code in PR #7595: URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024223773
########## arch/arm/src/sama5/hardware/sam_adc.h: ########## @@ -484,7 +501,12 @@ /* Channel Data Register */ #define ADC_CDR_DATA_SHIFT (0) /* Bits 0-11: Converted Data */ + +#if defined (ATSAMA5D2) +#define ADC_CDR_DATA_MASK (0x3fff << ADC_CDR_DATA_SHIFT) Review Comment: ```suggestion # define ADC_CDR_DATA_MASK (0x3fff << ADC_CDR_DATA_SHIFT) ``` ########## arch/arm/src/sama5/hardware/sam_adc.h: ########## @@ -484,7 +501,12 @@ /* Channel Data Register */ #define ADC_CDR_DATA_SHIFT (0) /* Bits 0-11: Converted Data */ + +#if defined (ATSAMA5D2) +#define ADC_CDR_DATA_MASK (0x3fff << ADC_CDR_DATA_SHIFT) +#else #define ADC_CDR_DATA_MASK (0xfff << ADC_CDR_DATA_SHIFT) Review Comment: ```suggestion # define ADC_CDR_DATA_MASK (0xfff << ADC_CDR_DATA_SHIFT) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
