pkarashchenko commented on code in PR #7597:
URL: https://github.com/apache/incubator-nuttx/pull/7597#discussion_r1024173978
##########
drivers/syslog/vsyslog.c:
##########
@@ -157,7 +157,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR
va_list *ap)
#if defined(CONFIG_SYSLOG_PROCESSID)
/* Prepend the Process ID */
Review Comment:
```suggestion
/* Prepend the Thread ID */
```
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -1484,7 +1484,7 @@ static int proc_open(FAR struct file *filep, FAR const
char *relpath,
if (strncmp(relpath, "self", 4) == 0)
{
- tmp = (unsigned long)getpid(); /* Get the PID of the calling task */
+ tmp = (unsigned long)gettid(); /* Get the PID of the calling task */
Review Comment:
Please fix comment
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -2032,7 +2032,7 @@ static int proc_stat(const char *relpath, struct stat
*buf)
if (strncmp(relpath, "self", 4) == 0)
{
- tmp = (unsigned long)getpid(); /* Get the PID of the calling task */
+ tmp = (unsigned long)gettid(); /* Get the PID of the calling task */
Review Comment:
Ditto
##########
drivers/syslog/vsyslog.c:
##########
@@ -213,7 +213,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR
va_list *ap)
#if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_SYSLOG_PROCESS_NAME)
/* Prepend the process name */
Review Comment:
```suggestion
/* Prepend the thread name */
```
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -1792,7 +1792,7 @@ static int proc_opendir(FAR const char *relpath,
if (strncmp(relpath, "self", 4) == 0)
{
- tmp = (unsigned long)getpid(); /* Get the PID of the calling task */
+ tmp = (unsigned long)gettid(); /* Get the PID of the calling task */
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
