zouboan commented on code in PR #1407: URL: https://github.com/apache/incubator-nuttx-apps/pull/1407#discussion_r1024159910
########## Directory.mk: ########## @@ -22,11 +22,15 @@ include $(APPDIR)/Make.defs # Sub-directories that have been built or configured. -SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile)) -CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)Kconfig)),$(SUBDIRS)) -CLEANSUBDIRS += $(dir $(wildcard *$(DELIM).depend)) -CLEANSUBDIRS += $(dir $(wildcard *$(DELIM).kconfig)) +SUBDIRS := $(dir $(wildcard */Makefile)) Review Comment: > Is `$(DELIM)` obsolete? Do all operating systems (including Windows) recognize `/` delimiter now? Windows is not a POSIX environment, some makefile command was not support in Windows, As suggest in nuttx/README we use GnuWin32 to supply this windows version Makefile commad(for example: wildcard), some special cases we must use / rather than \ ,for here, we must use /, otherwise CONFIGSUBDIRS and CLEANSUBDIRS would be empty set in Windows native build, and will give fatal error, but use / we can build succesfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
