[GitHub] [incubator-nuttx] anchao opened a new pull request, #6524: wireless/bcm43xxx: replace private queue implement to list_node

anchao opened a new pull request, #6524: URL: https://github.com/apache/incubator-nuttx/pull/6524 ## Summary wireless/bcm43xxx: replace private queue implement to list_node ## Impact N/A ## Testing bcm43013 -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6523: wireless/bcm43xxx: remove unused tx_queue_count

anchao opened a new pull request, #6523: URL: https://github.com/apache/incubator-nuttx/pull/6523 ## Summary wireless/bcm43xxx: remove unused tx_queue_count ## Impact N/A ## Testing bcm43013 -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx-apps] normanr commented on a diff in pull request #904: netutils/dhcpc: add non-blocking interface

normanr commented on code in PR #904: URL: https://github.com/apache/incubator-nuttx-apps/pull/904#discussion_r906743256 ## netutils/dhcpc/dhcpc.c: ## @@ -445,6 +448,47 @@ static uint8_t dhcpc_parsemsg(FAR struct dhcpc_state_s *pdhcpc, int buflen, return 0; } +/*

[GitHub] [incubator-nuttx-apps] nimish commented on pull request #840: interpreters/micropython: Add Micropython support to NuttX (WIP)

nimish commented on PR #840: URL: https://github.com/apache/incubator-nuttx-apps/pull/840#issuecomment-1166390760 >nsh> upy >MicroPython v1.19.1-24-gffb0e674b-dirty on 2022-06-25; nuttx [GCC 11.2.1] version >Use Ctrl-D to exit, Ctrl-E for paste mode >hello Got it to work, wi

[incubator-nuttx-website] branch asf-site updated: Publishing web: 3c980bc717a3874c683a1bd2a48c64c33af05833 docs: 4c2b7f3ac9052d50aa1c8fa20e643ce4bbf639c6

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9791da1 Publishing web

[GitHub] [incubator-nuttx] nimish closed pull request #6482: Use builtins for byteswapping

nimish closed pull request #6482: Use builtins for byteswapping URL: https://github.com/apache/incubator-nuttx/pull/6482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [incubator-nuttx] andrey-pr commented on pull request #6521: Added config for using BMP280 with ESP32

andrey-pr commented on PR #6521: URL: https://github.com/apache/incubator-nuttx/pull/6521#issuecomment-1166357196 @xiaoxiang781216 I removed merge and created new PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] andrey-pr opened a new pull request, #6522: Added configuration files for using BMP280 with ESP32-DevkitC

andrey-pr opened a new pull request, #6522: URL: https://github.com/apache/incubator-nuttx/pull/6522 ## Summary I added configuration files for using BMP280 with ESP32-DevkitC, and recreated PR because of error with previous repo ## Impact ## Testing -- This is an

[GitHub] [incubator-nuttx] ppisa commented on issue #6082: Export Make.defs broken, missing HEAD_OBJ, LDENDGROUP, LDSTARTGROUP

ppisa commented on issue #6082: URL: https://github.com/apache/incubator-nuttx/issues/6082#issuecomment-1166347130 Hello, I have found time only now and test state with actual NuttX sources. I test with `tools/configure.sh esp32c3-devkit:twai` but it seems to be problem with most oth

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

xiaoxiang781216 commented on code in PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#discussion_r906701940 ## drivers/syslog/vsyslog.c: ## @@ -79,6 +79,10 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #endif #endif +#ifdef CON

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

xiaoxiang781216 commented on code in PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#discussion_r906701940 ## drivers/syslog/vsyslog.c: ## @@ -79,6 +79,10 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #endif #endif +#ifdef CON

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6521: Added config for using BMP280 with ESP32

xiaoxiang781216 commented on PR #6521: URL: https://github.com/apache/incubator-nuttx/pull/6521#issuecomment-1166321137 @andrey-pr please remove the merge patch from PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906698456 ## arch/arm64/src/common/arm64_assert.c: ## @@ -0,0 +1,582 @@ +/ + * arch/arm64/sr

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906697466 ## arch/arm64/src/common/arm64_boot.c: ## @@ -0,0 +1,185 @@ +/ + * arch/arm64/src/

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

pkarashchenko commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166307610 > Or maybe I can change our way of using syslog, rather than print 1000+ symbols per syslog, I can split a long string into several syslog calls. Maybe this is a better way?

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

XinStellaris commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166298333 Or maybe I can change our way of using syslog, rather than print 1000+ symbols per syslog, I can split a long string into several syslog calls. Maybe this is a better way?

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906688242 ## arch/arm64/src/common/arm64_boot.c: ## @@ -0,0 +1,185 @@ +/ + * arch/arm64/s

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

XinStellaris commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166293727 > So you are printing 1000+ symbols per syslog call? From time to time, syslog in out application will print 1000+ symbols. It happens when: 1. We recv a long string

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906687696 ## arch/arm64/src/common/arm64_arch.h: ## @@ -0,0 +1,531 @@ +/ + * arch/arm64/s

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906687639 ## arch/arm64/src/common/arm64_assert.c: ## @@ -0,0 +1,582 @@ +/ + * arch/arm64

[GitHub] [incubator-nuttx] acassis commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

acassis commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166292513 > > > > > > > > > Thanks for your review. Yes this will have impact on scheduler and needs to be dealt with carefully. But I am not sure under which case can this make

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

pkarashchenko commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166292487 So you are printing 1000+ symbols per syslog call? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

XinStellaris commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166292225 > If the system does not have hard memory limitations, then maybe it is better to configure `CONFIG_SYSLOG_BUFFER=y` and set `CONFIG_IOB_BUFSIZE` to the maximum size of the o

[incubator-nuttx] branch master updated (252985fc1d -> 4c2b7f3ac9)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 252985fc1d netdev/carrier: check the IF stautus before carrier add 4c2b7f3ac9 tools/jlink-nuttx:

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6520: tools/jlink-nuttx: Move the register index check to setget_reg

pkarashchenko merged PR #6520: URL: https://github.com/apache/incubator-nuttx/pull/6520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] andrey-pr opened a new pull request, #6521: Added config for using BMP280 with ESP32

andrey-pr opened a new pull request, #6521: URL: https://github.com/apache/incubator-nuttx/pull/6521 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6520: tools/jlink-nuttx: Move the register index check to setget_reg

xiaoxiang781216 opened a new pull request, #6520: URL: https://github.com/apache/incubator-nuttx/pull/6520 ## Summary avoid access tcbinfo before initializing it in update_tcbinfo ## Impact Fix the crash ## Testing -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

pkarashchenko commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r906675614 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) static

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906674372 ## arch/arm64/src/common/arm64_boot.c: ## @@ -0,0 +1,185 @@ +/ + * arch/arm64/src/

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906673839 ## arch/arm64/src/common/arm64_assert.c: ## @@ -0,0 +1,582 @@ +/ + * arch/arm64/sr

[incubator-nuttx] branch master updated: netdev/carrier: check the IF stautus before carrier

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 252985fc1d netdev/carrier: check the

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6519: netdev/carrier: check the IF stautus before carrier

xiaoxiang781216 merged PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (2eb1124db5 -> 43497df78b)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 2eb1124db5 wireless/bcm43xxx: correct the return value add 43497df78b wireless/bcm43xxx: add dynamic

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6518: wireless/bcm43xxx: add dynamic kso control support

xiaoxiang781216 merged PR #6518: URL: https://github.com/apache/incubator-nuttx/pull/6518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906673001 ## arch/arm64/src/common/arm64_arch.h: ## @@ -0,0 +1,531 @@ +/ + * arch/arm64/src/

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

gustavonihei commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r906670100 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) static i

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

pkarashchenko commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r90824 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,15 +71,17 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) stati

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

pkarashchenko commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r90824 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,15 +71,17 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) stati

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

adamkaliszan commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r90610 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) static i

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6510: Support for 2.13 inch display v2

pkarashchenko commented on code in PR #6510: URL: https://github.com/apache/incubator-nuttx/pull/6510#discussion_r906665867 ## drivers/lcd/ssd1680.c: ## @@ -878,19 +896,30 @@ static void ssd1680_select(FAR struct ssd1680_dev_s *priv, bool cs) } } -static void ssd1680_bu

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

anchao commented on code in PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906665668 ## net/netdev/netdev_carrier.c: ## @@ -89,13 +93,16 @@ int netdev_carrier_off(FAR struct net_driver_s *dev) { if (dev) { - dev->d_flags &= ~IFF_RUNN

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

pkarashchenko commented on code in PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906665068 ## net/netdev/netdev_carrier.c: ## @@ -62,8 +62,12 @@ int netdev_carrier_on(FAR struct net_driver_s *dev) { if (dev) { - dev->d_flags |= IFF_

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

pkarashchenko commented on code in PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906664910 ## net/netdev/netdev_carrier.c: ## @@ -62,8 +62,12 @@ int netdev_carrier_on(FAR struct net_driver_s *dev) { if (dev) { - dev->d_flags |= IFF_

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

anchao commented on code in PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906664524 ## net/netdev/netdev_carrier.c: ## @@ -62,8 +62,12 @@ int netdev_carrier_on(FAR struct net_driver_s *dev) { if (dev) { - dev->d_flags |= IFF_RUNNING

[GitHub] [incubator-nuttx] davids5 commented on pull request #6511: esp32_board_spi:Missing Data Command pin support

davids5 commented on PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1166247639 @adamkaliszan Please scope your (see title edit) PR messages so that the email subjects contain what part/arch/board of the system is effected. -- This is an automated messag

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX

pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906659963 ## arch/arm64/include/irq.h: ## @@ -0,0 +1,438 @@ +/ + * arch/arm64/include/irq

[GitHub] [incubator-nuttx] qinwei2004 commented on pull request #6478: arch: arm64: ARMv8-A support for NuttX

qinwei2004 commented on PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1166241837 @xiaoxiang781216 , @hartmannathan , @pkarashchenko check is complete, please review again -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6518: wireless/bcm43xxx: add dynamic kso control support

pkarashchenko commented on code in PR #6518: URL: https://github.com/apache/incubator-nuttx/pull/6518#discussion_r906661477 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -892,23 +962,44 @@ int bcmf_sdio_thread(int argc, char **argv) while (true) { - /*

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6518: wireless/bcm43xxx: add dynamic kso control support

anchao commented on code in PR #6518: URL: https://github.com/apache/incubator-nuttx/pull/6518#discussion_r906660308 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -892,23 +962,44 @@ int bcmf_sdio_thread(int argc, char **argv) while (true) { - /* Wait f

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6518: wireless/bcm43xxx: add dynamic kso control support

anchao commented on code in PR #6518: URL: https://github.com/apache/incubator-nuttx/pull/6518#discussion_r906660136 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -132,23 +131,96 @@ static struct bcmf_sdio_frame int bcmf_oob_irq(FAR void *arg) { FAR struct bcmf_

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6482: Use builtins for byteswapping

pkarashchenko commented on code in PR #6482: URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r906658298 ## include/nuttx/compiler.h: ## @@ -69,6 +69,36 @@ # undef CONFIG_HAVE_CXX14 #endif +#if defined(__cplusplus) && __cplusplus >= 201703L +# define CON

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6511: Missing Data Command pin support

pkarashchenko commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r906657953 ## boards/xtensa/esp32/common/src/esp32_board_spi.c: ## @@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid) static

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

pkarashchenko commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166234940 > > > > Thanks for your review. Yes this will have impact on scheduler and needs to be dealt with carefully. But I am not sure under which case can this make the sys

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

pkarashchenko commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1166234177 If the system does not have hard memory limitations, then maybe it is better to configure `CONFIG_SYSLOG_BUFFER=y` and set `CONFIG_IOB_BUFSIZE` to the maximum size of the ou

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6492: Stm32wl55JC SPI driver

xiaoxiang781216 commented on code in PR #6492: URL: https://github.com/apache/incubator-nuttx/pull/6492#discussion_r905047397 ## .github/workflows/docker_linux.yml: ## @@ -65,7 +65,7 @@ jobs: tags: ${{ env.IMAGE_TAG }} - name: Push Linux image -uses:

[incubator-nuttx] branch master updated: wireless/bcm43xxx: correct the return value

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2eb1124db5 wireless/bcm43xxx: correc

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6517: wireless/bcm43xxx: correct the return value

xiaoxiang781216 merged PR #6517: URL: https://github.com/apache/incubator-nuttx/pull/6517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6518: wireless/bcm43xxx: add dynamic kso control support

pkarashchenko commented on code in PR #6518: URL: https://github.com/apache/incubator-nuttx/pull/6518#discussion_r906655476 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -892,23 +962,44 @@ int bcmf_sdio_thread(int argc, char **argv) while (true) { - /*

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

pkarashchenko commented on code in PR #6519: URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906655111 ## net/netdev/netdev_carrier.c: ## @@ -62,8 +62,12 @@ int netdev_carrier_on(FAR struct net_driver_s *dev) { if (dev) { - dev->d_flags |= IFF_

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6510: Support for 2.13 inch display v2

adamkaliszan commented on code in PR #6510: URL: https://github.com/apache/incubator-nuttx/pull/6510#discussion_r906647539 ## drivers/lcd/ssd1680.c: ## @@ -634,35 +679,50 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv) /* Step 9: SSD1680_SET_RAMXCOUNT, 0