[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6519: netdev/carrier: check the IF stautus before carrier

[GitBox]

anchao commented on code in PR #6519:
URL: https://github.com/apache/incubator-nuttx/pull/6519#discussion_r906664524


##########
net/netdev/netdev_carrier.c:
##########
@@ -62,8 +62,12 @@ int netdev_carrier_on(FAR struct net_driver_s *dev)
 {
   if (dev)
     {
-      dev->d_flags |= IFF_RUNNING;
-      netlink_device_notify(dev);
+      if (!IFF_IS_RUNNING(dev->d_flags))

Review Comment:
   Yes, this issue can also be solved on the driver side, but I think if which 
can be fix inside netdev_carrier_*, it will also bring benefits to other 
drivers, because it is unnecessary to report more of the same events to netlink



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org