xiaoxiang781216 commented on code in PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#discussion_r906701940
########## drivers/syslog/vsyslog.c: ########## @@ -79,6 +79,10 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #endif #endif +#ifdef CONFIG_SYSLOG_SCHEDLOCK + sched_lock(); Review Comment: sched_lock can't protect in SMP case, so you have to use critical section here: https://github.com/apache/incubator-nuttx/issues/3600 basically, all sched_lock which is used for lock need replace with critical section or spinlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
