antmerlino commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-nuttx/pull/3488#discussion_r835726071
##
File path: arch/arm/src/stm32h7/stm32_tim.c
##
@@ -487,6 +500,64 @@ static void stm32_tim_disable(FAR struct stm32_tim_dev_s
*dev)
stm32
antmerlino commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-nuttx/pull/3488#discussion_r835726002
##
File path: arch/arm/src/stm32h7/stm32_tim.c
##
@@ -775,6 +846,12 @@ static void stm32_tim_disableint(FAR struct
stm32_tim_dev_s *dev, int s
antmerlino commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-nuttx/pull/3488#discussion_r835725949
##
File path: arch/arm/src/stm32h7/hardware/stm32_tim.h
##
@@ -719,6 +719,7 @@
#define ATIM_CCER_CC5P(1 << 17) /* Bit 17: Capture/
antmerlino commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-nuttx/pull/3488#discussion_r835725930
##
File path: arch/arm/src/stm32h7/stm32_tickless.c
##
@@ -0,0 +1,1057 @@
+/***
microhobby commented on a change in pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#discussion_r835715200
##
File path: boards/arm/stm32h7/portenta-h7/configs/nsh/defconfig
##
@@ -0,0 +1,54 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
microhobby commented on pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#issuecomment-1079604359
@antmerlino Sorry for the delay, but other things have also changed. I put
it in some reviews. I believe that it's all now (at least I had one successful
build on my
pkarashchenko merged pull request #1090:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 732df52 testing: Fix cxxte
microhobby edited a comment on pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#issuecomment-1079594751
@antmerlino this commit, we need to change also the portenta `stm32_boot.c`
https://github.com/dotnuttx/incubator-nuttx/commit/54e630e14d7e32d6f81ae79d4e5df3d2
microhobby commented on pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#issuecomment-1079594751
@antmerlino this commit, we need to change also the portenta stm32_boot.c
https://github.com/dotnuttx/incubator-nuttx/commit/54e630e14d7e32d6f81ae79d4e5df3d2fa787ef0
microhobby commented on pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#issuecomment-1079593891
@antmerlino I tried to build it on my environment and I had the same error:
```
./stm32_boot.c:32:10: fatal error: arm_arch.h: No such file or directory
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 494230a arch/risc-v: Improve performance of context switch
add 2cd1769 libxx: Add CXX_RTTI for
pkarashchenko merged pull request #5851:
URL: https://github.com/apache/incubator-nuttx/pull/5851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
no1wudi opened a new pull request #5852:
URL: https://github.com/apache/incubator-nuttx/pull/5852
## Summary
Just code style, no functional changes.
## Impact
N/A
## Testing
qemu
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 27b5ca0 Publishing web
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b59dd92 net/rpmsg: fix compile-time warning
add 494230a arch/risc-v: Improve performance of context
masayuki2009 merged pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
robertlipe commented on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1079420400
Excellent. Thank you, Lup Yuen!. Please feel free to cherry pick patches
from the OP or Xiang Xiao can take the ones he'd accept and perhaps guide
us on how to do th
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835571338
##
File path: arch/risc-v/src/common/supervisor/riscv_context.S
##
@@ -0,0 +1,234 @@
+/***
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835569244
##
File path: arch/risc-v/src/common/supervisor/riscv_sbi.c
##
@@ -0,0 +1,58 @@
+/
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835551809
##
File path: arch/risc-v/include/syscall.h
##
@@ -78,6 +79,7 @@
*/
#define SYS_switch_context(2)
+#endif /* CONFIG_ARCH_USE_
gustavonihei opened a new pull request #5851:
URL: https://github.com/apache/incubator-nuttx/pull/5851
## Summary
This PR intends to add a Kconfig option for conditionally enable RTTI
support on C++ applications.
## Impact
Should have no impact for existing defconfigs. Most of
gustavonihei opened a new pull request #1090:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1090
## Summary
This PR intends to fix the build of the `cxxtest` testing application.
It is currently failing on `-fno-rtti` builds due to using
`std::dynamic_cast`, which requires
anchao commented on issue #5843:
URL:
https://github.com/apache/incubator-nuttx/issues/5843#issuecomment-1079361379
Hi @PetervdPerk-NXP ,
> Unfortunely there wasn't a how to guide, but I tried to mimick the SIM
sysview configuration
Yes, the SIM configuration simply enables
anchao opened a new pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850
## Summary
armv7-m/armv8-m: more pref to common place
## Impact
N/A
## Testing
CI check
--
This is an automated message from the Apache Git Service.
To respo
microhobby commented on pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#issuecomment-1079297489
@antmerlino you still need to rebase your
https://github.com/antmerlino/incubator-nuttx/tree/arduino-portenta with the
https://github.com/apache/incubator-nuttx/tree
microhobby commented on a change in pull request #3172:
URL: https://github.com/apache/incubator-nuttx/pull/3172#discussion_r835506956
##
File path: boards/arm/stm32h7/portenta-h7/src/stm32_userleds.c
##
@@ -0,0 +1,151 @@
+/**
GUIDINGLI opened a new pull request #5849:
URL: https://github.com/apache/incubator-nuttx/pull/5849
## Summary
pm: remove unnecessary depends on OSINIT_OS_READY
## Impact
pm
## Testing
VELA
--
This is an automated message from the Apache Git Service.
To
GUIDINGLI opened a new pull request #5848:
URL: https://github.com/apache/incubator-nuttx/pull/5848
## Summary
local_socket: default set block mode if accept() a new socket
reference:
https: //man7.org/linux/man-pages/man2/accept.2.html
1. defa
GUIDINGLI opened a new pull request #5847:
URL: https://github.com/apache/incubator-nuttx/pull/5847
## Summary
rptun related update
1. add rptun ping support
2. add rptun dump support
3. add rptun panic/reset support
4. add RPTUN_WORKQUEUE method
5. add rpmsg_wait/post
GUIDINGLI opened a new pull request #5846:
URL: https://github.com/apache/incubator-nuttx/pull/5846
## Summary
epoll: fix epoll close error, report by kasan
-#9 0xf7abf899 in __asan::__asan_report_load2 (addr=4072681776) at
../../../../../src/libsanitizer/asan/asan_rtl.cc:117
GUIDINGLI opened a new pull request #5845:
URL: https://github.com/apache/incubator-nuttx/pull/5845
## Summary
armv8-m: make the securefault handled by non-securefult
If non-secure generated securefault, then we can't get non-secure PC and
backtrace in secure ENV (TEE).
So,
GUIDINGLI opened a new pull request #5844:
URL: https://github.com/apache/incubator-nuttx/pull/5844
## Summary
rpmsgfs: do NOT access the pointer when do remote ioctl
rpmsgfs/rename: fix bug about pathname align with 8bytes
## Impact
rpmsgfs
## Testing
PetervdPerk-NXP opened a new issue #5843:
URL: https://github.com/apache/incubator-nuttx/issues/5843
I've noticed this PR https://github.com/apache/incubator-nuttx/pull/5327 and
tried to get Segger System View it on my S32K144 based board.
Unfortunely there wasn't a how to guide, but
no1wudi commented on a change in pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#discussion_r835386707
##
File path: arch/risc-v/src/common/riscv_schedulesigaction.c
##
@@ -370,7 +428,9 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t
masayuki2009 commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1079089384
@no1wudi
There still remains style changes that should be in a separate commit
--
This is an automated message from the Apache Git Service.
To respond to
masayuki2009 commented on a change in pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#discussion_r835328175
##
File path: arch/risc-v/src/common/riscv_schedulesigaction.c
##
@@ -265,55 +283,80 @@ void up_schedule_sigaction(struct tcb_s *tcb,
sig_de
no1wudi commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1079078557
>
The conflict fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiaoxiang781216 closed pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 5198a56 esp32s3-devkit: Fix the number of memory regions in some
configurations
add 1caf7d6 rptun
masayuki2009 commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1079070581
>@masayuki2009 could you try with your fail case again?
@xiaoxiang781216 @no1wudi
I think that this PR should be rebased to fix the conflicts reported by
xiaoxiang781216 commented on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1079025931
@lupyuen it will be great if you can upstream your fix and improvement to
mainline.
--
This is an automated message from the Apache Git Service.
To respond to the
pkarashchenko merged pull request #5841:
URL: https://github.com/apache/incubator-nuttx/pull/5841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 5198a56 esp32s3-devkit: Fix the
lupyuen commented on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1079038122
Yep I'll submit the PR soon thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
acassis merged pull request #5842:
URL: https://github.com/apache/incubator-nuttx/pull/5842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 7afedda arch/risc-v: improve style co
xiaoxiang781216 commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1079024831
@masayuki2009 could you try with your fail case again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
acassis commented on a change in pull request #5827:
URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r835243322
##
File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c
##
@@ -0,0 +1,450 @@
+/
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1079018754
Thanks, I will finish the review in the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
pkarashchenko opened a new pull request #5842:
URL: https://github.com/apache/incubator-nuttx/pull/5842
## Summary
Style in RISC-V arch files is inconsistent. Improve style consistency
accross chip variants
## Impact
None
## Testing
Pass CI
--
This is an automated
pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1078975760
The MPFS code is now moved into a different patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
gustavonihei opened a new pull request #5841:
URL: https://github.com/apache/incubator-nuttx/pull/5841
## Summary
This PR intends to fix the amount of heap regions in some of the default
configurations for the `esp32s3-devkit` board.
In those configurations, the entire heap may be all
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 594ae1e boards: rv-virt: Fix stack corruption for rv64 configs
add c8ea7a9 libc: Implement get
pkarashchenko merged pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eenurkka commented on a change in pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840#discussion_r835194764
##
File path: drivers/rptun/rptun.c
##
@@ -953,7 +953,7 @@ int rptun_initialize(FAR struct rptun_dev_s *dev)
goto err_driver;
}
-
pkarashchenko commented on a change in pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840#discussion_r835193465
##
File path: drivers/rptun/rptun.c
##
@@ -953,7 +953,7 @@ int rptun_initialize(FAR struct rptun_dev_s *dev)
goto err_driver;
}
pussuw edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1078912164
Another CI issue it seems: Error:
/github/workspace/sources/nuttx/arch/risc-v/src/common/riscv_internal.h:315:3:
error: value computed is not used [-Werror=unuse
pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1078910876
I will move the MPFS parts out of this review and the next patch will
include them.
However, I think asking me to remove the typo fixes is a bit unfair. I
underst
eenurkka opened a new pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840
## Summary
Fix a few warnings related to RPMSG.
## Impact
No functional changes
## Testing
Compile-time only
--
This is an automated message from the Apach
pkarashchenko merged pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 594ae1e boards: rv-virt: Fix st
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835139779
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
**
xiaoxiang781216 commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078875416
> @xiaoxiang781216 do you know why CI is not started?
I don't know why, let's me push again.
--
This is an automated message from the Apache Git Service
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835136744
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
lupyuen commented on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1078874841
OK LVGL works on BL602 with ST7789 Display! We fixed a couple of GPIO and
SPI issues...
1. Fixed SPI Send on BL602:
https://github.com/lupyuen/incubator-nut
xiaoxiang781216 commented on a change in pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#discussion_r835125326
##
File path: arch/risc-v/src/common/riscv_exception_common.S
##
@@ -119,12 +119,23 @@ exception_common:
la sp, g_intstacktop
#endif
lupyuen edited a comment on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1077001344
ST7789 Driver runs in Kernel Space so I don't think it can access
`/dev/gpio*`?
There is a generic LCD Driver that wraps up the ST7789 Driver as `/dev/lcd*`:
pkarashchenko commented on a change in pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#discussion_r835121976
##
File path: boards/risc-v/litex/arty_a7/src/litex_sdio.c
##
@@ -0,0 +1,134 @@
+/**
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835118528
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
**
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835118804
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
**
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835118528
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
**
xiaoxiang781216 merged pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new e597f38 tools:use dump log creat a
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835111644
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
masayuki2009 commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835107529
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CO
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835104607
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_
pkarashchenko commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835083560
##
File path: arch/risc-v/include/mode.h
##
@@ -0,0 +1,91 @@
+/
masayuki2009 commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835098980
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CO
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835092550
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835092550
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_
pkarashchenko merged pull request #1088:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new cfadf7b fsutils/passwd: fi
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835074615
##
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##
@@ -47,6 +47,7 @@ CONFIG_DEV_ZERO=y
CONFIG_FS_PROCFS=y
CONFIG_IDLETHREAD_
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835071903
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -22,9 +22,40 @@
* Included Files
**
masayuki2009 opened a new pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839
## Summary
- This commit fixes stack corruption for rv64 configs
## Impact
- None
## Testing
- Tested with qemu-6.2
--
This is an automated mes
pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1078787164
Seems like CI is now broken, need to patch other platforms:
Error: bl602_ostest.c:75:3: error: implicit declaration of function
'riscv_saveusercontext'; did you mean
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835045349
##
File path: arch/risc-v/include/syscall.h
##
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr,
uintptr_t parm1,
no1wudi commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1078755319
> @no1wudi
>
> It seems that the PR has only 1 commit which also contains some style
changes. So could you please separate such the changes to another commit?
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835026236
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,17 +43,24 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_C
masayuki2009 commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1078740606
@no1wudi
It seems that the PR has only 1 commit which also contains some style
changes.
So could you please separate such the changes to another commit?
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835019529
##
File path: libs/libc/unistd/lib_getentropy.c
##
@@ -0,0 +1,83 @@
+/
xiaoxiang781216 commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078735114
> > * is this meant for linux compat? why not getentropy, which is accepted
by posix?
> > * it seems dangerous to ignore !GRND_INSECURE.
>
> BTW I fail
pkarashchenko commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078732764
> * is this meant for linux compat? why not getentropy, which is accepted by
posix?
> * it seems dangerous to ignore !GRND_INSECURE.
BTW I failed to find
no1wudi commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835005084
##
File path: arch/risc-v/Kconfig
##
@@ -188,6 +189,30 @@ config ARCH_MMU_TYPE_SV39
bool
default n
+config ARCH_HAVE_S_MODE
Rev
jlaitine commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835002649
##
File path: arch/risc-v/Kconfig
##
@@ -188,6 +189,30 @@ config ARCH_MMU_TYPE_SV39
bool
default n
+config ARCH_HAVE_S_MODE
Re
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r835002330
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ * in
97 matches
Mail list logo
