xiaoxiang781216 commented on a change in pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r835571338
########## File path: arch/risc-v/src/common/supervisor/riscv_context.S ########## @@ -0,0 +1,234 @@ +/**************************************************************************** + * arch/risc-v/src/common/supervisor/riscv_context.S Review comment: can we make supervisor and machine folder contain the same named source files but different implementation? so Make.defs in chip folder could avoid check CONFIG_ARCH_USE_S_MODE as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org