[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #556: examples/pty_test: Fix the hardcode uart device path

2021-01-13 Thread GitBox
Ouss4 merged pull request #556: URL: https://github.com/apache/incubator-nuttx-apps/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx-apps] branch master updated: examples/pty_test: Fix the hardcode uart device path

2021-01-13 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 95a0684 examples/pty_test: F

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-759941234 @yamt, these two patches is too hack to support macOS: 1. sim: Postpone constructor calls after main on macOS 2. task_startup: Implement cxx_initializ

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
masayuki2009 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759952751 I confirmed that this PR works with esp32-devkitc:wapi This is an automated message from th

[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
masayuki2009 merged pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx-apps] branch master updated: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 35f3b60 system/argtable3: Updat

[GitHub] [incubator-nuttx] yamt commented on pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
yamt commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-759948205 > @yamt, these two patches is too hack to support macOS: > > 1. sim: Postpone constructor calls after main on macOS > > 2. task_startup: Implement cxx_i

[GitHub] [incubator-nuttx] yamt opened a new pull request #2678: Fix libcxx for sim/macOS (less controversial parts)

2021-01-13 Thread GitBox
yamt opened a new pull request #2678: URL: https://github.com/apache/incubator-nuttx/pull/2678 ## Summary Extracted from https://github.com/apache/incubator-nuttx/pull/2063 ## Impact ## Testing See https://github.com/apache/incubator-nuttx/pull/2063

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
yamt commented on a change in pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r557058726 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -93,14 +93,28 @@ NM = $(CROSSDEV)nm OBJCOPY = $(CROSSDEV)objcopy OBJDUMP = $(CROSSDEV)objd

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r557057930 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -93,14 +93,28 @@ NM = $(CROSSDEV)nm OBJCOPY = $(CROSSDEV)objcopy OBJDUMP = $(CR

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-759941234 @yamt, these two patches is too hack to support macOS: 1. sim: Postpone constructor calls after main on macOS 2. task_startup: Implement cxx_initialize for s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759939687 Yes, I think: 1. Change nxsched_process_timer to accept the elapsed ticks 2. Call nxsched_process_timer with the correct ticks after wakeup it's more simp

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759921459 BTW, I am aksing the maintainer when to release the new package: https://github.com/argtable/argtable3/issues/60 --

[GitHub] [incubator-nuttx-apps] cwespressif closed pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif closed pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif commented on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759934049 > @cwespressif > My approach is almost the same as you but I noticed that I added CONFIG_NET_TCP_WRITE_BUFFERS=y locally. > If I remove the setting, it work

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
masayuki2009 commented on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759931712 @cwespressif My approach is almost the same as you but I noticed that I added CONFIG_NET_TCP_WRITE_BUFFERS=y locally. If I remove the setting, it works now

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759921459 BTW, I am aksing the maintain when to release the new package: https://github.com/argtable/argtable3/issues/60 ---

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759921304 @cwespressif I found the reason why my local machine can pass the build, but the mainline can't. My local machine use the latest mainline of argtable3, which

[GitHub] [incubator-nuttx] cwespressif commented on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
cwespressif commented on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759915998 > nxsched_process_timer The RTC timer still works in all low power mode, we compensate the system clock according to the time of low power mode counted by RTC

[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
cwespressif commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759905612 > Hi @xiaoxiang781216 , I tried this PR but Still compile errors: > > incubator-nuttx-apps/system/argtable3/argtable3/src/getopt.h:92:20: error: #include n

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #561: webclient: Add AF_LOCAL support

2021-01-13 Thread GitBox
yamt opened a new pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561 ## Summary webclient: Add AF_LOCAL support ## Impact ## Testing Tested against Docker Engine socket on macOS and Linux. (with a ported version of webclient) Only build-tested

[GitHub] [incubator-nuttx-apps] cwespressif edited a comment on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif edited a comment on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713 > @cwespressif > > I tried this PR with esp32-devkitc but it seems that it's unstable. > > ``` > nsh> uname -a > NuttX 10.0.1 657088318

[GitHub] [incubator-nuttx] liangzhanggb commented on a change in pull request #2669: arch/risc-v/bl602 : add gpioirq、 i2c(master) driver.

2021-01-13 Thread GitBox
liangzhanggb commented on a change in pull request #2669: URL: https://github.com/apache/incubator-nuttx/pull/2669#discussion_r557015114 ## File path: arch/risc-v/src/bl602/bl602_i2c.c ## @@ -0,0 +1,1049 @@ +/*

[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
cwespressif commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759894054 Hi @xiaoxiang781216 , I tried this PR but Still compile errors: incubator-nuttx-apps/system/argtable3/argtable3/src/getopt.h:92:20: error: #include nested

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759890330 @masayuki2009 BTW, since I add this in Makefile: ``` CFLAGS += ${shell $(DEFINE) "$(CC)" ARG_REPLACE_GETOPT=0} ``` err.h shouldn't be includ

[incubator-nuttx-apps] branch master updated (eceaeb9 -> ebe3b0d)

2021-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from eceaeb9 netutils/ftpd, examples/ftpd: code cleanup and nxstyle add ebe3b0d webclient: Report

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #560: webclient: Report unexpected connection loss as an explicit error

2021-01-13 Thread GitBox
xiaoxiang781216 merged pull request #560: URL: https://github.com/apache/incubator-nuttx-apps/pull/560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759890330 @masayuki2009 BTW, since I add this in Makfile: ``` CFLAGS += ${shell $(DEFINE) "$(CC)" ARG_REPLACE_GETOPT=0} ``` err.h shouldn't be included in ar

[GitHub] [incubator-nuttx-apps] cwespressif edited a comment on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif edited a comment on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713 > @cwespressif > > I tried this PR with esp32-devkitc but it seems that it's unstable. > > ``` > nsh> uname -a > NuttX 10.0.1 657088318

[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif commented on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713 > @cwespressif > > I tried this PR with esp32-devkitc but it seems that it's unstable. > > ``` > nsh> uname -a > NuttX 10.0.1 657088318a-dirty

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759885037 I built with sim:nsh, err.h may found from Ubuntu. For argtable3.h, I forgot to update the search path: ``` CFLAGS += ${shell $(INCDIR) $(INCDIROPT) "

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #558: Ftpd fixes

2021-01-13 Thread GitBox
xiaoxiang781216 merged pull request #558: URL: https://github.com/apache/incubator-nuttx-apps/pull/558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (6aca601 -> eceaeb9)

2021-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 6aca601 nsh: Pass the correct command lines to nsh_consolemain add 5c8d693 netutils/ftpd: fix

[GitHub] [incubator-nuttx-apps] cwespressif commented on a change in pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif commented on a change in pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#discussion_r557001970 ## File path: system/argtable3/argtable3.patch ## @@ -0,0 +1,512 @@ +diff -ur argtable3/argtable3.c argtable3-v3.0.0/argtable3.c +--- argt

[GitHub] [incubator-nuttx] yamt commented on pull request #2063: Fix libcxx for sim/macOS

2021-01-13 Thread GitBox
yamt commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-759866886 @xiaoxiang781216 do you still have any concerns on this? This is an automated message from the Apache Git S

[incubator-nuttx-website] branch asf-site updated: Publishing web: 59c4fb7620bc9aabf46df895f9e5cdb361f50177 docs: 657088318a71195f2dbbfc4ed21904f1101530e7

2021-01-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0427b0e Publishing web

[GitHub] [incubator-nuttx-testing] yamt commented on pull request #88: Revert "Disable AVR targets on macOS due to homebrew issue"

2021-01-13 Thread GitBox
yamt commented on pull request #88: URL: https://github.com/apache/incubator-nuttx-testing/pull/88#issuecomment-759862969 let's see if the fix for https://github.com/osx-cross/homebrew-avr/issues/205 works for us This is an

[GitHub] [incubator-nuttx-testing] yamt opened a new pull request #88: Revert "Disable AVR targets on macOS due to homebrew issue"

2021-01-13 Thread GitBox
yamt opened a new pull request #88: URL: https://github.com/apache/incubator-nuttx-testing/pull/88 Reverts apache/incubator-nuttx-testing#85 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-nuttx-testing] 01/01: Revert "Disable AVR targets on macOS due to homebrew issue"

2021-01-13 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a commit to branch revert-85-disable-avr in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git commit c22f723809db53278044abc2e529d37b474e675c Author: YAMAMOTO Takashi AuthorDate: Thu Jan

[incubator-nuttx-testing] branch revert-85-disable-avr created (now c22f723)

2021-01-13 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a change to branch revert-85-disable-avr in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git. at c22f723 Revert "Disable AVR targets on macOS due to homebrew issue" This branch i

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #560: webclient: Report unexpected connection loss as an explicit error

2021-01-13 Thread GitBox
yamt opened a new pull request #560: URL: https://github.com/apache/incubator-nuttx-apps/pull/560 ## Summary webclient: Report unexpected connection loss as an explicit error Otherwise, it can end up with mysterious results in user apps. ## Impact ## Testing tested wit

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
masayuki2009 commented on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759848155 @cwespressif I tried this PR with esp32-devkitc but it seems that it's unstable. ``` nsh> uname -a NuttX 10.0.1 657088318a-dirty Jan 14 2021

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
masayuki2009 commented on pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559#issuecomment-759808722 @xiaoxiang781216 I tried this PR but the following error happened. ./argtable3/src/getopt_long.c:149:10: fatal error: err.h: No such file or direc

[GitHub] [incubator-nuttx] yamt commented on pull request #2673: esp32: Add a gdb script to show backtrace

2021-01-13 Thread GitBox
yamt commented on pull request #2673: URL: https://github.com/apache/incubator-nuttx/pull/2673#issuecomment-759790031 > BTW, did you try this script with an interrupt in the way? > For the builtin backtrace support, interrupts need a fabricated (pseudo) save area to emulate a call4.

[GitHub] [incubator-nuttx] yamt commented on pull request #2673: esp32: Add a gdb script to show backtrace

2021-01-13 Thread GitBox
yamt commented on pull request #2673: URL: https://github.com/apache/incubator-nuttx/pull/2673#issuecomment-759787885 > @yamt for reference I have this little script that I use with the backtrace. It requires a few manual input though (copying the backtrace to a file). > > ```shell

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2673: esp32: Add a gdb script to show backtrace

2021-01-13 Thread GitBox
yamt commented on a change in pull request #2673: URL: https://github.com/apache/incubator-nuttx/pull/2673#discussion_r556923243 ## File path: tools/esp32/backtrace.gdbscript ## @@ -0,0 +1,85 @@ + +# to

[GitHub] [incubator-nuttx] raiden00pl edited a comment on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
raiden00pl edited a comment on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759639786 > It looks like this can be implemented by hooking into SUSPEND which would give full control of start/stop. I also tried this approach but without succe

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
raiden00pl commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759639786 > It looks like this can be implemented by hooking into SUSPEND which would give full control of start/stop. I also tried this approach but without success :)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759635818 @cwespressif and @masayuki2009 the latest offical release don't need apply the patch anymore, please try https://github.com/apache/incubator-nuttx-apps/pull/

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #559: system/argtable3: Update to the latest version(v3.1.5.1c1bb23)

2021-01-13 Thread GitBox
xiaoxiang781216 opened a new pull request #559: URL: https://github.com/apache/incubator-nuttx-apps/pull/559 ## Summary And remove the patch process since it doesn't need anymore. ## Impact update to the latest version ## Testing

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759633718 > > > NOSTOP is implied in the first message if the NOSTART flag is set on the second one. Drivers are inconsistent about it they set that flag on the first message

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
Ouss4 commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759628332 > That driver looks a little suspect to me usually you so not want a STOP in the register read. That's not a STOP, that's a repeated start. The chain is: start - wr

[GitHub] [incubator-nuttx-apps] juniskane opened a new pull request #558: Ftpd fixes

2021-01-13 Thread GitBox
juniskane opened a new pull request #558: URL: https://github.com/apache/incubator-nuttx-apps/pull/558 ## Summary - Fixes crash when ftpd_close() called before account setup - Fixes compilation on dual-stack (both IPv4 and IPv6) systems - Rename command RNTO return -EINVAL if no fro

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556727212 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759622135 Taking another look here https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.nrf52832.ps.v1.1%2Ftwim.html It looks like this can be imp

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556723831 ## File path: drivers/efuse/efuse.c ## @@ -0,0 +1,395 @@ +/ + * driver

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556720908 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556720908 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556720908 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556719578 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759615305 > > > > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? > > > > > > > > > It doesn't expect a repeated start

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556716816 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
raiden00pl commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759610698 > In that case, I would at least put this behind a config flag (disabled by default), otherwise a performance penalty will be paid even when not really necessary.

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556712414 ## File path: drivers/efuse/efuse.c ## @@ -0,0 +1,395 @@ +/ + * driver

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-13 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r556711018 ## File path: drivers/efuse/efuse.c ## @@ -0,0 +1,395 @@ +/ + * driver

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
Ouss4 edited a comment on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759608732 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
Ouss4 edited a comment on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759608732 > > > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? > > > > > > It doesn't expect a repeated start. NO

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
Ouss4 commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759608732 > > > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? > > > > > > It doesn't expect a repeated start. NOSTART j

[GitHub] [incubator-nuttx-testing] btashton commented on pull request #87: Reapply xtensa gdb fix to the right section

2021-01-13 Thread GitBox
btashton commented on pull request #87: URL: https://github.com/apache/incubator-nuttx-testing/pull/87#issuecomment-759606285 Something is bad in the cache. I am going to force this locally to get it unblocked, and then update the actions to better handle the cache, docker released some i

[GitHub] [incubator-nuttx-testing] btashton closed pull request #84: WIP: Fix avr ci on macOS

2021-01-13 Thread GitBox
btashton closed pull request #84: URL: https://github.com/apache/incubator-nuttx-testing/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton edited a comment on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759602281 > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? From the i2c header file a repeated start requires a NOSTOP o

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759602281 > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? From the i2c header file a repeated start requires a NOSTOP on previ

[GitHub] [incubator-nuttx] v01d commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
v01d commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759600362 > > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? > > It doesn't expect a repeated start. NOSTART just means that

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
Ouss4 commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759598913 > I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? It doesn't expect a repeated start. NOSTART just means that the

[GitHub] [incubator-nuttx] v01d commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
v01d commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759594761 I see NOSTART used in various drivers, does that not expect a message without a (repeated) start? From the i2c header file a repeated start requires a NOSTOP on previous me

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759586994 In practices none of the drivers in tree use continued messages that do not expect repeated start so I would not expect to see this memcopy flow hit.

[GitHub] [incubator-nuttx] btashton commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
btashton commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759585524 Repeated stop must be specified in the flags that _is_ the configuration feature we should not be hiding this behind more flags. If we detect that there is not repeated

[incubator-nuttx] branch master updated (095d997 -> 6570883)

2021-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 095d997 arch/stm32h7: Fix nxstyle errors add 6570883 stm32412: Fixes pinmap CAN1 No new revisions

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2676: stm32412: Fixes pinmap CAN1

2021-01-13 Thread GitBox
xiaoxiang781216 merged pull request #2676: URL: https://github.com/apache/incubator-nuttx/pull/2676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2677: arch/stm32h7: Fix nxstyle errors

2021-01-13 Thread GitBox
xiaoxiang781216 merged pull request #2677: URL: https://github.com/apache/incubator-nuttx/pull/2677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (ca0932f -> 095d997)

2021-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ca0932f esp32_i2c.c: Remove useless casts add 095d997 arch/stm32h7: Fix nxstyle errors No new rev

[GitHub] [incubator-nuttx] v01d commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
v01d commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759576858 So a repeated start is not sufficient in general? In that case, I would at least put this behind a config flag (disabled by default), otherwise a performance penalty

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
raiden00pl commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759572116 I don't see how "list mode" can help in this case. Each TASKS_STARTTX trigger causes a START byte to be sent. EasyDMA can only update the data pointer (TXD.PTR), b

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2677: arch/stm32h7: Fix nxstyle errors

2021-01-13 Thread GitBox
hartmannathan opened a new pull request #2677: URL: https://github.com/apache/incubator-nuttx/pull/2677 ## Summary arch/arm/src/stm32h7/stm32_rcc.c: arch/arm/src/stm32h7/stm32_rcc.h: * Fix nxstyle issues. ## Impact Removes nxstyle errors. ## Testing

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
xiaoxiang781216 commented on a change in pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557#discussion_r556552247 ## File path: system/argtable3/argtable3.patch ## @@ -0,0 +1,512 @@ +diff -ur argtable3/argtable3.c argtable3-v3.0.0/argtable3.c +---

[GitHub] [incubator-nuttx] davids5 opened a new pull request #2676: stm32412: Fixes pinmap CAN1

2021-01-13 Thread GitBox
davids5 opened a new pull request #2676: URL: https://github.com/apache/incubator-nuttx/pull/2676 ## Summary stm32412 CAN1 (and I suspect more pins) have different alternate functions and appearances on the IO ring. ## Impact CAN1 using PB[8:9] as [RX:TX] did not func

[GitHub] [incubator-nuttx] v01d commented on pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
v01d commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759464197 I don't think that this solution is very good, doing this kind of allocation and copy can be quite wasteful depending on message size. I think it is possible to do this by

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759443692 > > > @xiaoxiang781216 could you take a look here please. > > > > > > Sorry, I thought this PR is for esp32 specific. So this patch want to sync

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759443692 > > > @xiaoxiang781216 could you take a look here please. > > > > > > Sorry, I thought this PR is for esp32 specific. So this patch want to sync

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759443692 > > > @xiaoxiang781216 could you take a look here please. > > > > > > Sorry, I thought this PR is for esp32 specific. So this patch want to sync

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759443692 > > > @xiaoxiang781216 could you take a look here please. > > > > > > Sorry, I thought this PR is for esp32 specific. So this patch want to sync the sy

[GitHub] [incubator-nuttx] cwespressif commented on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
cwespressif commented on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759415008 > > @xiaoxiang781216 could you take a look here please. > > Sorry, I thought this PR is for esp32 specific. So this patch want to sync the system time after wa

[GitHub] [incubator-nuttx] buyuer opened a new pull request #2675: Add placement new and new[] function.

2021-01-13 Thread GitBox
buyuer opened a new pull request #2675: URL: https://github.com/apache/incubator-nuttx/pull/2675 Signed-off-by: dingxintong ## Summary ## Impact ## Testing This is an automated message from the A

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #2674: nrf52_i2c: add support for I2C_M_NOSTOP and I2C_M_NOSTART flags

2021-01-13 Thread GitBox
raiden00pl opened a new pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674 ## Summary Add support for I2C_M_NOSTOP and I2C_M_NOSTART flags. NRF52 hardware doesn't allow direct control of START/STOP bits, so the only solution is to combine messages into one.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 commented on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-759356180 > @xiaoxiang781216 could you take a look here please. Sorry, I thought this PR is for esp32 specific. So this patch want to sync the system time after wake

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2625: Add time ticket related APIs to support hot sleep function

2021-01-13 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r556410633 ## File path: sched/wdog/wd_getidletime.c ## @@ -0,0 +1,64 @@ +/**

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2672: esp32_i2c.c: Remove useless casts

2021-01-13 Thread GitBox
Ouss4 merged pull request #2672: URL: https://github.com/apache/incubator-nuttx/pull/2672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated: esp32_i2c.c: Remove useless casts

2021-01-13 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ca0932f esp32_i2c.c: Remove usele

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #555: netutils/iperf: Add iperf example.

2021-01-13 Thread GitBox
Ouss4 commented on pull request #555: URL: https://github.com/apache/incubator-nuttx-apps/pull/555#issuecomment-759342744 #557 Addresses that. Thanks @masayuki2009 This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx-apps] cwespressif opened a new pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings

2021-01-13 Thread GitBox
cwespressif opened a new pull request #557: URL: https://github.com/apache/incubator-nuttx-apps/pull/557 ## Summary Add argtable3 patch to fix compilation errors and warnings in NuttX. ## Impact Only when the iperf example is enabled. ## Testing By compilin

  1   2   >