cwespressif commented on a change in pull request #557:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/557#discussion_r557001970



##########
File path: system/argtable3/argtable3.patch
##########
@@ -0,0 +1,512 @@
+diff -ur argtable3/argtable3.c argtable3-v3.0.0/argtable3.c
+--- argtable3/argtable3.c      2020-12-14 21:55:38.861316071 +0800
++++ argtable3-v3.0.0/argtable3.c       2020-12-14 21:52:37.189316071 +0800
+@@ -72,13 +72,13 @@
+ 
+ enum
+ {
+-    EMINCOUNT = 1,
+-    EMAXCOUNT,
+-    EBADINT,
+-    EOVERFLOW,
+-    EBADDOUBLE,
+-    EBADDATE,
+-    EREGNOMATCH
++    AEMINCOUNT = 1,

Review comment:
       The defined enum structure conflicts with the macro definition in other 
places:
   https://github.com/apache/incubator-nuttx/blob/master/include/errno.h#L303
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to