Re: [I] [Improvement] Provide Metrics for Gravitino MySQL Backend Storage Connect Pool [gravitino]

2025-02-17 Thread via GitHub
TEOTEO520 commented on issue #5578: URL: https://github.com/apache/gravitino/issues/5578#issuecomment-2663366853 1. https://github.com/apache/gravitino/issues/6467 2. https://github.com/apache/gravitino/issues/6468 -- This is an automated message from the Apache Git Service. To respond

[PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-17 Thread via GitHub
TEOTEO520 opened a new pull request, #6469: URL: https://github.com/apache/gravitino/pull/6469 ### What changes were proposed in this pull request? Add 2 user properties: gravitino.entity.store.relational.max.total.connection gravitino.entity.store.relational.max.wait.millis

[PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
TEOTEO520 opened a new pull request, #6470: URL: https://github.com/apache/gravitino/pull/6470 ### What changes were proposed in this pull request? Support metrics for JDBC backend connect pool : 1. activeConnectionCount 2. idleConnectionCount 3. maxConnectionCount

[I] [Improvement] Add Connection Pool Metrics for JDBC Backend Storage [gravitino]

2025-02-17 Thread via GitHub
TEOTEO520 opened a new issue, #6468: URL: https://github.com/apache/gravitino/issues/6468 ### What would you like to be improved? Monitoring connection pool metrics is crucial for understanding database connectivity health and performance in production environments. Currently, Gravit

Re: [PR] [Improvement] Enable setting of additional configuration parameters through environment variables [gravitino]

2025-02-17 Thread via GitHub
this-user commented on PR #6458: URL: https://github.com/apache/gravitino/pull/6458#issuecomment-2663330230 > I'm not sure if passing credentials via env variables is a good practice. It has some security flaws. A more secure way would be mount them via a volume. That's a fair point,

[I] [Subtask] Add Tag support for model catalog [gravitino]

2025-02-17 Thread via GitHub
TEOTEO520 opened a new issue, #6471: URL: https://github.com/apache/gravitino/issues/6471 ### Describe the subtask While Gravitino's existing catalogs and metadata objects support a tag management system, this functionality is currently missing for ModelCatalog (introduced in v0.8).

Re: [I] [Bug Report] Iceberg REST Server Docker Image Fails to Start an x86_64 Arch Linux system [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on issue #6457: URL: https://github.com/apache/gravitino/issues/6457#issuecomment-2664661324 I prefer an official support JDK docker image, if the docker image doesn't contain Python, we could install it in docker image -- This is an automated message from the Apache Git

Re: [PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-17 Thread via GitHub
jerryshao commented on code in PR #6463: URL: https://github.com/apache/gravitino/pull/6463#discussion_r1959197266 ## catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/Constants.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundati

Re: [I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-17 Thread via GitHub
yuqi1129 commented on issue #6462: URL: https://github.com/apache/gravitino/issues/6462#issuecomment-2664458623 It's the Gravitino server that runs in the deploy mode not the Gravitino client. The Gravitino client is always in embedded mode. -- This is an automated message from the Apach

Re: [I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-17 Thread via GitHub
mchades commented on issue #6462: URL: https://github.com/apache/gravitino/issues/6462#issuecomment-2664456294 > Currently, UTs and ITs are unable to cover this problem as all clients run in embedded mode. Why can't the deploy mode of CI cover it? -- This is an automated message fr

Re: [PR] [MINOR] docs: Remove outdated tips from `web-ui.md` [gravitino]

2025-02-17 Thread via GitHub
LuciferYang commented on PR #6472: URL: https://github.com/apache/gravitino/pull/6472#issuecomment-2664693219 cc @jerqi FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [MINOR] docs: Remove outdated tips from `web-ui.md` [gravitino]

2025-02-17 Thread via GitHub
LuciferYang opened a new pull request, #6472: URL: https://github.com/apache/gravitino/pull/6472 ### What changes were proposed in this pull request? This pr removes outdated tips from `web-ui.md` because, as indicated in the subsequent text, operations such as creating or modifying schem

Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-17 Thread via GitHub
yuqi1129 commented on code in PR #6469: URL: https://github.com/apache/gravitino/pull/6469#discussion_r1959014247 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -84,6 +90,10 @@ private Configs() {} public static final String DEFAULT_RELATIONAL_JDBC_BACKEND_P

Re: [I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-17 Thread via GitHub
jerryshao closed issue #6462: [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` URL: https://github.com/apache/gravitino/issues/6462 -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-17 Thread via GitHub
github-actions[bot] opened a new pull request, #6473: URL: https://github.com/apache/gravitino/pull/6473 ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `Loca

(gravitino) branch cherry-pick-branch-0.8-07ae3f6c092edd3810765c61f38fe5c09431de32 created (now 4bc0fa6791)

2025-02-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-07ae3f6c092edd3810765c61f38fe5c09431de32 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 4bc0fa6791 [#6462] fix(filesystem-hadoop3): Fix GVFS

(gravitino) branch main updated (3dd35ad838 -> 07ae3f6c09)

2025-02-17 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 3dd35ad838 [#6464] fix (gvfs-fuse): Fix the bug of using a relative path to configure gvfs-fuse. (#6465) add 07a

Re: [PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-17 Thread via GitHub
jerryshao merged PR #6463: URL: https://github.com/apache/gravitino/pull/6463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-17 Thread via GitHub
jerryshao closed issue #6462: [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` URL: https://github.com/apache/gravitino/issues/6462 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-17 Thread via GitHub
jerryshao closed pull request #6473: [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem URL: https://github.com/apache/gravitino/pull/6473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(gravitino) branch main updated: [#6464] fix (gvfs-fuse): Fix the bug of using a relative path to configure gvfs-fuse. (#6465)

2025-02-17 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 3dd35ad838 [#6464] fix (gvfs-fuse): Fix the bug of

Re: [PR] [#6464] fix (gvfs-fuse): Fix the bug of using a relative path to configure gvfs-fuse. [gravitino]

2025-02-17 Thread via GitHub
FANNG1 merged PR #6465: URL: https://github.com/apache/gravitino/pull/6465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Bug report] `gvfs-fuse` started with an error when using a configuration with a relative path. [gravitino]

2025-02-17 Thread via GitHub
FANNG1 closed issue #6464: [Bug report] `gvfs-fuse` started with an error when using a configuration with a relative path. URL: https://github.com/apache/gravitino/issues/6464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Improvement] Enable setting of additional configuration parameters through environment variables [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6458: URL: https://github.com/apache/gravitino/pull/6458#discussion_r1958876723 ## dev/docker/iceberg-rest-server/rewrite_config.py: ## @@ -21,13 +21,16 @@ env_map = { "GRAVITINO_IO_IMPL" : "io-impl", "GRAVITINO_URI" : "uri", + "GRAVITINO_

Re: [PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-17 Thread via GitHub
yuqi1129 commented on code in PR #6463: URL: https://github.com/apache/gravitino/pull/6463#discussion_r1958997376 ## catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/Constants.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-17 Thread via GitHub
diqiu50 commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2664755437 The current issue is that when you use -d to enable debug logs, logs from all modules are printed, making it too messy, which is not what we want. We are designing a strategy where envi

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-17 Thread via GitHub
diqiu50 commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2664761418 My suggestion is without using the environment variable, we should print logs at the [info, warn, and error] levels. When `-d 1` is passed, we will enable the FuseDebug Log. when `-d 2

Re: [PR] [Improvement] Enable setting of additional configuration parameters through environment variables [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6458: URL: https://github.com/apache/gravitino/pull/6458#discussion_r1958877362 ## dev/docker/iceberg-rest-server/rewrite_config.py: ## @@ -21,13 +21,16 @@ env_map = { "GRAVITINO_IO_IMPL" : "io-impl", "GRAVITINO_URI" : "uri", + "GRAVITINO_

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958903825 ## core/src/main/java/org/apache/gravitino/metrics/source/RelationDatasourceMetricsSource.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958898715 ## core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java: ## @@ -41,6 +41,7 @@ public abstract class MetricsSource { public static final String

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958898715 ## core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java: ## @@ -41,6 +41,7 @@ public abstract class MetricsSource { public static final String

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958904714 ## core/src/main/java/org/apache/gravitino/metrics/source/RelationDatasourceMetricsSource.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958899906 ## core/src/main/java/org/apache/gravitino/metrics/source/RelationDatasourceMetricsSource.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-17 Thread via GitHub
yuqi1129 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958926562 ## core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java: ## @@ -41,6 +41,7 @@ public abstract class MetricsSource { public static final Strin

Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-17 Thread via GitHub
jerryshao commented on PR #6469: URL: https://github.com/apache/gravitino/pull/6469#issuecomment-2664440351 @yuqi1129 can you please help to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#6459]improve(test): Use implicit wait for time-based condition [gravitino]

2025-02-17 Thread via GitHub
zzzk1 commented on PR #6460: URL: https://github.com/apache/gravitino/pull/6460#issuecomment-2662422645 > @zzzk1 can you please fix the CI issue here? Yes, `./gradlew test [--rerun-tasks] -PskipTests -PtestMode=embedded`. What should I replace `[--rerun-tasks]` with if I want to set u

Re: [PR] [#6459]improve(test): Use implicit wait for time-based condition [gravitino]

2025-02-17 Thread via GitHub
jerryshao commented on PR #6460: URL: https://github.com/apache/gravitino/pull/6460#issuecomment-2662487031 You can keep `--rerun-tasks`, don't need to remove or replace with others. You should make sure you have docker environment locally, please check this doc https://gravitino.apache.org

Re: [PR] [#6330] chore: add BSD license to missing files [gravitino]

2025-02-17 Thread via GitHub
zzzk1 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2662356170 > It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of Technology" to t

[I] [Improvement] Make Gravitino/GVFS clients run in a separate JVM apart from [gravitino]

2025-02-17 Thread via GitHub
yuqi1129 opened a new issue, #6466: URL: https://github.com/apache/gravitino/issues/6466 ### What would you like to be improved? Currently, Gravitino/GVFS client instances in all ITs are running on the same JVM instance that runs Gavitino test, which will make us hard to identify any

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-17 Thread via GitHub
tengqm commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957885701 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [I] [Bug report] Playground fails to start on Mac [gravitino-playground]

2025-02-17 Thread via GitHub
shaofengshi commented on issue #128: URL: https://github.com/apache/gravitino-playground/issues/128#issuecomment-2662546132 user can comment the [line 184](https://github.com/apache/gravitino-playground/blob/main/playground.sh#L184) which invokes the "checkPortsInUse" to bypass this probl

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-17 Thread via GitHub
tengqm commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957890605 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [I] [Improvement] function RoleMetaService.listSecurableObjects need to improve performance when roles is bound to many metadata [gravitino]

2025-02-17 Thread via GitHub
jerqi closed issue #6238: [Improvement] function RoleMetaService.listSecurableObjects need to improve performance when roles is bound to many metadata URL: https://github.com/apache/gravitino/issues/6238 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] [Improvement] function RoleMetaService.listSecurableObjects need to improve performance when roles is bound to many metadata [gravitino]

2025-02-17 Thread via GitHub
jerqi closed issue #6238: [Improvement] function RoleMetaService.listSecurableObjects need to improve performance when roles is bound to many metadata URL: https://github.com/apache/gravitino/issues/6238 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. [gravitino]

2025-02-17 Thread via GitHub
jerqi merged PR #6455: URL: https://github.com/apache/gravitino/pull/6455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.

(gravitino) branch main updated: [#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. (#6455)

2025-02-17 Thread roryqi
This is an automated email from the ASF dual-hosted git repository. roryqi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 30ea1dcb11 [#6238] improvement(storage): Improve

Re: [PR] [#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. [gravitino]

2025-02-17 Thread via GitHub
jerqi commented on PR #6455: URL: https://github.com/apache/gravitino/pull/6455#issuecomment-2662654877 Merged. @yuqi1129 Thanks for your review. @FourFriends. thanks for your first contribution. It's a great start. Welcome to join the Gravitino community and enjoy your trip of open source

Re: [PR] [#6330] chore: add BSD license to missing files [gravitino]

2025-02-17 Thread via GitHub
zzzk1 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2662377420 > It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of Technology" to t

Re: [I] [Bug report] Playground fails to start on Mac [gravitino-playground]

2025-02-17 Thread via GitHub
shaofengshi commented on issue #128: URL: https://github.com/apache/gravitino-playground/issues/128#issuecomment-2662397309 I debuged it but couldn't know what's the reason; It just quit at the line that execute "lsof" command, with no error message. As we already use those not well