FANNG1 commented on code in PR #6470:
URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958898715
##########
core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java:
##########
@@ -41,6 +41,7 @@ public abstract class MetricsSource {
public static final String ICEBERG_REST_SERVER_METRIC_NAME =
"iceberg-rest-server";
public static final String GRAVITINO_SERVER_METRIC_NAME = "gravitino-server";
public static final String JVM_METRIC_NAME = "jvm";
+ public static final String RELATION_DATASOURCE_METRIC_NAME =
"relation-datasource";
Review Comment:
`relation-datasource` seems confusing, I may wonder what's it in Gravitino,
is it the relation entity store in Gravitino? I prefer to using
`gravitino-entityStore` as the metrics name since it's this is the metrics for
entity store and relation datasource is one of the implementation, we you place
relation information in the metrics name like `relationDatasource.
activeConnectionCount`, WDYT? cc @yuqi1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
