yuqi1129 commented on code in PR #6470:
URL: https://github.com/apache/gravitino/pull/6470#discussion_r1958926562
##########
core/src/main/java/org/apache/gravitino/metrics/source/MetricsSource.java:
##########
@@ -41,6 +41,7 @@ public abstract class MetricsSource {
public static final String ICEBERG_REST_SERVER_METRIC_NAME =
"iceberg-rest-server";
public static final String GRAVITINO_SERVER_METRIC_NAME = "gravitino-server";
public static final String JVM_METRIC_NAME = "jvm";
+ public static final String RELATION_DATASOURCE_METRIC_NAME =
"relation-datasource";
Review Comment:
> I prefer to using entity-store.relation-datasource.
active-connection-count as the metrics name, WDYT?
I totally agree, the name `entity-store.relation-datasource.
active-connection-count` or similar is more clear as some catalogs like `MySQL`
or `Doris` catalogs also use JDBC datasouce pool, it's meaningful to
distinguish them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
