yuqi1129 commented on code in PR #6469:
URL: https://github.com/apache/gravitino/pull/6469#discussion_r1959014247
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -84,6 +90,10 @@ private Configs() {}
public static final String DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD =
"gravitino";
+ public static final int DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION
= 100;
+
+ public static final long
DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLIS_CONNECTION = 1000l;
Review Comment:
1000l -> 1000L, `1000l` can be easily mistaken as `10001`.
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,20 @@ private Configs() {}
.stringConf()
.createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
+ public static final ConfigEntry<Integer>
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =
+ new
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY)
+ .doc("Max total connect of `JDBCBackend`")
+ .version(ConfigConstants.VERSION_0_5_0)
Review Comment:
The version should be 0.9 NOT 0.5
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -48,6 +48,12 @@ private Configs() {}
public static final String ENTITY_RELATIONAL_JDBC_BACKEND_PASSWORD_KEY =
"gravitino.entity.store.relational.jdbcPassword";
+ public static final String
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY =
+ "gravitino.entity.store.relational.max.total.connection";
Review Comment:
Can you please try to shorten the name?
`gravitino.entity.store.relational.max.total.connection` seems to be too long.
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,20 @@ private Configs() {}
.stringConf()
.createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
+ public static final ConfigEntry<Integer>
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =
+ new
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY)
+ .doc("Max total connect of `JDBCBackend`")
Review Comment:
The maximum number of connections for the JDBC Backend connection pool.
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,20 @@ private Configs() {}
.stringConf()
.createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
+ public static final ConfigEntry<Integer>
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =
+ new
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY)
+ .doc("Max total connect of `JDBCBackend`")
+ .version(ConfigConstants.VERSION_0_5_0)
+ .intConf()
+
.createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION);
+
+ public static final ConfigEntry<Long>
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLIS_CONNECTION =
+ new
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLIS_CONNECTION_KEY)
+ .doc("Max max wait millis of `JDBCBackend`")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
