Re: [PR] [#5756] Bug Fix : Warehouse parameter systematically required [gravitino]

2024-12-22 Thread via GitHub
fsalhi2 commented on code in PR #5923: URL: https://github.com/apache/gravitino/pull/5923#discussion_r1894844583 ## gradle.properties: ## @@ -23,7 +23,7 @@ org.gradle.caching=true org.gradle.jvmargs=-Xmx4g # version that is going to be updated automatically by releases -vers

Re: [PR] [#3515] feat(flink-connector): Support flink iceberg catalog [gravitino]

2024-12-22 Thread via GitHub
coolderli commented on code in PR #5914: URL: https://github.com/apache/gravitino/pull/5914#discussion_r1895137424 ## flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/iceberg/IcebergPropertiesConverter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apa

[PR] [#5928] fix(CLI): Fix columns details command produces no output [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord opened a new pull request, #5945: URL: https://github.com/apache/gravitino/pull/5945 ### What changes were proposed in this pull request? Fix columns details command produces no output, when command without --audit option, cli should tell user that command is not su

Re: [PR] [#5928] fix(CLI): Fix columns details command produces no output [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5945: URL: https://github.com/apache/gravitino/pull/5945#issuecomment-2558774122 Hi @justinmclean @xunliu @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Serv

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895119745 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the A

Re: [PR] [#5826] fix(CLI): Fix Dropping a metalake via the Gravitino CLI gives an "in use" exception [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5907: URL: https://github.com/apache/gravitino/pull/5907#issuecomment-2558718579 Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [#5827] improvement(CLI): Fix CLI throws an obscure error when Delete a table with a missing table name [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5906: URL: https://github.com/apache/gravitino/pull/5906#issuecomment-2558727685 Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558760567 lgtm, for the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [#5929] improvement(CLI): fix cli details command produce no output [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on PR #5941: URL: https://github.com/apache/gravitino/pull/5941#issuecomment-2558758820 lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] [FEATURE] Hive3 Metastore Multi Catalog Support [gravitino]

2024-12-22 Thread via GitHub
mchades commented on issue #5912: URL: https://github.com/apache/gravitino/issues/5912#issuecomment-2558766750 Hi @an-shi-chi-fan , thanks for your draft proposal about Hive3 support! Could you kindly transfer the design to a Google document and provide the link for us to engage in di

Re: [PR] [#4584]feat(catalog-iceberg) Support loading custom catalog as backend in Gravitino Iceberg catalog [gravitino]

2024-12-22 Thread via GitHub
theoryxu closed pull request #4680: [#4584]feat(catalog-iceberg) Support loading custom catalog as backend in Gravitino Iceberg catalog URL: https://github.com/apache/gravitino/pull/4680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895189468 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationObject.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apa

Re: [PR] [#5730] feat(client-python): Add sorts expression [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5879: URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895195084 ## clients/client-python/gravitino/api/expressions/sorts/sort_orders.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] [#5794] feat(core): Add ModelOperationDispatcher logic [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on PR #5908: URL: https://github.com/apache/gravitino/pull/5908#issuecomment-2558824753 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895193881 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcPrivilege.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Soft

[I] [FEATURE] Provide an option to prevent users from executing DDL through the compute engine. [gravitino]

2024-12-22 Thread via GitHub
hdygxsj opened a new issue, #5946: URL: https://github.com/apache/gravitino/issues/5946 ### Describe the feature Provide an option to prevent users from executing DDL through the compute engine. ### Motivation When users can only perform DDL changes through the Gravitino

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-22 Thread via GitHub
cool9850311 commented on code in PR #5944: URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895371248 ## core/src/main/java/org/apache/gravitino/listener/api/event/TagFailureEvent.java: ## @@ -0,0 +1,7 @@ +package org.apache.gravitino.listener.api.event; + +public

Re: [PR] [#5826] fix(CLI): Fix Dropping a metalake via the Gravitino CLI gives an "in use" exception [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5907: URL: https://github.com/apache/gravitino/pull/5907#discussion_r1895377485 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -102,6 +107,7 @@ public Options options() { options.addOption(createArgOp

Re: [PR] [#5947] fix(auth): It will throw error if we enable authorization and rename catalog [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5949: URL: https://github.com/apache/gravitino/pull/5949#discussion_r1895379709 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -298,9 +298,19 @@ public static void authorizationPluginRenamePrivileges(

Re: [PR] [#5827] improvement(CLI): Fix CLI throws an obscure error when Delete a table with a missing table name [gravitino]

2024-12-22 Thread via GitHub
justinmclean merged PR #5906: URL: https://github.com/apache/gravitino/pull/5906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] Delete a table with a missing table name causes an obscure error in the Gravitino CLI [gravitino]

2024-12-22 Thread via GitHub
justinmclean closed issue #5827: [Improvement] Delete a table with a missing table name causes an obscure error in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] [Improvement] Delete a table with a missing table name causes an obscure error in the Gravitino CLI [gravitino]

2024-12-22 Thread via GitHub
justinmclean closed issue #5827: [Improvement] Delete a table with a missing table name causes an obscure error in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [#5947] fix(auth): It will throw error if we enable authorization and rename catalog [gravitino]

2024-12-22 Thread via GitHub
jerryshao commented on code in PR #5949: URL: https://github.com/apache/gravitino/pull/5949#discussion_r1895375082 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -298,9 +298,19 @@ public static void authorizationPluginRenamePrivileges(

Re: [PR] [#5877] feat (gvfs-fuse): Implement a common filesystem layer [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5878: URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895303055 ## clients/filesystem-fuse/src/default_raw_filesystem.rs: ## @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#5877] feat (gvfs-fuse): Implement a common filesystem layer [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5878: URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895302378 ## clients/filesystem-fuse/src/default_raw_filesystem.rs: ## @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
cool9850311 commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895320049 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithO

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
cool9850311 commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895320172 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithO

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
cool9850311 commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895323385 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithO

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
mchades commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895325368 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithOwner

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
cool9850311 commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895336255 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithO

Re: [PR] [#5877] feat (gvfs-fuse): Implement a common filesystem layer [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5878: URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895301983 ## clients/filesystem-fuse/src/default_raw_filesystem.rs: ## @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
mchades commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895330644 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithOwner

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895340107 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private S

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895341852 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private S

Re: [PR] [#5928] fix(CLI): Fix columns details command produces no output [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5945: URL: https://github.com/apache/gravitino/pull/5945#discussion_r1895343024 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -755,6 +755,8 @@ private void handleColumnCommand() { case CommandA

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895340107 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private S

[PR] [#5947] fix(auth): It will throw error if we enable authorization and rename catalog [gravitino]

2024-12-22 Thread via GitHub
jerqi opened a new pull request, #5949: URL: https://github.com/apache/gravitino/pull/5949 ### What changes were proposed in this pull request? Fix the issue of renaming catalogs or metalakes. ### Why are the changes needed? Fix: #5947 ### Does this PR introduc

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895358264 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java: ## @@ -49,7 +49,11 @@ public void handle() { try { GravitinoClient

Re: [PR] [#5928] fix(CLI): Fix columns details command produces no output [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on code in PR #5945: URL: https://github.com/apache/gravitino/pull/5945#discussion_r1895359860 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -755,6 +755,8 @@ private void handleColumnCommand() { case CommandAct

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895359453 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java: ## @@ -60,7 +60,7 @@ public void handle() { exitWithError(exp.getMessage()

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895358965 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java: ## @@ -53,7 +53,7 @@ public void handle() { exitWithError(exp.getMessage()

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895359969 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopics.java: ## @@ -66,7 +66,10 @@ public void handle() { exitWithError(exp.getMessage(

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895359679 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java: ## @@ -61,7 +61,10 @@ public void handle() { tableNames.add(tables[i].name

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
justinmclean commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895358688 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java: ## @@ -71,7 +71,7 @@ public void handle() { exitWithError(exp.getMessage

Re: [I] [Bug report] Doc: "COLUMN" doesn't have owner, please remove it from metadataObjectType possible values in set-owner/get-owner api doc [gravitino]

2024-12-22 Thread via GitHub
mchades closed issue #5911: [Bug report] Doc: "COLUMN" doesn't have owner, please remove it from metadataObjectType possible values in set-owner/get-owner api doc URL: https://github.com/apache/gravitino/issues/5911 -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] [Bug report] Doc: "COLUMN" doesn't have owner, please remove it from metadataObjectType possible values in set-owner/get-owner api doc [gravitino]

2024-12-22 Thread via GitHub
mchades closed issue #5911: [Bug report] Doc: "COLUMN" doesn't have owner, please remove it from metadataObjectType possible values in set-owner/get-owner api doc URL: https://github.com/apache/gravitino/issues/5911 -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
mchades merged PR #5922: URL: https://github.com/apache/gravitino/pull/5922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [PR] [#5929] improvement(CLI): fix cli details command produce no output [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5941: URL: https://github.com/apache/gravitino/pull/5941#discussion_r1895111502 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java: ## @@ -60,7 +60,7 @@ public void handle() { exitWithError(exp.getMessage());

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558691223 > bin/gcli.sh schema details --m demo_metalake -i > # output > # Missing --name option. > # Missing --name option. > # Missing required argument(s): catalog, schema Thes

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558752322 Hi @justinmclean @tengqm, I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To re

[PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-22 Thread via GitHub
cool9850311 opened a new pull request, #5944: URL: https://github.com/apache/gravitino/pull/5944 ### What changes were proposed in this pull request? Add tag failure event to Gravitino server ### Why are the changes needed? Subtask: apache#5902 ### Does this PR int

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895155982 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private String

Re: [PR] [#5911] fix(docs): Fix the wrong possible values. [gravitino]

2024-12-22 Thread via GitHub
mchades commented on code in PR #5922: URL: https://github.com/apache/gravitino/pull/5922#discussion_r1895155032 ## docs/open-api/openapi.yaml: ## @@ -477,7 +477,21 @@ components: - "TOPIC" - "ROLE" - "METALAKE" - +metadataObjectTypeWithOwner

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on PR #5904: URL: https://github.com/apache/gravitino/pull/5904#issuecomment-2558812782 > This PR is too big to review effectively. Can we split it into a few smaller ones? It's hard to split otherwise we can't get whole picture of this feature. -- This is an autom

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895188317 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcPrivilege.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Softw

Re: [I] [Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload [gravitino]

2024-12-22 Thread via GitHub
jerryshao closed issue #5756: [Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload URL: https://github.com/apache/gravitino/issues/5756 -- This is an automated message from the Apache Git Service. To respond to the m

(gravitino) branch main updated: [#5756] Bug Fix : Warehouse parameter systematically required (#5923)

2024-12-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 441e6ed5f [#5756] Bug Fix : Warehouse parameter sy

Re: [PR] [#5756] Bug Fix : Warehouse parameter systematically required [gravitino]

2024-12-22 Thread via GitHub
jerryshao merged PR #5923: URL: https://github.com/apache/gravitino/pull/5923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload [gravitino]

2024-12-22 Thread via GitHub
jerryshao commented on issue #5756: URL: https://github.com/apache/gravitino/issues/5756#issuecomment-2558814858 @fsalhi2 would you please leave an comment here, so I can assign the issue to you, thanks. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [#5756] Bug Fix : Warehouse parameter systematically required [gravitino]

2024-12-22 Thread via GitHub
jerryshao commented on PR #5923: URL: https://github.com/apache/gravitino/pull/5923#issuecomment-2558813401 Merging to main branch, thanks @fsalhi2 for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [#5794] feat(core): Add ModelOperationDispatcher logic [gravitino]

2024-12-22 Thread via GitHub
jerryshao commented on PR #5908: URL: https://github.com/apache/gravitino/pull/5908#issuecomment-2558818212 @tengqm @mchades all comments addressed, would you please help to review again? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895191147 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the A

Re: [I] [Subtask] Support transforms expression [gravitino]

2024-12-22 Thread via GitHub
unknowntpo commented on issue #5732: URL: https://github.com/apache/gravitino/issues/5732#issuecomment-2558820587 @xunliu @SophieTech88 This issue should also implement `public class Column` at `api/src/main/java/org/apache/gravitino/rel/Column.java` -- This is an automated message from t

[I] [Bug report] Cannot rename catalog when enable authorization [gravitino]

2024-12-22 Thread via GitHub
mchades opened a new issue, #5947: URL: https://github.com/apache/gravitino/issues/5947 ### Version main branch ### Describe what's wrong After enabling authorization for Gravitino, I encountered a `NoSuchCatalogException` when trying to rename a catalog. ### Erro

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895147850 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private Str

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on code in PR #5943: URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895145086 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -29,6 +29,8 @@ public class FullName { private final CommandLine line; private Str

Re: [PR] [#5929] improvement(CLI): fix cli details command produce no output [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5941: URL: https://github.com/apache/gravitino/pull/5941#issuecomment-2558744904 Hi @justinmclean @tengqm , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To r

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558746971 > > bin/gcli.sh schema details --m demo_metalake -i > > # output > > # Missing --name option. > > # Missing --name option. > > # Missing required argument(s): catalog, sche

Re: [PR] [#5895] support ADLSToken/AzureAccountKey credential for python client [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5940: URL: https://github.com/apache/gravitino/pull/5940#discussion_r1895114439 ## clients/client-python/gravitino/api/credential/azure_account_key_credential.py: ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on code in PR #5942: URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895141145 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java: ## @@ -49,7 +49,11 @@ public void handle() { try { GravitinoClient cl

Re: [PR] [#5924] improvement(CLI): fix cli list command produce no outputs [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5942: URL: https://github.com/apache/gravitino/pull/5942#issuecomment-2558734794 Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5944: URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895209349 ## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ## @@ -19,11 +19,25 @@ package org.apache.gravitino.listener; import java.util.Map; +

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895214877 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

(gravitino) branch main updated: [#5794] feat(core): Add ModelOperationDispatcher logic (#5908)

2024-12-22 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 1a22afee5 [#5794] feat(core): Add ModelOperation

Re: [PR] [#5794] feat(core): Add ModelOperationDispatcher logic [gravitino]

2024-12-22 Thread via GitHub
mchades merged PR #5908: URL: https://github.com/apache/gravitino/pull/5908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [I] [Subtask]Implement the model catalog dispatcher logic [gravitino]

2024-12-22 Thread via GitHub
mchades closed issue #5794: [Subtask]Implement the model catalog dispatcher logic URL: https://github.com/apache/gravitino/issues/5794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] [Subtask]Implement the model catalog dispatcher logic [gravitino]

2024-12-22 Thread via GitHub
mchades closed issue #5794: [Subtask]Implement the model catalog dispatcher logic URL: https://github.com/apache/gravitino/issues/5794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895199164 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895188591 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

Re: [PR] [#5895] support ADLSToken/AzureAccountKey credential for python client [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5940: URL: https://github.com/apache/gravitino/pull/5940#discussion_r1895199320 ## clients/client-python/gravitino/api/credential/azure_account_key_credential.py: ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
tengqm commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895196148 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the A

(gravitino) branch detached deleted (was 89396e00c)

2024-12-22 Thread roryqi
This is an automated email from the ASF dual-hosted git repository. roryqi pushed a change to branch detached in repository https://gitbox.apache.org/repos/asf/gravitino.git was 89396e00c [#5892] fix(auth): Fix to grant privilege for the metalake (#5919) The revisions that were on this br

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895199164 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

Re: [PR] [#5895] support ADLSToken/AzureAccountKey credential for python client [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5940: URL: https://github.com/apache/gravitino/pull/5940#discussion_r1895199320 ## clients/client-python/gravitino/api/credential/azure_account_key_credential.py: ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895199803 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcPrivilege.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [#5675] feat(auth): Chain authorization plugin (part-1) [gravitino]

2024-12-22 Thread via GitHub
xunliu closed pull request #5695: [#5675] feat(auth): Chain authorization plugin (part-1) URL: https://github.com/apache/gravitino/pull/5695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895199164 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

Re: [PR] [#5895] support ADLSToken/AzureAccountKey credential for python client [gravitino]

2024-12-22 Thread via GitHub
FANNG1 commented on code in PR #5940: URL: https://github.com/apache/gravitino/pull/5940#discussion_r1895201709 ## clients/client-python/gravitino/api/credential/adls_token_credential.py: ## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

Re: [I] [Subtask] Optimize CI pipeline tasks to avoid executing unrelated modules. [gravitino]

2024-12-22 Thread via GitHub
diqiu50 commented on issue #5885: URL: https://github.com/apache/gravitino/issues/5885#issuecomment-2558795073 Yes, we need to check the others' workflow too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#5794] feat(core): Add ModelOperationDispatcher logic [gravitino]

2024-12-22 Thread via GitHub
jerryshao commented on code in PR #5908: URL: https://github.com/apache/gravitino/pull/5908#discussion_r1895178163 ## core/src/main/java/org/apache/gravitino/catalog/EntityCombinedModel.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5730] feat(client-python): Add sorts expression [gravitino]

2024-12-22 Thread via GitHub
xunliu commented on code in PR #5879: URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895180632 ## clients/client-python/gravitino/api/expressions/sorts/sort_direction.py: ## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

Re: [PR] [#5730] feat(client-python): Add sorts expression [gravitino]

2024-12-22 Thread via GitHub
xunliu commented on code in PR #5879: URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895180868 ## clients/client-python/gravitino/api/expressions/sorts/sort_orders.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [I] [Subtask] Handle file name encoding and special characters. [gravitino]

2024-12-22 Thread via GitHub
diqiu50 commented on issue #5869: URL: https://github.com/apache/gravitino/issues/5869#issuecomment-2558800723 My current concern is that I am unsure whether our handling of special characters in filenames and various encodings is correct. We need to test this, and if there are no issues, t

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895184382 ## authorizations/authorization-jdbc/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Ap

Re: [PR] [#5661] feat(auth): Add JDBC authorization plugin interface [gravitino]

2024-12-22 Thread via GitHub
jerqi commented on code in PR #5904: URL: https://github.com/apache/gravitino/pull/5904#discussion_r1895198247 ## authorizations/authorization-jdbc/src/test/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPluginTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to th

Re: [I] [FEATURE] Hive3 Metastore Multi Catalog Support [gravitino]

2024-12-22 Thread via GitHub
an-shi-chi-fan commented on issue #5912: URL: https://github.com/apache/gravitino/issues/5912#issuecomment-2558841964 > Hi @an-shi-chi-fan , thanks for your draft proposal about Hive3 support! > > Could you kindly transfer the design to a Google document and provide the link for us to

[PR] [#5817] core(feat): Add server-side REST APIs for model management [gravitino]

2024-12-22 Thread via GitHub
jerryshao opened a new pull request, #5948: URL: https://github.com/apache/gravitino/pull/5948 ### What changes were proposed in this pull request? This PR adds the server-side REST endpoint for model management. ### Why are the changes needed? This is a part of model man

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558486920 > > > LGTM > > > > > > hi @tengqm , could you plz approve this pr and workflows? > > I don't have the privileges to merge PRs. thank you @tengqm , I'd really a

Re: [PR] [#5926] fix(CLI): Fix Missleading error message in Gravitino CLI when missing schema [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5939: URL: https://github.com/apache/gravitino/pull/5939#issuecomment-2558486399 @justinmclean @xunliu ,could you please review this PR when you have a moment? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To

Re: [PR] [#5927] improvement(CLI): fix cli get multiple "Malformed entity name." [gravitino]

2024-12-22 Thread via GitHub
Abyss-lord commented on PR #5943: URL: https://github.com/apache/gravitino/pull/5943#issuecomment-2558496771 Hi @justinmclean @xunliu @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Serv

  1   2   >