tengqm commented on code in PR #5941:
URL: https://github.com/apache/gravitino/pull/5941#discussion_r1895111502
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java:
##########
@@ -60,7 +60,7 @@ public void handle() {
exitWithError(exp.getMessage());
}
- String all = String.join(",", roles);
+ String all = roles.isEmpty() ? "User has no roles." : String.join(",",
roles);
Review Comment:
```suggestion
String all = roles.isEmpty() ? "The user has no roles." :
String.join(",", roles);
```
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java:
##########
@@ -60,7 +60,7 @@ public void handle() {
exitWithError(exp.getMessage());
}
- String all = String.join(",", roles);
+ String all = roles.isEmpty() ? "Groups has no roles." : String.join(",",
roles);
Review Comment:
```suggestion
String all = roles.isEmpty() ? "The group has no roles." :
String.join(",", roles);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
