FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895209349
##########
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##########
@@ -19,11 +19,25 @@
package org.apache.gravitino.listener;
import java.util.Map;
+
import org.apache.gravitino.MetadataObject;
import org.apache.gravitino.exceptions.NoSuchTagException;
+import org.apache.gravitino.listener.api.event.AlterTagFailureEvent;
+import
org.apache.gravitino.listener.api.event.AssociateTagsForMetadataObjectFailureEvent;
+import org.apache.gravitino.listener.api.event.CreateTagFailureEvent;
+import org.apache.gravitino.listener.api.event.DeleteTagFailureEvent;
+import org.apache.gravitino.listener.api.event.GetTagFailureEvent;
+import
org.apache.gravitino.listener.api.event.GetTagForMetadataObjectFailureEvent;
+import
org.apache.gravitino.listener.api.event.ListMetadataObjectsForTagFailureEvent;
+import org.apache.gravitino.listener.api.event.ListTagFailureEvent;
+import
org.apache.gravitino.listener.api.event.ListTagsForMetadataObjectFailureEvent;
+import org.apache.gravitino.listener.api.event.ListTagsInfoFailureEvent;
+import
org.apache.gravitino.listener.api.event.ListTagsInfoForMetadataObjectFailureEvent;
+import org.apache.gravitino.listener.api.info.MetalakeInfo;
import org.apache.gravitino.tag.Tag;
import org.apache.gravitino.tag.TagChange;
import org.apache.gravitino.tag.TagDispatcher;
+import org.apache.gravitino.utils.PrincipalUtils;
Review Comment:
please remove `@SuppressWarnings("unused")` in TagEventDispatcher
```
@SuppressWarnings("unused")
private final EventBus eventBus;
```
##########
core/src/main/java/org/apache/gravitino/listener/api/event/TagFailureEvent.java:
##########
@@ -0,0 +1,7 @@
+package org.apache.gravitino.listener.api.event;
+
+public class TagFailureEvent extends FailureEvent {
+ public TagFailureEvent(String user, Exception exception) {
+ super(user, null, exception);
Review Comment:
identifier should not be null for tag event.
##########
core/src/main/java/org/apache/gravitino/listener/api/event/OperationType.java:
##########
@@ -31,6 +31,20 @@ public enum OperationType {
REGISTER_TABLE,
TABLE_EXISTS,
+ // Tag operations
+ CREATE_TAG,
+ GET_TAG,
+ GET_TAG_FOR_METADATA_OBJECT,
+ DELETE_TAG,
+ ALTER_TAG,
+ LIST_TAG,
+ TAG_EXISTS,
Review Comment:
`TAG_EXISTS` not used? please remove it
##########
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##########
@@ -73,21 +87,22 @@ public Tag getTag(String metalake, String name) throws
NoSuchTagException {
try {
// TODO: getTagEvent
return dispatcher.getTag(metalake, name);
- } catch (NoSuchTagException e) {
- // TODO: getTagFailureEvent
+ } catch (Exception e) {
+ eventBus.dispatchEvent(new
GetTagFailureEvent(PrincipalUtils.getCurrentUserName(), metalake, name, e));
throw e;
}
}
@Override
public Tag createTag(
String metalake, String name, String comment, Map<String, String>
properties) {
+ MetalakeInfo metalakeInfo = new MetalakeInfo(name, comment, properties,
null);
Review Comment:
we should create a `TagInfo` not `MetalakeInfo` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
