justinmclean commented on code in PR #5943:
URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895340107


##########
clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java:
##########
@@ -29,6 +29,8 @@ public class FullName {
   private final CommandLine line;
   private String metalakeEnv;
   private boolean matalakeSet = false;
+  private boolean isMissingNameInfoVisible = true;
+  private boolean isMalformedInfoVisible = true;

Review Comment:
   Note I'm on holiday for the next two weeks and may be slow in responding. A) 
this check only needs to be done in one place and B) we have added an error 
message that says what is missing. Ideally, we would have a better validation 
system. However, all suggestions along those lines so far have been seen as too 
complex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to