[GitHub] [incubator-doris] yiguolei commented on issue #8374: [Feature] support TiKV as an option for metadata storage

2022-03-07 Thread GitBox
yiguolei commented on issue #8374: URL: https://github.com/apache/incubator-doris/issues/8374#issuecomment-1060291918 Currently, doris store rowset meta and tablet meta in local rocksdb. Could you explain more detail why need to store it to a external global KV store? -- This is an aut

[GitHub] [incubator-doris] wangbo commented on issue #8374: [Feature] support TiKV as an option for metadata storage

2022-03-07 Thread GitBox
wangbo commented on issue #8374: URL: https://github.com/apache/incubator-doris/issues/8374#issuecomment-1060298717 Doris's FE and BE both has metadata, so which part do you want to replace? Can you offer more detailed design? -- This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-07 Thread GitBox
wangbo commented on pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1060312019 We did a performance test for this pr in SSB, no significant improvement. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] dataroaring opened a new pull request #8375: add an aggregation test from trino.

2022-03-07 Thread GitBox
dataroaring opened a new pull request #8375: URL: https://github.com/apache/incubator-doris/pull/8375 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] yangzhg commented on pull request #8358: [Doc][Vectorized] Add vectorized execution engine docs

2022-03-07 Thread GitBox
yangzhg commented on pull request #8358: URL: https://github.com/apache/incubator-doris/pull/8358#issuecomment-1060327441 It is better to redraw those two images, the source of those two images is unknown -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8363: [fix](broker-load) fix bug that a cancelled job's state is LOADING

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8363: URL: https://github.com/apache/incubator-doris/pull/8363#issuecomment-1060329065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8376: [Bug] fe start fail

2022-03-07 Thread GitBox
BiteThet opened a new issue #8376: URL: https://github.com/apache/incubator-doris/issues/8376 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version m

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8377: [Bug] fe start fail

2022-03-07 Thread GitBox
BiteThet opened a new pull request #8377: URL: https://github.com/apache/incubator-doris/pull/8377 # Proposed changes Issue Number: close #8376 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [incubator-doris] xinyiZzz closed pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-03-07 Thread GitBox
xinyiZzz closed pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] morrySnow opened a new issue #8378: [Enhancement] [doc] there are some dead link in fe doc pages

2022-03-07 Thread GitBox
morrySnow opened a new issue #8378: URL: https://github.com/apache/incubator-doris/issues/8378 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #8322: [refactor] Impl of MemTracker, and related use

2022-03-07 Thread GitBox
xinyiZzz commented on a change in pull request #8322: URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820504386 ## File path: be/src/exec/es/es_scroll_parser.cpp ## @@ -410,11 +411,12 @@ Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, Tu

[GitHub] [incubator-doris] morrySnow opened a new pull request #8379: Fix dead link in build docker environment in developer guide

2022-03-07 Thread GitBox
morrySnow opened a new pull request #8379: URL: https://github.com/apache/incubator-doris/pull/8379 # Proposed changes Issue Number: close #8378 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8379: Fix dead link in build docker environment in developer guide

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8379: URL: https://github.com/apache/incubator-doris/pull/8379#issuecomment-1060399237 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] HappenLee commented on pull request #8358: [Doc][Vectorized] Add vectorized execution engine docs

2022-03-07 Thread GitBox
HappenLee commented on pull request #8358: URL: https://github.com/apache/incubator-doris/pull/8358#issuecomment-1060407124 > It is better to redraw those two images, the source of those two images is unknown had set quoted from [Column-Oriented Database Systems](https://web.stan

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8379: Fix dead link in build docker environment in developer guide

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8379: URL: https://github.com/apache/incubator-doris/pull/8379#issuecomment-1060413099 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8373: [Refactor] to_bitmap(-1) return NULL instead of return parse failed error_message

2022-03-07 Thread GitBox
HappenLee commented on a change in pull request #8373: URL: https://github.com/apache/incubator-doris/pull/8373#discussion_r820543213 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -358,21 +358,17 @@ BigIntVal BitmapFunctions::bitmap_min(FunctionContext* ctx, const Strin

[GitHub] [incubator-doris] morningman commented on pull request #8377: [Bug] fe start fail

2022-03-07 Thread GitBox
morningman commented on pull request #8377: URL: https://github.com/apache/incubator-doris/pull/8377#issuecomment-1060418509 Hi @BiteThet , this bug has been fixed in #8355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #8377: [Bug] fe start fail

2022-03-07 Thread GitBox
BiteThet commented on pull request #8377: URL: https://github.com/apache/incubator-doris/pull/8377#issuecomment-1060506691 > Hi @BiteThet , this bug has been fixed in #8355 ok -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] BiteTheDDDDt closed pull request #8377: [Bug] fe start fail

2022-03-07 Thread GitBox
BiteThet closed pull request #8377: URL: https://github.com/apache/incubator-doris/pull/8377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-doris] BiteTheDDDDt closed issue #8376: [Bug] fe start fail

2022-03-07 Thread GitBox
BiteThet closed issue #8376: URL: https://github.com/apache/incubator-doris/issues/8376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8380: [Bug] fix core dump on minmax_filter with decimal type

2022-03-07 Thread GitBox
BiteThet opened a new issue #8380: URL: https://github.com/apache/incubator-doris/issues/8380 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version m

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8381: [Bug] fix core dump on minmax_filter with decimal type

2022-03-07 Thread GitBox
BiteThet opened a new pull request #8381: URL: https://github.com/apache/incubator-doris/pull/8381 # Proposed changes Issue Number: close #8380 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [incubator-doris] BiteTheDDDDt commented on issue #8317: [Bug] core dump on BrokerScanNode with clang

2022-03-07 Thread GitBox
BiteThet commented on issue #8317: URL: https://github.com/apache/incubator-doris/issues/8317#issuecomment-1060523949 > Does it show the core dump reason, like segment fault? yes, the reason is segmentation fault. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #8322: [refactor] Impl of MemTracker, and related use

2022-03-07 Thread GitBox
xinyiZzz commented on a change in pull request #8322: URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820598899 ## File path: be/src/exprs/expr_context.cpp ## @@ -371,10 +376,11 @@ Status ExprContext::get_const_value(RuntimeState* state, Expr& expr, AnyVal

[GitHub] [incubator-doris] dataroaring opened a new issue #8382: [Bug] variance is different with trino

2022-03-07 Thread GitBox
dataroaring opened a new issue #8382: URL: https://github.com/apache/incubator-doris/issues/8382 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version ma

[GitHub] [incubator-doris] BiteTheDDDDt closed issue #8262: [Bug][Vectorized] Be core dump on memtable

2022-03-07 Thread GitBox
BiteThet closed issue #8262: URL: https://github.com/apache/incubator-doris/issues/8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] coderjiang commented on issue #5103: doris怎么删除昨天的数据

2022-03-07 Thread GitBox
coderjiang commented on issue #5103: URL: https://github.com/apache/incubator-doris/issues/5103#issuecomment-1060563392 DELETE FROM ods_order_report WHERE purchase_date_local >= DATE_ADD('2022-03-06 00:00:00', INTERVAL 1 day); 这语句也是不行的,会报错: ERROR 1064 (HY000): errCode = 2, detailMess

[GitHub] [incubator-doris] coderjiang commented on issue #5103: doris怎么删除昨天的数据

2022-03-07 Thread GitBox
coderjiang commented on issue #5103: URL: https://github.com/apache/incubator-doris/issues/5103#issuecomment-1060564080 mysql> DELETE FROM ods_order_report WHERE purchase_date_local >= DATE_ADD('2022-03-06 00:00:00', INTERVAL 1 day); ERROR 1064 (HY000): errCode = 2, detailMessage = Righ

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
yangzhg commented on a change in pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#discussion_r820612758 ## File path: be/src/exprs/utility_functions.cpp ## @@ -39,4 +39,82 @@ BooleanVal UtilityFunctions::sleep(FunctionContext* ctx, const IntVal& sec

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
yangzhg commented on a change in pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#discussion_r820614209 ## File path: be/src/exprs/utility_functions.cpp ## @@ -39,4 +39,82 @@ BooleanVal UtilityFunctions::sleep(FunctionContext* ctx, const IntVal& sec

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8383: [Feature][Vectorized] support replace()

2022-03-07 Thread GitBox
BiteThet opened a new issue #8383: URL: https://github.com/apache/incubator-doris/issues/8383 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8384: [Feature][Vectorized] support replace()

2022-03-07 Thread GitBox
BiteThet opened a new pull request #8384: URL: https://github.com/apache/incubator-doris/pull/8384 # Proposed changes @HappenLee Issue Number: close #8383 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #8322: [refactor] Impl of MemTracker, and related use

2022-03-07 Thread GitBox
xinyiZzz commented on a change in pull request #8322: URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820638296 ## File path: be/src/olap/task/engine_alter_tablet_task.cpp ## @@ -18,13 +18,21 @@ #include "olap/task/engine_alter_tablet_task.h" #include "

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8381: [Bug] fix core dump on minmax_filter with decimal type

2022-03-07 Thread GitBox
HappenLee commented on a change in pull request #8381: URL: https://github.com/apache/incubator-doris/pull/8381#discussion_r820653466 ## File path: be/src/exprs/minmax_predicate.h ## @@ -42,9 +42,14 @@ class MinMaxNumFunc : public MinMaxFuncBase { public: MinMaxNumFunc()

[GitHub] [incubator-doris] HappenLee opened a new issue #8385: [Bug][Vectorized] Datetime type read error result

2022-03-07 Thread GitBox
HappenLee opened a new issue #8385: URL: https://github.com/apache/incubator-doris/issues/8385 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version vect

[GitHub] [incubator-doris] HappenLee opened a new pull request #8386: [Bug][Vectorized] Fix the datetime type read error and is_same set error in reader

2022-03-07 Thread GitBox
HappenLee opened a new pull request #8386: URL: https://github.com/apache/incubator-doris/pull/8386 # Proposed changes Issue Number: close #8385 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] cambyzju commented on a change in pull request #8217: [feature][array-type]support select ARRAY data type on vectorized engine

2022-03-07 Thread GitBox
cambyzju commented on a change in pull request #8217: URL: https://github.com/apache/incubator-doris/pull/8217#discussion_r820707304 ## File path: be/src/vec/columns/column_array.cpp ## @@ -0,0 +1,700 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] cambyzju commented on a change in pull request #8217: [feature][array-type]support select ARRAY data type on vectorized engine

2022-03-07 Thread GitBox
cambyzju commented on a change in pull request #8217: URL: https://github.com/apache/incubator-doris/pull/8217#discussion_r820727165 ## File path: be/src/vec/columns/column_array.cpp ## @@ -0,0 +1,700 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] caiconghui opened a new pull request #8387: [Refactor](storage_engine) Use std::shared_lock to replace RWMutex

2022-03-07 Thread GitBox
caiconghui opened a new pull request #8387: URL: https://github.com/apache/incubator-doris/pull/8387 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] morningman commented on pull request #8387: [Refactor](storage_engine) Use std::shared_lock to replace RWMutex

2022-03-07 Thread GitBox
morningman commented on pull request #8387: URL: https://github.com/apache/incubator-doris/pull/8387#issuecomment-1060749080 Please describe the motivation and any possible performance impact, so that other reviewers can directly know what is going on. -- This is an automated message fro

[GitHub] [incubator-doris] morningman commented on pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
morningman commented on pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#issuecomment-1060793086 Seems like the code you changed in this PR does not related the problem you described in #8335 ? -- This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] morningman commented on pull request #8340: Translate Chinese comment to English

2022-03-07 Thread GitBox
morningman commented on pull request #8340: URL: https://github.com/apache/incubator-doris/pull/8340#issuecomment-1060795516 > You'd better cleanup your commits by removing useless commits like '第一次提交'. You can use git force push. That would be OK, because we using "Squash" merge. So

[GitHub] [incubator-doris] morningman commented on pull request #8340: Translate Chinese comment to English

2022-03-07 Thread GitBox
morningman commented on pull request #8340: URL: https://github.com/apache/incubator-doris/pull/8340#issuecomment-1060796247 > There are a lot of Chinese comments, I prefer to clean together. I think we can simply merge this PR. And doing what you prefer later? -- This is an automa

[GitHub] [incubator-doris] morningman merged pull request #8275: [community] Modify doris connector release doc

2022-03-07 Thread GitBox
morningman merged pull request #8275: URL: https://github.com/apache/incubator-doris/pull/8275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8340: Translate Chinese comment to English

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8340: URL: https://github.com/apache/incubator-doris/pull/8340#issuecomment-1060797540 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-doris] branch master updated (d9c2c2c -> c647def)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from d9c2c2c Revert "[refactor] remove unused new_in_predicate code (#8263)" (#8372) add c647def [com

[GitHub] [incubator-doris] morningman commented on pull request #8324: [Feature](proc) Support proc dir for showing tablet health status

2022-03-07 Thread GitBox
morningman commented on pull request #8324: URL: https://github.com/apache/incubator-doris/pull/8324#issuecomment-1060799805 Why don't just add new columns to `show proc "/statistic"`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] morningman merged pull request #8325: [typo]fix some typo in fe_config

2022-03-07 Thread GitBox
morningman merged pull request #8325: URL: https://github.com/apache/incubator-doris/pull/8325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman merged pull request #8350: [license] Organize third-party dependent licenses for bianry releases

2022-03-07 Thread GitBox
morningman merged pull request #8350: URL: https://github.com/apache/incubator-doris/pull/8350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman merged pull request #8352: [improvement]support build with parallel parameter only

2022-03-07 Thread GitBox
morningman merged pull request #8352: URL: https://github.com/apache/incubator-doris/pull/8352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (c647def -> ca3be24)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c647def [community] Modify doris connector release doc (#8275) add ca3be24 [typo]fix some typo in

[incubator-doris] branch master updated (ca3be24 -> 50a59f3)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ca3be24 [typo]fix some typo in fe_config (#8325) add 50a59f3 [license] Organize third-party depen

[incubator-doris] branch master updated (50a59f3 -> 089ef53)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 50a59f3 [license] Organize third-party dependent licenses for bianry releases (#8350) add 089ef53

[GitHub] [incubator-doris] morningman commented on pull request #7529: Support remote storage, step2, only for be: hot data trans to cold data. clean cold data when drop table

2022-03-07 Thread GitBox
morningman commented on pull request #7529: URL: https://github.com/apache/incubator-doris/pull/7529#issuecomment-1060820068 Please update the PR comment to describe the new implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8096: [optimize] optimze tablet read, avoid to create too much scanner for small tablet

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8096: URL: https://github.com/apache/incubator-doris/pull/8096#issuecomment-1060826763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on a change in pull request #8305: [feature-wip][array-type] Support nested array insertion.

2022-03-07 Thread GitBox
morningman commented on a change in pull request #8305: URL: https://github.com/apache/incubator-doris/pull/8305#discussion_r820833353 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java ## @@ -373,6 +373,9 @@ private void toChildrenThrift(Column column,

[GitHub] [incubator-doris] morningman commented on a change in pull request #8368: [feature-wip][array-type] Array data can be loaded in stream load.

2022-03-07 Thread GitBox
morningman commented on a change in pull request #8368: URL: https://github.com/apache/incubator-doris/pull/8368#discussion_r820839495 ## File path: be/src/util/array_parser.hpp ## @@ -0,0 +1,215 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [incubator-doris] adonis0147 commented on a change in pull request #8305: [feature-wip][array-type] Support nested array insertion.

2022-03-07 Thread GitBox
adonis0147 commented on a change in pull request #8305: URL: https://github.com/apache/incubator-doris/pull/8305#discussion_r820847392 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java ## @@ -373,6 +373,9 @@ private void toChildrenThrift(Column column,

[GitHub] [incubator-doris] adonis0147 commented on a change in pull request #8305: [feature-wip][array-type] Support nested array insertion.

2022-03-07 Thread GitBox
adonis0147 commented on a change in pull request #8305: URL: https://github.com/apache/incubator-doris/pull/8305#discussion_r820847392 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java ## @@ -373,6 +373,9 @@ private void toChildrenThrift(Column column,

[GitHub] [incubator-doris] carlvinhust2012 commented on a change in pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 commented on a change in pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#discussion_r821251157 ## File path: be/src/exprs/utility_functions.cpp ## @@ -39,4 +39,82 @@ BooleanVal UtilityFunctions::sleep(FunctionContext* ctx, const Int

[GitHub] [incubator-doris] carlvinhust2012 commented on a change in pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 commented on a change in pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#discussion_r821251569 ## File path: be/src/exprs/utility_functions.cpp ## @@ -39,4 +39,82 @@ BooleanVal UtilityFunctions::sleep(FunctionContext* ctx, const Int

[GitHub] [incubator-doris-flink-connector] hf200012 merged pull request #12: [refactor]doris sink enable 2pc

2022-03-07 Thread GitBox
hf200012 merged pull request #12: URL: https://github.com/apache/incubator-doris-flink-connector/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-doris-flink-connector] hf200012 commented on pull request #13: Feature/20220305 support flush when batch bytes reach threshold

2022-03-07 Thread GitBox
hf200012 commented on pull request #13: URL: https://github.com/apache/incubator-doris-flink-connector/pull/13#issuecomment-1061321741 Resolve a conflict @bridgeDream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] carlvinhust2012 closed pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 closed pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-doris] carlvinhust2012 commented on pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 commented on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061322368 > Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimization in

[GitHub] [incubator-doris] carlvinhust2012 commented on pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 commented on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061326259 > Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimization in

[GitHub] [incubator-doris] carlvinhust2012 edited a comment on pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 edited a comment on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061326259 > Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimizat

[GitHub] [incubator-doris] carlvinhust2012 commented on pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 commented on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061326860 > > Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimization i

[GitHub] [incubator-doris] carlvinhust2012 removed a comment on pull request #8364: [Function] Add compare_version function and ut

2022-03-07 Thread GitBox
carlvinhust2012 removed a comment on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061326259 > Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimiza

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
yangzhg commented on a change in pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#discussion_r821258659 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java ## @@ -232,16 +232,17 @@ public static String checkPath(String pa

[GitHub] [incubator-doris] wangbo opened a new issue #8388: [Enhancement] Avoid read index bitmap when no index is provided

2022-03-07 Thread GitBox
wangbo opened a new issue #8388: URL: https://github.com/apache/incubator-doris/issues/8388 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Whe

[GitHub] [incubator-doris] Henry2SS commented on pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
Henry2SS commented on pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#issuecomment-1061349709 > It is. URI not support '{}' '[]'. And when the path contains '{}' '[]', `URISyntaxException` will be thrown out. This is the reason for the problem de

[GitHub] [incubator-doris] Henry2SS removed a comment on pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
Henry2SS removed a comment on pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#issuecomment-1061349709 > It is. URI not support '{}' '[]'. And when the path contains '{}' '[]', `URISyntaxException` will be thrown out. This is the reason for the pr

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8386: [Bug][Vectorized] Fix the datetime type read error and is_same set error in reader

2022-03-07 Thread GitBox
wangbo commented on a change in pull request #8386: URL: https://github.com/apache/incubator-doris/pull/8386#discussion_r821275926 ## File path: be/src/vec/olap/vcollect_iterator.cpp ## @@ -129,7 +129,14 @@ bool VCollectIterator::LevelIteratorComparator::operator()(LevelIterat

[GitHub] [incubator-doris] Henry2SS commented on pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
Henry2SS commented on pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#issuecomment-1061350644 > Seems like the code you changed in this PR does not related the problem you described in #8335 ? It is. URI doesn't support '{}' '[]', and when a path conta

[GitHub] [incubator-doris] Henry2SS commented on a change in pull request #8336: [improvment](broker load) fix broker load check logic

2022-03-07 Thread GitBox
Henry2SS commented on a change in pull request #8336: URL: https://github.com/apache/incubator-doris/pull/8336#discussion_r821278406 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java ## @@ -232,16 +232,17 @@ public static String checkPath(String p

[GitHub] [incubator-doris] adonis0147 commented on a change in pull request #8368: [feature-wip][array-type] Array data can be loaded in stream load.

2022-03-07 Thread GitBox
adonis0147 commented on a change in pull request #8368: URL: https://github.com/apache/incubator-doris/pull/8368#discussion_r821279648 ## File path: be/src/util/array_parser.hpp ## @@ -0,0 +1,215 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [incubator-doris] hf200012 commented on pull request #8369: [docs] Update documentation configuration parameter `sink.batch.bytes…

2022-03-07 Thread GitBox
hf200012 commented on pull request #8369: URL: https://github.com/apache/incubator-doris/pull/8369#issuecomment-1061355224 fix the code problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8386: [Bug][Vectorized] Fix the datetime type read error and is_same set error in reader

2022-03-07 Thread GitBox
wangbo commented on a change in pull request #8386: URL: https://github.com/apache/incubator-doris/pull/8386#discussion_r821275926 ## File path: be/src/vec/olap/vcollect_iterator.cpp ## @@ -129,7 +129,14 @@ bool VCollectIterator::LevelIteratorComparator::operator()(LevelIterat

[GitHub] [incubator-doris] HappenLee commented on pull request #8384: [Feature][Vectorized] support replace()

2022-03-07 Thread GitBox
HappenLee commented on pull request #8384: URL: https://github.com/apache/incubator-doris/pull/8384#issuecomment-1061363767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] caiconghui commented on pull request #8387: [Refactor](storage_engine) Use std::shared_lock to replace RWMutex

2022-03-07 Thread GitBox
caiconghui commented on pull request #8387: URL: https://github.com/apache/incubator-doris/pull/8387#issuecomment-1061365634 > Please describe the motivation and any possible performance impact, so that other reviewers can directly know what is going on. the motivation is to use the

[GitHub] [incubator-doris] caiconghui commented on pull request #8324: [Feature](proc) Support proc dir for showing tablet health status

2022-03-07 Thread GitBox
caiconghui commented on pull request #8324: URL: https://github.com/apache/incubator-doris/pull/8324#issuecomment-1061366922 > Why don't just add new columns to `show proc "/statistic"`? cannot find a suitable place to append this, which may cause /statistic info verbose and not easy

[GitHub] [incubator-doris] lordk911 commented on issue #7502: Doris Roadmap 2022

2022-03-07 Thread GitBox
lordk911 commented on issue #7502: URL: https://github.com/apache/incubator-doris/issues/7502#issuecomment-1061367317 want to know when will vectorized query engine could be released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8267: [fix](vectorization)Some small fix for SegmentIter Vectorization

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8267: URL: https://github.com/apache/incubator-doris/pull/8267#issuecomment-1061369587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8307: [Vectorized][Function] support regexp&&sm4&&aes functions

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #8307: URL: https://github.com/apache/incubator-doris/pull/8307#issuecomment-1061375913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #8324: [Feature](proc) Support proc dir for showing tablet health status

2022-03-07 Thread GitBox
morningman commented on pull request #8324: URL: https://github.com/apache/incubator-doris/pull/8324#issuecomment-1061394173 > So maybe it is better to move some column from `/statistic` to `/cluster_health`? such as `UnhealthyTabletNum` and `InconsistentTabletNum`? Otherwise we ne

[GitHub] [incubator-doris] caiconghui commented on pull request #8324: [Feature](proc) Support proc dir for showing tablet health status

2022-03-07 Thread GitBox
caiconghui commented on pull request #8324: URL: https://github.com/apache/incubator-doris/pull/8324#issuecomment-1061396132 > > > > So maybe it is better to move some column from `/statistic` to `/cluster_health`? such as `UnhealthyTabletNum` and `InconsistentTabletNum`? Otherwise

[GitHub] [incubator-doris] morningman merged pull request #8267: [fix](vectorization)Some small fix for SegmentIter Vectorization

2022-03-07 Thread GitBox
morningman merged pull request #8267: URL: https://github.com/apache/incubator-doris/pull/8267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [fix](vectorization)Some small fix for SegmentIter Vectorization (#8267)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new d711d64 [fix](vectorization)Some s

[GitHub] [incubator-doris] morningman closed issue #8306: [Vectorized][Feature] support regexp&&sm4&&aes function

2022-03-07 Thread GitBox
morningman closed issue #8306: URL: https://github.com/apache/incubator-doris/issues/8306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[incubator-doris] branch master updated: [feature](vectorize)(function) support regexp&&sm4&&aes functions (#8307)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 454b45b [feature](vectorize)(funct

[GitHub] [incubator-doris] morningman merged pull request #8307: [Vectorized][Function] support regexp&&sm4&&aes functions

2022-03-07 Thread GitBox
morningman merged pull request #8307: URL: https://github.com/apache/incubator-doris/pull/8307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman commented on a change in pull request #8355: [improvement][fix](insert)(replay) support SHOW LAST INSERT stmt and fix json replay bug

2022-03-07 Thread GitBox
morningman commented on a change in pull request #8355: URL: https://github.com/apache/incubator-doris/pull/8355#discussion_r821328248 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowLastInsertStmt.java ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] morningman commented on a change in pull request #8355: [improvement][fix](insert)(replay) support SHOW LAST INSERT stmt and fix json replay bug

2022-03-07 Thread GitBox
morningman commented on a change in pull request #8355: URL: https://github.com/apache/incubator-doris/pull/8355#discussion_r821328248 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowLastInsertStmt.java ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Softwa

[incubator-doris] 03/05: [fix](vectorization)Some small fix for SegmentIter Vectorization (#8267)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 9b6de9be424279ad5d33bfd74de9c8dfbfcc547e Author: wangbo AuthorDate: Tue Mar 8 13:13:17 2022 +0800 [

[incubator-doris] 01/05: Revert "[refactor] remove unused new_in_predicate code (#8263)" (#8372)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit cadf19ae38bc2e4a88c27263bb703762695ccf4e Author: Zhengguo Yang <780531...@qq.com> AuthorDate: Mon Mar 7 1

[incubator-doris] 05/05: [improvement] Support show tablets stmt (#7970)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit d2b88edfdab7179f580e587c85007e27f7818cf1 Author: ChPi AuthorDate: Sat Mar 5 15:25:57 2022 +0800 [im

[incubator-doris] 02/05: [chore] fix build with parallel parameter only (#8352)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 26f55dabcd87fff37180cce6ecbdd122f591f90d Author: dataalive <99398130+dataal...@users.noreply.github.com>

[incubator-doris] 04/05: [feature](vectorize)(function) support regexp&&sm4&&aes functions (#8307)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 209c5a173b1335514af0f1e57f033b2c21803097 Author: zhangstar333 <87313068+zhangstar...@users.noreply.github

[incubator-doris] branch dev-1.0.0 updated (d7f8a5d -> d2b88ed)

2022-03-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from d7f8a5d [feature](vec) Support update stmt in vec query engine (#8296) new cadf19a Revert "[re

  1   2   >