carlvinhust2012 commented on pull request #8364: URL: https://github.com/apache/incubator-doris/pull/8364#issuecomment-1061326259
> Why not `compare_version(ver1 , ver2)` return 0 if equal, 1 if ver1 > ver2, -1 if ver1 < ver2 ? In addition, there is still a lot of room for optimization in the implementation of the program We discussed this approach with the business, but they still prefer to use the current approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org