HappenLee commented on a change in pull request #8381:
URL: https://github.com/apache/incubator-doris/pull/8381#discussion_r820653466
##########
File path: be/src/exprs/minmax_predicate.h
##########
@@ -42,9 +42,14 @@ class MinMaxNumFunc : public MinMaxFuncBase {
public:
MinMaxNumFunc() = default;
~MinMaxNumFunc() = default;
- virtual void insert(const void* data) {
- if (data == nullptr) return;
- const T val_data = *reinterpret_cast<const T*>(data);
+ void insert(const void* data) override {
+ if (data == nullptr) {
+ return;
+ }
+
Review comment:
only core when int128_t, so maybe constexpr + sizeof.
and add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
